Completed
Pull Request — master (#373)
by Loïc
01:38
created

SplFileInfoPatch   A

Complexity

Total Complexity 14

Size/Duplication

Total Lines 101
Duplicated Lines 11.88 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 3
Bugs 0 Features 0
Metric Value
wmc 14
c 3
b 0
f 0
lcom 1
cbo 2
dl 12
loc 101
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A supports() 0 9 3
B apply() 12 31 5
A getPriority() 0 4 1
A nodeIsDirectoryIterator() 0 7 2
A nodeIsSplFileObject() 0 7 2
A nodeIsSymfonySplFileInfo() 0 6 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/*
4
 * This file is part of the Prophecy.
5
 * (c) Konstantin Kudryashov <[email protected]>
6
 *     Marcello Duarte <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Prophecy\Doubler\ClassPatch;
13
14
use Prophecy\Doubler\Generator\Node\ClassNode;
15
use Prophecy\Doubler\Generator\Node\MethodNode;
16
17
/**
18
 * SplFileInfo patch.
19
 * Makes SplFileInfo and derivative classes usable with Prophecy.
20
 *
21
 * @author Konstantin Kudryashov <[email protected]>
22
 */
23
class SplFileInfoPatch implements ClassPatchInterface
24
{
25
    /**
26
     * Supports everything that extends SplFileInfo.
27
     *
28
     * @param ClassNode $node
29
     *
30
     * @return bool
31
     */
32
    public function supports(ClassNode $node)
33
    {
34
        if (null === $node->getParentClass()) {
35
            return false;
36
        }
37
        return 'SplFileInfo' === $node->getParentClass()
38
            || is_subclass_of($node->getParentClass(), 'SplFileInfo')
39
        ;
40
    }
41
42
    /**
43
     * Updated constructor code to call parent one with dummy file argument.
44
     *
45
     * @param ClassNode $node
46
     */
47
    public function apply(ClassNode $node)
48
    {
49
        if ($node->hasMethod('__construct')) {
50
            $constructor = $node->getMethod('__construct');
51
        } else {
52
            $constructor = new MethodNode('__construct');
53
            $node->addMethod($constructor);
54
        }
55
56
        if ($this->nodeIsDirectoryIterator($node)) {
57
            $constructor->setCode('return parent::__construct("' . __DIR__ . '");');
58
59
            return;
60
        }
61
62 View Code Duplication
        if ($this->nodeIsSplFileObject($node)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
63
            $filePath = str_replace('\\','\\\\',__FILE__);
64
            $constructor->setCode('return parent::__construct("' . $filePath .'");');
65
66
            return;
67
        }
68
69 View Code Duplication
        if ($this->nodeIsSymfonySplFileInfo($node)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
70
            $filePath = str_replace('\\','\\\\',__FILE__);
71
            $constructor->setCode('return parent::__construct("' . $filePath .'", "", "");');
72
73
            return;
74
        }
75
76
        $constructor->useParentCode();
77
    }
78
79
    /**
80
     * Returns patch priority, which determines when patch will be applied.
81
     *
82
     * @return int Priority number (higher - earlier)
83
     */
84
    public function getPriority()
85
    {
86
        return 50;
87
    }
88
89
    /**
90
     * @param ClassNode $node
91
     * @return boolean
92
     */
93
    private function nodeIsDirectoryIterator(ClassNode $node)
94
    {
95
        $parent = $node->getParentClass();
96
97
        return 'DirectoryIterator' === $parent
98
            || is_subclass_of($parent, 'DirectoryIterator');
99
    }
100
101
    /**
102
     * @param ClassNode $node
103
     * @return boolean
104
     */
105
    private function nodeIsSplFileObject(ClassNode $node)
106
    {
107
        $parent = $node->getParentClass();
108
109
        return 'SplFileObject' === $parent
110
            || is_subclass_of($parent, 'SplFileObject');
111
    }
112
113
    /**
114
     * @param ClassNode $node
115
     * @return boolean
116
     */
117
    private function nodeIsSymfonySplFileInfo(ClassNode $node)
118
    {
119
        $parent = $node->getParentClass();
120
121
        return 'Symfony\\Component\\Finder\\SplFileInfo' === $parent;
122
    }
123
}
124