| Conditions | 10 |
| Paths | 7 |
| Total Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function supports(ClassNode $node) |
||
| 33 | { |
||
| 34 | if (in_array('Iterator', $node->getInterfaces())) { |
||
| 35 | return false; |
||
| 36 | } |
||
| 37 | if (in_array('IteratorAggregate', $node->getInterfaces())) { |
||
| 38 | return false; |
||
| 39 | } |
||
| 40 | |||
| 41 | foreach ($node->getInterfaces() as $interface) { |
||
| 42 | if ('Traversable' !== $interface && !is_subclass_of($interface, 'Traversable')) { |
||
| 43 | continue; |
||
| 44 | } |
||
| 45 | if ('Iterator' === $interface || is_subclass_of($interface, 'Iterator')) { |
||
| 46 | continue; |
||
| 47 | } |
||
| 48 | if ('IteratorAggregate' === $interface || is_subclass_of($interface, 'IteratorAggregate')) { |
||
| 49 | continue; |
||
| 50 | } |
||
| 51 | |||
| 52 | return true; |
||
| 53 | } |
||
| 54 | |||
| 55 | return false; |
||
| 56 | } |
||
| 57 | |||
| 84 |