Response::__construct() - Code Metrics - Inspection of "Added Response Class - for future updates perhaps" - phpsa/laravel-yourls-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Craig

created 2019-07-10 22:18 UTC

Response::__construct() A

↳ Parent: Response

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	4
eloc	14
c	2
b	1
f	0
nc	4
nop	2
dl	0
loc	18
rs	9.7998

<?php

namespace Phpsa\LaravelYourlsPlugin;

class Response
{

    /**
     * status of the server response - fail is not nessisary a fail in this case.
     *
     * @var string
     */
    public $status;

    /**
     * status code of the server response.
     *
     * @var int
     */
    public $statusCode;

    /**
     * message from the response.
     *
     * @var string
     * @author Craig Smith <[email protected]>
     */
    public $message;


    public function __construct($body, $format)
    {
        switch ($format) {
            case 'xml':
                libxml_use_internal_errors(true);
                $res = simplexml_load_string((string) $body);
                if ($res) {
                    $res = json_decode(json_encode($res));
                }
                break;
            case 'json':
                $res = json_decode((string) $body);
                break;
            default:
                $res = (string) $body;
            break;
        }
        $this->parseResponseBody($res);
    }

    protected function parseResponseBody($body)
    {
        if(empty($body)) {
            throw new \Exception('No response recieved');
        }

        if (\is_string($body)) {
            $this->status = 'success';
            $this->statusCode = '200';
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $this->shorturl = $url;


            return;
        }

        foreach ((array) $body as $key => $value) {
            $this->{$key} = $value;
        }

    }

}


1			<?php
2
3			namespace Phpsa\LaravelYourlsPlugin;
4
5			class Response
6			{
7
8			/**
9			* status of the server response - fail is not nessisary a fail in this case.
10			*
11			* @var string
12			*/
13			public $status;
14
15			/**
16			* status code of the server response.
17			*
18			* @var int
19			*/
20			public $statusCode;
21
22			/**
23			* message from the response.
24			*
25			* @var string
26			* @author Craig Smith <[email protected]>
27			*/
28			public $message;
29
30
31			public function __construct($body, $format)
32			{
33			switch ($format) {
34			case 'xml':
35			libxml_use_internal_errors(true);
36			$res = simplexml_load_string((string) $body);
37			if ($res) {
38			$res = json_decode(json_encode($res));
39			}
40			break;
41			case 'json':
42			$res = json_decode((string) $body);
43			break;
44			default:
45			$res = (string) $body;
46			break;
47			}
48			$this->parseResponseBody($res);
49			}
50
51			protected function parseResponseBody($body)
52			{
53			if(empty($body)) {
54			throw new \Exception('No response recieved');
55			}
56
57			if (\is_string($body)) {
58			$this->status = 'success';
59			$this->statusCode = '200';
			0 ignored issues – show Documentation Bug introduced 2019-07-10 22:08 UTC by Report Bug Copy Issue Report The property `$statusCode` was declared of type `integer`, but `'200'` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
60			$this->shorturl = $url;
			1 ignored issue – show Comprehensibility Best Practice introduced 2019-07-10 22:08 UTC by Report Bug Copy Issue Report The variable `$url` seems to be never defined. Loading history... Bug Best Practice introduced 2019-07-10 22:08 UTC by Report Bug Copy Issue Report The property `shorturl` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
61
62			return;
63			}
64
65			foreach ((array) $body as $key => $value) {
66			$this->{$key} = $value;
67			}
68
69			}
70
71			}
72

phpsa / laravel-yourls-plugin

Pull Request — master (#2)

Response::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like