Phpsa\LaravelYourlsPlugin\Response

Complexity

Total Complexity

8

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Importance

Changes	4
Bugs	2	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	parseResponseBody()	0	16	4
A	__construct()	0	18	4

<?php

namespace Phpsa\LaravelYourlsPlugin;

class Response
{
    /**
     * status of the server response - fail is not nessisary a fail in this case.
     *
     * @var string
     */
    public $status;

    /**
     * status code of the server response.
     *
     * @var int
     */
    public $statusCode;

    /**
     * message from the response.
     *
     * @var string
     * @author Craig Smith <craig.smith@customd.com>
     */
    public $message;

    public function __construct($body, $format)
    {
        switch ($format) {
            case 'xml':
                libxml_use_internal_errors(true);
                $res = simplexml_load_string((string) $body);
                if ($res) {
                    $res = json_decode(json_encode($res));
                }
                break;
            case 'json':
                $res = json_decode((string) $body);
                break;
            default:
                $res = (string) $body;
            break;
        }
        $this->parseResponseBody($res);
    }

    protected function parseResponseBody($body)
    {
        if (empty($body)) {
            throw new \Exception('No response recieved');
        }

        if (\is_string($body)) {
            $this->status = 'success';
            $this->statusCode = '200';

The property $statusCode was declared of type integer, but '200' is of type string. Maybe add a type cast?

            $this->shorturl = $url;

The property shorturl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

The variable $url seems to be never defined.

            return;
        }

        foreach ((array) $body as $key => $value) {
            $this->{$key} = $value;
        }
    }
}