Phpsa\Datastore\Http\Controllers\DatastoreController::___tests()

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	DatastoreController::articleByAuthor()	0	2	1
A	DatastoreController::childPage()	0	2	1

<?php

namespace Phpsa\Datastore\Http\Controllers;

use App\Http\Controllers\Controller;

The type App\Http\Controllers\Controller was not found. Maybe you did not declare it correctly or list all dependencies?

use Phpsa\Datastore\Datastore;
use Phpsa\Datastore\Asset;
use Phpsa\Datastore\Helpers;
use Phpsa\Datastore\DatastoreException;
use Phpsa\Datastore\Repositories\DatastoreRepository;

use Phpsa\Datastore\Models\Datastore as DatastoreModel;
use Phpsa\Datastore\Models\DatastorePages;

Class DatastoreController extends Controller {

	/**
	 * @var DatastoreRepository
	 */
    protected $datastoreRepository;

    /**
     * UserController constructor.
     *
     * @param DatastoreRepository $datastoreRepository
	 * @todo get rid of these datastoreRepository and make use of the mode only
     */
    public function __construct(DatastoreRepository $datastoreRepository)
    {
        $this->datastoreRepository = $datastoreRepository;
	}

	/**
	 * Checks if the current user can manage else set status column
	 * this allows us to filter out unpublished items to public but allow admins to
	 * view unpublished items
	 *
	 * @param string $permission
	 *
	 * @return string|null
	 */
	protected function canViewAll($status = 'published') :string
	{
		$user = auth()->user();
		return $user && $user->can('manage datastore') ? null : $status;

The expression return $user && $user->can('manage datastore') ? null : $status could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

	}

	/**
	 * gets page based on the slug
	 *
	 * @param string $slug
	 *
	 * @return DatastorePages
	 */
	protected function getPageBySlug($slug){
		$page = DatastorePages::where('slug', $slug)->first();
		if(!$page){
			abort(404);
		}

		$datastore = $page->datastore;
		$user = auth()->user();

		if(!$datastore->statusIsActive() && (!$user || !$user->can('manage datastore'))) {

The method statusIsActive() does not exist on null.

			abort(404);
		}
		return $page;
	}

	/**
	 * Gets the page view based off of the slug passed in
	 *
	 * @param string $slug
	 *
	 * @return \Illuminate\View\View|\Illuminate\Contracts\View\Factory
	 */
	public function page($slug){

		$page = $this->getPageBySlug($slug);

		$acceptedAssets = $page->datastore->accept ? $this->datastoreRepository->paginateAccepted($page->asset, $this->canViewAll(Helpers::getStatusEquals($page->datastore->accept))) : false;

The property accept does not exist on Phpsa\Datastore\Datastore. Since you implemented __get, consider adding a @property annotation.

		return view($page->datastore->getViewName())

The method getViewName() does not exist on null.

		->withDatastore($page->datastore)
		->withChildren($page->datastore->children())
		->withAccepted($acceptedAssets)
		->withPage($page);

	}

	public function childPage($parent_slug, $slug){
		return $this->page($slug);
	}

	public function articleByAuthor($author_id, $slug){
		$this->datastoreRepository->paginateSearchProp('author', $author_id, Phpsa\Datastore\Ams\Article\ItemAsset::class, $this->canViewAll('published'));

The type Phpsa\Datastore\Http\Controllers\Phpsa\Datastore\Ams\Article\ItemAsset was not found. Did you mean Phpsa\Datastore\Ams\Article\ItemAsset? If so, make sure to prefix the type with \.

	}

}