Phproberto\Joomla\Traits\HasInstances

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	clearInstance()	0	6	1
A	getFreshInstance()	0	6	1
A	getInstance()	0	11	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 18 and the first side effect is on line 11.

/**
 * Joomla! common library.
 *
 * @copyright  Copyright (C) 2017 Roberto Segura López, Inc. All rights reserved.
 * @license    GNU/GPL 2, http://www.gnu.org/licenses/gpl-2.0.htm
 */

namespace Phproberto\Joomla\Traits;

defined('JPATH_PLATFORM') || die;

/**
 * Classes using multiple singleton instances.
 *
 * @since  0.0.1
 */
trait HasInstances
{
	/**
	 * Cached instances
	 *
	 * @var  array
	 */
	protected static $instances = array();

	/**
	 * Remove an instance from cache.
	 *
	 * @param   integer  $id  Class identifier
	 *
	 * @return  void
	 */
	public static function clearInstance($id)
	{
		$class = get_called_class();

		unset(static::$instances[$class][$id]);
	}

	/**
	 * Ensure that we retrieve a non-statically-cached instance.
	 *
	 * @param   integer  $id   Identifier of the instance
	 *
	 * @return  $this
	 */
	public static function getFreshInstance($id)
	{
		static::clearInstance($id);

		return static::getInstance($id);
	}

	/**
	 * Create and return a cached instance
	 *
	 * @param   integer  $id  Identifier of the instance
	 *
	 * @return  $this
	 */
	public static function getInstance($id)
	{
		$class = get_called_class();

		if (empty(static::$instances[$class][$id]))
		{
			static::$instances[$class][$id] = new static($id);

The call to HasInstances::__construct() has too many arguments starting with $id.

		}

		return static::$instances[$class][$id];
	}
}