Phproberto\Joomla\Traits\HasLayouts

Complexity

Total Complexity

4

Size/Duplication

Total Lines	54
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	debug()	9	9	2
	getLayoutData()	0	1	?
	getLayoutPaths()	0	1	?
A	render()	9	9	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 18 and the first side effect is on line 11.

/**
 * Joomla! common library.
 *
 * @copyright  Copyright (C) 2017 Roberto Segura López, Inc. All rights reserved.
 * @license    GNU/GPL 2, http://www.gnu.org/licenses/gpl-2.0.htm
 */

namespace Phproberto\Joomla\Traits;

defined('JPATH_PLATFORM') || die;

/**
 * Modules that use JLayoutFile as renderer.
 *
 * @since  0.0.1
 */
trait HasLayouts
{
	/**
	 * Debug a layout rendering.
	 *
	 * @param   string  $layoutId  Layout identifier
	 * @param   array   $data      Optional data for the layout
	 *
	 * @return  string
	 */
	public function debug($layoutId = null, $data = array())

This method seems to be duplicated in your project.

	{
		$layoutId = $layoutId ?: 'default';

		$renderer = new \JLayoutFile($layoutId);
		$renderer->setIncludePaths($this->getLayoutPaths());

		return $renderer->debug(array_merge($this->getLayoutData(), $data));
	}

	/**
	 * Get the data that will be sent to the layout.
	 *
	 * @param   boolean   $reload  Force reloading data
	 *
	 * @return  array
	 */
	abstract protected function getLayoutData($reload = false);

	/**
	 * Get the paths where we will search for layouts.
	 *
	 * @return  string[]
	 */
	abstract protected function getLayoutPaths();

	/**
	 * Render a layout.
	 *
	 * @param   string  $layoutId  Layout identifier
	 * @param   array   $data      Optional data for the layout
	 *
	 * @return  string
	 */
	public function render($layoutId = null, $data = array())

This method seems to be duplicated in your project.

	{
		$layoutId = $layoutId ?: 'default';

		$renderer = new \JLayoutFile($layoutId);
		$renderer->setIncludePaths($this->getLayoutPaths());

		return $renderer->render(array_merge($this->getLayoutData(), $data));
	}
}