phpmyadmin / sql-parser

src/Components/WithKeyword.php

<?php

declare(strict_types=1);

namespace PhpMyAdmin\SqlParser\Components;

use PhpMyAdmin\SqlParser\Component;
use PhpMyAdmin\SqlParser\Parser;
use PhpMyAdmin\SqlParser\Parsers\ArrayObjs;
use RuntimeException;

/**
 * `WITH` keyword builder.
 */
final class WithKeyword implements Component
{
    /** @var ArrayObj[] */
    public array $columns = [];

    public Parser|null $statement = null;

    public function __construct(public string $name)
    {
    }

    public function build(): string
    {
        if (! isset($this->statement)) {
            throw new RuntimeException('No statement inside WITH');
        }

        $str = $this->name;

        if ($this->columns) {

The expression $this->columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $str .= ArrayObjs::buildAll($this->columns);
        }

        $str .= ' AS (';

        foreach ($this->statement->statements as $statement) {
            $str .= $statement->build();
        }

        $str .= ')';

        return $str;
    }

    public function __toString(): string
    {
        return $this->build();
    }
}