Conditions | 1 |
Paths | 1 |
Total Lines | 165 |
Code Lines | 90 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
10 | public function testBuilderView() |
||
11 | { |
||
12 | /* Assertion 1 */ |
||
13 | $query = 'SET CHARACTER SET \'utf8\''; |
||
14 | |||
15 | $parser = new Parser($query); |
||
16 | $stmt = $parser->statements[0]; |
||
17 | |||
18 | $this->assertEquals( |
||
19 | $query, |
||
20 | $stmt->build() |
||
21 | ); |
||
22 | |||
23 | /* Assertion 2 */ |
||
24 | $query = 'SET CHARSET \'utf8\''; |
||
25 | |||
26 | $parser = new Parser($query); |
||
27 | $stmt = $parser->statements[0]; |
||
28 | |||
29 | $this->assertEquals( |
||
30 | $query, |
||
31 | $stmt->build() |
||
32 | ); |
||
33 | |||
34 | /* Assertion 3 */ |
||
35 | $query = 'SET NAMES \'utf8\''; |
||
36 | |||
37 | $parser = new Parser($query); |
||
38 | $stmt = $parser->statements[0]; |
||
39 | |||
40 | $this->assertEquals( |
||
41 | $query, |
||
42 | $stmt->build() |
||
43 | ); |
||
44 | |||
45 | /* Assertion 4 */ |
||
46 | $query = 'SET NAMES \'utf8\' COLLATE \'utf8_general_ci\''; |
||
47 | |||
48 | $parser = new Parser($query); |
||
49 | $stmt = $parser->statements[0]; |
||
50 | |||
51 | $this->assertEquals( |
||
52 | 'SET NAMES \'utf8\' COLLATE \'utf8_general_ci\'', |
||
53 | $stmt->build() |
||
54 | ); |
||
55 | |||
56 | /* Assertion 5 */ |
||
57 | $query = 'SET NAMES \'utf8\' DEFAULT'; |
||
58 | |||
59 | $parser = new Parser($query); |
||
60 | $stmt = $parser->statements[0]; |
||
61 | |||
62 | $this->assertEquals( |
||
63 | 'SET NAMES \'utf8\' DEFAULT', |
||
64 | $stmt->build() |
||
65 | ); |
||
66 | |||
67 | /* Assertion 6 */ |
||
68 | $query = 'SET sql_mode = \'TRADITIONAL\''; |
||
69 | |||
70 | $parser = new Parser($query); |
||
71 | $stmt = $parser->statements[0]; |
||
72 | |||
73 | $this->assertEquals( |
||
74 | 'SET sql_mode = \'TRADITIONAL\'', |
||
75 | $stmt->build() |
||
76 | ); |
||
77 | |||
78 | /* Assertion 7 */ |
||
79 | $query = 'SET SESSION sql_mode = \'TRADITIONAL\''; |
||
80 | |||
81 | $parser = new Parser($query); |
||
82 | $stmt = $parser->statements[0]; |
||
83 | |||
84 | $this->assertEquals( |
||
85 | 'SET SESSION sql_mode = \'TRADITIONAL\'', |
||
86 | $stmt->build() |
||
87 | ); |
||
88 | |||
89 | /* Assertion 8 */ |
||
90 | $query = 'SET GLOBAL sql_mode = \'TRADITIONAL\''; |
||
91 | |||
92 | $parser = new Parser($query); |
||
93 | $stmt = $parser->statements[0]; |
||
94 | |||
95 | $this->assertEquals( |
||
96 | 'SET GLOBAL sql_mode = \'TRADITIONAL\'', |
||
97 | $stmt->build() |
||
98 | ); |
||
99 | |||
100 | /* Assertion 9 */ |
||
101 | $query = 'SET @@SESSION sql_mode = \'TRADITIONAL\''; |
||
102 | |||
103 | $parser = new Parser($query); |
||
104 | $stmt = $parser->statements[0]; |
||
105 | |||
106 | $this->assertEquals( |
||
107 | 'SET SESSION sql_mode = \'TRADITIONAL\'', |
||
108 | $stmt->build() |
||
109 | ); |
||
110 | |||
111 | /* Assertion 10 */ |
||
112 | $query = 'SET @@GLOBAL sql_mode = \'TRADITIONAL\''; |
||
113 | |||
114 | $parser = new Parser($query); |
||
115 | $stmt = $parser->statements[0]; |
||
116 | |||
117 | $this->assertEquals( |
||
118 | 'SET GLOBAL sql_mode = \'TRADITIONAL\'', |
||
119 | $stmt->build() |
||
120 | ); |
||
121 | |||
122 | /* Assertion 11 */ |
||
123 | $query = 'SET @@sql_mode = \'TRADITIONAL\''; |
||
124 | |||
125 | $parser = new Parser($query); |
||
126 | $stmt = $parser->statements[0]; |
||
127 | |||
128 | $this->assertEquals( |
||
129 | 'SET @@sql_mode = \'TRADITIONAL\'', |
||
130 | $stmt->build() |
||
131 | ); |
||
132 | |||
133 | /* Assertion 12 */ |
||
134 | $query = 'SET PERSIST sql_mode = \'TRADITIONAL\''; |
||
135 | |||
136 | $parser = new Parser($query); |
||
137 | $stmt = $parser->statements[0]; |
||
138 | |||
139 | $this->assertEquals( |
||
140 | 'SET PERSIST sql_mode = \'TRADITIONAL\'', |
||
141 | $stmt->build() |
||
142 | ); |
||
143 | |||
144 | /* Assertion 13 */ |
||
145 | $query = 'SET PERSIST_ONLY sql_mode = \'TRADITIONAL\''; |
||
146 | |||
147 | $parser = new Parser($query); |
||
148 | $stmt = $parser->statements[0]; |
||
149 | |||
150 | $this->assertEquals( |
||
151 | 'SET PERSIST_ONLY sql_mode = \'TRADITIONAL\'', |
||
152 | $stmt->build() |
||
153 | ); |
||
154 | |||
155 | /* Assertion 14 */ |
||
156 | $query = 'SET @@PERSIST sql_mode = \'TRADITIONAL\''; |
||
157 | |||
158 | $parser = new Parser($query); |
||
159 | $stmt = $parser->statements[0]; |
||
160 | |||
161 | $this->assertEquals( |
||
162 | 'SET PERSIST sql_mode = \'TRADITIONAL\'', |
||
163 | $stmt->build() |
||
164 | ); |
||
165 | |||
166 | /* Assertion 15 */ |
||
167 | $query = 'SET @@PERSIST_ONLY sql_mode = \'TRADITIONAL\''; |
||
168 | |||
169 | $parser = new Parser($query); |
||
170 | $stmt = $parser->statements[0]; |
||
171 | |||
172 | $this->assertEquals( |
||
173 | 'SET PERSIST_ONLY sql_mode = \'TRADITIONAL\'', |
||
174 | $stmt->build() |
||
175 | ); |
||
178 |