WithKeyword::build() - Code Metrics - Inspection of "Add a CHANGELOG entry for #165, #331" - phpmyadmin/sql-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8d8336...ff76ee )

by William

created 2021-05-16 13:12 UTC

WithKeyword::build() A

↳ Parent: WithKeyword

Complexity

Conditions	5
Paths	6

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	12
c	1
b	0
f	0
nc	6
nop	2
dl	0
loc	25
ccs	13
cts	13
cp	1
crap	5
rs	9.5555

<?php
/**
 * `WITH` keyword builder.
 */

declare(strict_types=1);

namespace PhpMyAdmin\SqlParser\Components;

use PhpMyAdmin\SqlParser\Component;
use PhpMyAdmin\SqlParser\Parser;
use RuntimeException;

/**
 * `WITH` keyword builder.
 */
final class WithKeyword extends Component
{
    /** @var string */
    public $name;

    /** @var ArrayObj[] */
    public $columns = [];

    /** @var Parser */
    public $statement;

    public function __construct(string $name)
    {
        $this->name = $name;
    }

    /**
     * @param WithKeyword $component
     * @param mixed[]     $options
     *
     * @return string
     */
    public static function build($component, array $options = [])
    {
        if (! $component instanceof WithKeyword) {

            throw new RuntimeException('Can not build a component that is not a WithKeyword');
        }

        if (! isset($component->statement)) {
            throw new RuntimeException('No statement inside WITH');
        }

        $str = $component->name;

        if ($component->columns) {

            $str .= ArrayObj::build($component->columns);
        }

        $str .= ' AS (';

        foreach ($component->statement->statements as $statement) {
            $str .= $statement->build();
        }

        $str .= ')';

        return $str;
    }
}


1		<?php
2		/**
3		* `WITH` keyword builder.
4		*/
5
6		declare(strict_types=1);
7
8		namespace PhpMyAdmin\SqlParser\Components;
9
10		use PhpMyAdmin\SqlParser\Component;
11		use PhpMyAdmin\SqlParser\Parser;
12		use RuntimeException;
13
14		/**
15		* `WITH` keyword builder.
16		*/
17		final class WithKeyword extends Component
18		{
19		/** @var string */
20		public $name;
21
22		/** @var ArrayObj[] */
23		public $columns = [];
24
25		/** @var Parser */
26		public $statement;
27
28	20	public function __construct(string $name)
29		{
30	20	$this->name = $name;
31	20	}
32
33		/**
34		* @param WithKeyword $component
35		* @param mixed[] $options
36		*
37		* @return string
38		*/
39	16	public static function build($component, array $options = [])
40		{
41	16	if (! $component instanceof WithKeyword) {
		0 ignored issues – show introduced 2021-03-11 11:16 UTC by Report Bug Copy Issue Report `$component` is always a sub-type of `PhpMyAdmin\SqlParser\Components\WithKeyword`. Loading history...
42	4	throw new RuntimeException('Can not build a component that is not a WithKeyword');
43		}
44
45	12	if (! isset($component->statement)) {
46	4	throw new RuntimeException('No statement inside WITH');
47		}
48
49	8	$str = $component->name;
50
51	8	if ($component->columns) {
		0 ignored issues – show Bug Best Practice introduced 2021-03-11 11:26 UTC by Report Bug Copy Issue Report The expression `$component->columns` of type `PhpMyAdmin\SqlParser\Components\ArrayObj[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
52	4	$str .= ArrayObj::build($component->columns);
53		}
54
55	8	$str .= ' AS (';
56
57	8	foreach ($component->statement->statements as $statement) {
58	8	$str .= $statement->build();
59		}
60
61	8	$str .= ')';
62
63	8	return $str;
64		}
65		}
66

phpmyadmin / sql-parser

Push — master ( 8d8336...ff76ee )

WithKeyword::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like