ArrayObj::parse() - Code Metrics - Inspection of "Merge pull request #543 from kamil-tekiela/Refacto..." - phpmyadmin/sql-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b16987...8b6d77 )

by Maurício

created 2024-01-23 18:09 UTC

ArrayObj::parse() D

↳ Parent: Project

Complexity

Conditions	23
Paths	20

Size

Total Lines	102
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	47
CRAP Score	23

Importance

Changes

Metric	Value
cc	23
eloc	46
c	0
b	0
f	0
nc	20
nop	3
dl	0
loc	102
ccs	47
cts	47
cp	1
crap	23
rs	4.1666

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace PhpMyAdmin\SqlParser\Components;

use PhpMyAdmin\SqlParser\Component;

use function implode;

/**
 * Parses an array.
 */
final class ArrayObj implements Component
{
    /**
     * The array that contains the unprocessed value of each token.
     *
     * @var string[]
     */
    public array $raw = [];

    /**
     * The array that contains the processed value of each token.
     *
     * @var string[]
     */
    public array $values = [];

    /**
     * @param string[] $raw    the unprocessed values
     * @param string[] $values the processed values
     */
    public function __construct(array $raw = [], array $values = [])
    {
        $this->raw = $raw;
        $this->values = $values;
    }

    public function build(): string
    {
        if ($this->raw !== []) {
            return '(' . implode(', ', $this->raw) . ')';
        }

        return '(' . implode(', ', $this->values) . ')';
    }

    public function __toString(): string
    {
        return $this->build();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpMyAdmin\SqlParser\Components;
6
7		use PhpMyAdmin\SqlParser\Component;
8
9		use function implode;
10
11		/**
12		* Parses an array.
13		*/
14		final class ArrayObj implements Component
15		{
16		/**
17		* The array that contains the unprocessed value of each token.
18		*
19		* @var string[]
20		*/
21		public array $raw = [];
22
23		/**
24		* The array that contains the processed value of each token.
25		*
26		* @var string[]
27		*/
28		public array $values = [];
29
30		/**
31		* @param string[] $raw the unprocessed values
32		* @param string[] $values the processed values
33		*/
34	264	public function __construct(array $raw = [], array $values = [])
35		{
36	264	$this->raw = $raw;
37	264	$this->values = $values;
38		}
39
40	22	public function build(): string
41		{
42	22	if ($this->raw !== []) {
43	20	return '(' . implode(', ', $this->raw) . ')';
44		}
45
46	2	return '(' . implode(', ', $this->values) . ')';
47		}
48
49	18	public function __toString(): string
50		{
51	18	return $this->build();
52		}
53		}
54

phpmyadmin / sql-parser

Push — master ( b16987...8b6d77 )

ArrayObj::parse() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like