Conditions | 1 |
Paths | 1 |
Total Lines | 165 |
Code Lines | 90 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
12 | public function testBuilderView() |
||
13 | { |
||
14 | /* Assertion 1 */ |
||
15 | $query = 'SET CHARACTER SET \'utf8\''; |
||
16 | |||
17 | $parser = new Parser($query); |
||
18 | $stmt = $parser->statements[0]; |
||
19 | |||
20 | $this->assertEquals( |
||
21 | $query, |
||
22 | $stmt->build() |
||
23 | ); |
||
24 | |||
25 | /* Assertion 2 */ |
||
26 | $query = 'SET CHARSET \'utf8\''; |
||
27 | |||
28 | $parser = new Parser($query); |
||
29 | $stmt = $parser->statements[0]; |
||
30 | |||
31 | $this->assertEquals( |
||
32 | $query, |
||
33 | $stmt->build() |
||
34 | ); |
||
35 | |||
36 | /* Assertion 3 */ |
||
37 | $query = 'SET NAMES \'utf8\''; |
||
38 | |||
39 | $parser = new Parser($query); |
||
40 | $stmt = $parser->statements[0]; |
||
41 | |||
42 | $this->assertEquals( |
||
43 | $query, |
||
44 | $stmt->build() |
||
45 | ); |
||
46 | |||
47 | /* Assertion 4 */ |
||
48 | $query = 'SET NAMES \'utf8\' COLLATE \'utf8_general_ci\''; |
||
49 | |||
50 | $parser = new Parser($query); |
||
51 | $stmt = $parser->statements[0]; |
||
52 | |||
53 | $this->assertEquals( |
||
54 | 'SET NAMES \'utf8\' COLLATE \'utf8_general_ci\'', |
||
55 | $stmt->build() |
||
56 | ); |
||
57 | |||
58 | /* Assertion 5 */ |
||
59 | $query = 'SET NAMES \'utf8\' DEFAULT'; |
||
60 | |||
61 | $parser = new Parser($query); |
||
62 | $stmt = $parser->statements[0]; |
||
63 | |||
64 | $this->assertEquals( |
||
65 | 'SET NAMES \'utf8\' DEFAULT', |
||
66 | $stmt->build() |
||
67 | ); |
||
68 | |||
69 | /* Assertion 6 */ |
||
70 | $query = 'SET sql_mode = \'TRADITIONAL\''; |
||
71 | |||
72 | $parser = new Parser($query); |
||
73 | $stmt = $parser->statements[0]; |
||
74 | |||
75 | $this->assertEquals( |
||
76 | 'SET sql_mode = \'TRADITIONAL\'', |
||
77 | $stmt->build() |
||
78 | ); |
||
79 | |||
80 | /* Assertion 7 */ |
||
81 | $query = 'SET SESSION sql_mode = \'TRADITIONAL\''; |
||
82 | |||
83 | $parser = new Parser($query); |
||
84 | $stmt = $parser->statements[0]; |
||
85 | |||
86 | $this->assertEquals( |
||
87 | 'SET SESSION sql_mode = \'TRADITIONAL\'', |
||
88 | $stmt->build() |
||
89 | ); |
||
90 | |||
91 | /* Assertion 8 */ |
||
92 | $query = 'SET GLOBAL sql_mode = \'TRADITIONAL\''; |
||
93 | |||
94 | $parser = new Parser($query); |
||
95 | $stmt = $parser->statements[0]; |
||
96 | |||
97 | $this->assertEquals( |
||
98 | 'SET GLOBAL sql_mode = \'TRADITIONAL\'', |
||
99 | $stmt->build() |
||
100 | ); |
||
101 | |||
102 | /* Assertion 9 */ |
||
103 | $query = 'SET @@SESSION sql_mode = \'TRADITIONAL\''; |
||
104 | |||
105 | $parser = new Parser($query); |
||
106 | $stmt = $parser->statements[0]; |
||
107 | |||
108 | $this->assertEquals( |
||
109 | 'SET SESSION sql_mode = \'TRADITIONAL\'', |
||
110 | $stmt->build() |
||
111 | ); |
||
112 | |||
113 | /* Assertion 10 */ |
||
114 | $query = 'SET @@GLOBAL sql_mode = \'TRADITIONAL\''; |
||
115 | |||
116 | $parser = new Parser($query); |
||
117 | $stmt = $parser->statements[0]; |
||
118 | |||
119 | $this->assertEquals( |
||
120 | 'SET GLOBAL sql_mode = \'TRADITIONAL\'', |
||
121 | $stmt->build() |
||
122 | ); |
||
123 | |||
124 | /* Assertion 11 */ |
||
125 | $query = 'SET @@sql_mode = \'TRADITIONAL\''; |
||
126 | |||
127 | $parser = new Parser($query); |
||
128 | $stmt = $parser->statements[0]; |
||
129 | |||
130 | $this->assertEquals( |
||
131 | 'SET @@sql_mode = \'TRADITIONAL\'', |
||
132 | $stmt->build() |
||
133 | ); |
||
134 | |||
135 | /* Assertion 12 */ |
||
136 | $query = 'SET PERSIST sql_mode = \'TRADITIONAL\''; |
||
137 | |||
138 | $parser = new Parser($query); |
||
139 | $stmt = $parser->statements[0]; |
||
140 | |||
141 | $this->assertEquals( |
||
142 | 'SET PERSIST sql_mode = \'TRADITIONAL\'', |
||
143 | $stmt->build() |
||
144 | ); |
||
145 | |||
146 | /* Assertion 13 */ |
||
147 | $query = 'SET PERSIST_ONLY sql_mode = \'TRADITIONAL\''; |
||
148 | |||
149 | $parser = new Parser($query); |
||
150 | $stmt = $parser->statements[0]; |
||
151 | |||
152 | $this->assertEquals( |
||
153 | 'SET PERSIST_ONLY sql_mode = \'TRADITIONAL\'', |
||
154 | $stmt->build() |
||
155 | ); |
||
156 | |||
157 | /* Assertion 14 */ |
||
158 | $query = 'SET @@PERSIST sql_mode = \'TRADITIONAL\''; |
||
159 | |||
160 | $parser = new Parser($query); |
||
161 | $stmt = $parser->statements[0]; |
||
162 | |||
163 | $this->assertEquals( |
||
164 | 'SET PERSIST sql_mode = \'TRADITIONAL\'', |
||
165 | $stmt->build() |
||
166 | ); |
||
167 | |||
168 | /* Assertion 15 */ |
||
169 | $query = 'SET @@PERSIST_ONLY sql_mode = \'TRADITIONAL\''; |
||
170 | |||
171 | $parser = new Parser($query); |
||
172 | $stmt = $parser->statements[0]; |
||
173 | |||
174 | $this->assertEquals( |
||
175 | 'SET PERSIST_ONLY sql_mode = \'TRADITIONAL\'', |
||
176 | $stmt->build() |
||
177 | ); |
||
180 |