WithKeyword::build() - Code Metrics - Inspection of "Refactor build method" - phpmyadmin/sql-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#483)

unknown

created 2023-06-11 21:49 UTC

WithKeyword::build() A

↳ Parent: WithKeyword

Complexity

Conditions	4
Paths	5

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	10
nc	5
nop	1
dl	0
loc	21
ccs	11
cts	11
cp	1
crap	4
rs	9.9332
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace PhpMyAdmin\SqlParser\Components;

use PhpMyAdmin\SqlParser\Component;
use PhpMyAdmin\SqlParser\Parser;
use PhpMyAdmin\SqlParser\TokensList;
use PhpMyAdmin\SqlParser\Translator;
use RuntimeException;

/**
 * `WITH` keyword builder.
 */
final class WithKeyword implements Component
{
    /** @var string */
    public $name;

    /** @var ArrayObj[] */
    public $columns = [];

    /** @var Parser|null */
    public $statement;

    public function __construct(string $name)
    {
        $this->name = $name;
    }

    /**
     * Parses the tokens contained in the given list in the context of the given parser.
     *
     * @param Parser               $parser  the parser that serves as context
     * @param TokensList           $list    the list of tokens that are being parsed
     * @param array<string, mixed> $options parameters for parsing
     *
     * @return mixed
     *
     * @throws RuntimeException not implemented yet.
     */
    public static function parse(Parser $parser, TokensList $list, array $options = [])
    {
        throw new RuntimeException(Translator::gettext('Not implemented yet.'));
    }

    /**
     * @param WithKeyword $component
     */
    public static function build($component): string
    {
        if (! isset($component->statement)) {
            throw new RuntimeException('No statement inside WITH');
        }

        $str = $component->name;

        if ($component->columns) {

            $str .= ArrayObj::buildAll($component->columns);
        }

        $str .= ' AS (';

        foreach ($component->statement->statements as $statement) {
            $str .= $statement->build();
        }

        $str .= ')';

        return $str;
    }

    public function __toString(): string
    {
        return static::build($this);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpMyAdmin\SqlParser\Components;
6
7		use PhpMyAdmin\SqlParser\Component;
8		use PhpMyAdmin\SqlParser\Parser;
9		use PhpMyAdmin\SqlParser\TokensList;
10		use PhpMyAdmin\SqlParser\Translator;
11		use RuntimeException;
12
13		/**
14		* `WITH` keyword builder.
15		*/
16		final class WithKeyword implements Component
17		{
18		/** @var string */
19		public $name;
20
21		/** @var ArrayObj[] */
22		public $columns = [];
23
24		/** @var Parser\|null */
25		public $statement;
26
27	48	public function __construct(string $name)
28		{
29	48	$this->name = $name;
30		}
31
32		/**
33		* Parses the tokens contained in the given list in the context of the given parser.
34		*
35		* @param Parser $parser the parser that serves as context
36		* @param TokensList $list the list of tokens that are being parsed
37		* @param array<string, mixed> $options parameters for parsing
38		*
39		* @return mixed
40		*
41		* @throws RuntimeException not implemented yet.
42		*/
43		public static function parse(Parser $parser, TokensList $list, array $options = [])
44		{
45		throw new RuntimeException(Translator::gettext('Not implemented yet.'));
46		}
47
48		/**
49		* @param WithKeyword $component
50		*/
51	12	public static function build($component): string
52		{
53	12	if (! isset($component->statement)) {
54	2	throw new RuntimeException('No statement inside WITH');
55		}
56
57	10	$str = $component->name;
58
59	10	if ($component->columns) {
		0 ignored issues – show Bug Best Practice introduced 2021-03-11 11:26 UTC by Report Bug Copy Issue Report The expression `$component->columns` of type `PhpMyAdmin\SqlParser\Components\ArrayObj[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
60	6	$str .= ArrayObj::buildAll($component->columns);
61		}
62
63	10	$str .= ' AS (';
64
65	10	foreach ($component->statement->statements as $statement) {
66	10	$str .= $statement->build();
67		}
68
69	10	$str .= ')';
70
71	10	return $str;
72		}
73
74		public function __toString(): string
75		{
76		return static::build($this);
77		}
78		}
79

phpmyadmin / sql-parser

Pull Request — master (#483)

WithKeyword::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like