Conditions | 50 |
Paths | 13833 |
Total Lines | 227 |
Code Lines | 85 |
Lines | 8 |
Ratio | 3.52 % |
Tests | 100 |
CRAP Score | 51.0171 |
Changes | 6 | ||
Bugs | 3 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
186 | 7 | public function formatList($list) |
|
187 | { |
||
188 | |||
189 | /** |
||
190 | * The query to be returned. |
||
191 | * |
||
192 | * @var string $ret |
||
193 | */ |
||
194 | 7 | $ret = ''; |
|
195 | |||
196 | /** |
||
197 | * The indentation level. |
||
198 | * |
||
199 | * @var int $indent |
||
200 | */ |
||
201 | 7 | $indent = 0; |
|
202 | |||
203 | /** |
||
204 | * Whether the line ended. |
||
205 | * |
||
206 | * @var bool $lineEnded |
||
207 | */ |
||
208 | 7 | $lineEnded = false; |
|
209 | |||
210 | /** |
||
211 | * The name of the last clause. |
||
212 | * |
||
213 | * @var string $lastClause |
||
214 | */ |
||
215 | 7 | $lastClause = ''; |
|
216 | |||
217 | /** |
||
218 | * A stack that keeps track of the indentation level every time a new |
||
219 | * block is found. |
||
220 | * |
||
221 | * @var array $blocksIndentation |
||
222 | */ |
||
223 | 7 | $blocksIndentation = array(); |
|
224 | |||
225 | /** |
||
226 | * A stack that keeps track of the line endings every time a new block |
||
227 | * is found. |
||
228 | * |
||
229 | * @var array $blocksLineEndings |
||
230 | */ |
||
231 | 7 | $blocksLineEndings = array(); |
|
232 | |||
233 | /** |
||
234 | * Whether clause's options were formatted. |
||
235 | * |
||
236 | * @var bool $formattedOptions |
||
237 | */ |
||
238 | 7 | $formattedOptions = false; |
|
239 | |||
240 | /** |
||
241 | * Previously parsed token. |
||
242 | * |
||
243 | * @var Token $prev |
||
244 | */ |
||
245 | 7 | $prev = null; |
|
246 | |||
247 | /** |
||
248 | * Comments are being formatted separately to maintain the whitespaces |
||
249 | * before and after them. |
||
250 | * |
||
251 | * @var string $comment |
||
252 | */ |
||
253 | 7 | $comment = ''; |
|
254 | |||
255 | // In order to be able to format the queries correctly, the next token |
||
256 | // must be taken into consideration. The loop below uses two pointers, |
||
257 | // `$prev` and `$curr` which store two consecutive tokens. |
||
258 | // Actually, at every iteration the previous token is being used. |
||
259 | 7 | for ($list->idx = 0; $list->idx < $list->count; ++$list->idx) { |
|
260 | /** |
||
261 | * Token parsed at this moment. |
||
262 | * |
||
263 | * @var Token $curr |
||
264 | */ |
||
265 | 7 | $curr = $list->tokens[$list->idx]; |
|
266 | |||
267 | 7 | if ($curr->type === Token::TYPE_WHITESPACE) { |
|
268 | // Whitespaces are skipped because the formatter adds its own. |
||
269 | 7 | continue; |
|
270 | 7 | } elseif ($curr->type === Token::TYPE_COMMENT) { |
|
271 | // Whether the comments should be parsed. |
||
272 | 1 | if (!empty($this->options['remove_comments'])) { |
|
273 | continue; |
||
274 | } |
||
275 | |||
276 | 1 | if ($list->tokens[$list->idx - 1]->type === Token::TYPE_WHITESPACE) { |
|
277 | // The whitespaces before and after are preserved for |
||
278 | // formatting reasons. |
||
279 | 1 | $comment .= $list->tokens[$list->idx - 1]->token; |
|
280 | 1 | } |
|
281 | 1 | $comment .= $this->toString($curr); |
|
282 | 1 | if (($list->tokens[$list->idx + 1]->type === Token::TYPE_WHITESPACE) |
|
283 | 1 | && ($list->tokens[$list->idx + 2]->type !== Token::TYPE_COMMENT) |
|
284 | 1 | ) { |
|
285 | // Adding the next whitespace only there is no comment that |
||
286 | // follows it immediately which may cause adding a |
||
287 | // whitespace twice. |
||
288 | $comment .= $list->tokens[$list->idx + 1]->token; |
||
289 | } |
||
290 | |||
291 | // Everything was handled here, no need to continue. |
||
292 | 1 | continue; |
|
293 | } |
||
294 | |||
295 | // Checking if pointers were initialized. |
||
296 | 7 | if ($prev !== null) { |
|
297 | // Checking if a new clause started. |
||
298 | 7 | if (static::isClause($prev) !== false) { |
|
299 | 7 | $lastClause = $prev->value; |
|
300 | 7 | $formattedOptions = false; |
|
301 | 7 | } |
|
302 | |||
303 | // The options of a clause should stay on the same line and everything that follows. |
||
304 | 7 | if (($this->options['parts_newline']) |
|
305 | 7 | && (!$formattedOptions) |
|
306 | 7 | && (empty(self::$INLINE_CLAUSES[$lastClause])) |
|
307 | 7 | && (($curr->type !== Token::TYPE_KEYWORD) |
|
308 | 3 | || (($curr->type === Token::TYPE_KEYWORD) |
|
309 | 3 | && ($curr->flags & Token::FLAG_KEYWORD_FUNCTION))) |
|
310 | 7 | ) { |
|
311 | 7 | $formattedOptions = true; |
|
312 | 7 | $lineEnded = true; |
|
313 | 7 | ++$indent; |
|
314 | 7 | } |
|
315 | |||
316 | // Checking if this clause ended. |
||
317 | 7 | if ($tmp = static::isClause($curr)) { |
|
318 | 3 | if (($tmp == 2) || ($this->options['clause_newline'])) { |
|
319 | 3 | $lineEnded = true; |
|
320 | 3 | if ($this->options['parts_newline']) { |
|
321 | 3 | --$indent; |
|
322 | 3 | } |
|
323 | 3 | } |
|
324 | 3 | } |
|
325 | |||
326 | // Indenting BEGIN ... END blocks. |
||
327 | 7 | if (($prev->type === Token::TYPE_KEYWORD) && ($prev->value === 'BEGIN')) { |
|
328 | 1 | $lineEnded = true; |
|
329 | 1 | array_push($blocksIndentation, $indent); |
|
330 | 1 | ++$indent; |
|
331 | 7 | View Code Duplication | } elseif (($curr->type === Token::TYPE_KEYWORD) && ($curr->value === 'END')) { |
1 ignored issue
–
show
|
|||
332 | 1 | $lineEnded = true; |
|
333 | 1 | $indent = array_pop($blocksIndentation); |
|
334 | 1 | } |
|
335 | |||
336 | // Formatting fragments delimited by comma. |
||
337 | 7 | if (($prev->type === Token::TYPE_OPERATOR) && ($prev->value === ',')) { |
|
338 | // Fragments delimited by a comma are broken into multiple |
||
339 | // pieces only if the clause is not inlined or this fragment |
||
340 | // is between brackets that are on new line. |
||
341 | 1 | if (((empty(self::$INLINE_CLAUSES[$lastClause])) |
|
342 | 1 | && ($this->options['parts_newline'])) |
|
343 | 1 | || (end($blocksLineEndings) === true) |
|
344 | 1 | ) { |
|
345 | $lineEnded = true; |
||
346 | } |
||
347 | 1 | } |
|
348 | |||
349 | // Handling brackets. |
||
350 | // Brackets are indented only if the length of the fragment between |
||
351 | // them is longer than 30 characters. |
||
352 | 7 | if (($prev->type === Token::TYPE_OPERATOR) && ($prev->value === '(')) { |
|
353 | 3 | array_push($blocksIndentation, $indent); |
|
354 | 3 | if (static::getGroupLength($list) > 30) { |
|
355 | ++$indent; |
||
356 | $lineEnded = true; |
||
357 | } |
||
358 | 3 | array_push($blocksLineEndings, $lineEnded); |
|
359 | 7 | View Code Duplication | } elseif (($curr->type === Token::TYPE_OPERATOR) && ($curr->value === ')')) { |
1 ignored issue
–
show
|
|||
360 | 2 | $indent = array_pop($blocksIndentation); |
|
361 | 2 | $lineEnded |= array_pop($blocksLineEndings); |
|
362 | 2 | } |
|
363 | |||
364 | // Delimiter must be placed on the same line with the last |
||
365 | // clause. |
||
366 | 7 | if ($curr->type === Token::TYPE_DELIMITER) { |
|
367 | 7 | $lineEnded = false; |
|
368 | 7 | } |
|
369 | |||
370 | // Adding the token. |
||
371 | 7 | $ret .= $this->toString($prev); |
|
372 | |||
373 | // Finishing the line. |
||
374 | 7 | if ($lineEnded) { |
|
375 | 7 | if ($indent < 0) { |
|
376 | // TODO: Make sure this never occurs and delete it. |
||
377 | 2 | $indent = 0; |
|
378 | 2 | } |
|
379 | |||
380 | 7 | if ($curr->type !== Token::TYPE_COMMENT) { |
|
381 | 7 | $ret .= $this->options['line_ending'] |
|
382 | 7 | . str_repeat($this->options['indentation'], $indent); |
|
383 | 7 | } |
|
384 | 7 | $lineEnded = false; |
|
385 | 7 | } else { |
|
386 | // If the line ended there is no point in adding whitespaces. |
||
387 | // Also, some tokens do not have spaces before or after them. |
||
388 | 7 | if (!((($prev->type === Token::TYPE_OPERATOR) && (($prev->value === '.') || ($prev->value === '('))) |
|
389 | // No space after . ( |
||
390 | 7 | || (($curr->type === Token::TYPE_OPERATOR) && (($curr->value === '.') || ($curr->value === ',') |
|
391 | 4 | || ($curr->value === '(') || ($curr->value === ')'))) |
|
392 | // No space before . , ( ) |
||
393 | 7 | || (($curr->type === Token::TYPE_DELIMITER)) && (mb_strlen($curr->value, 'UTF-8') < 2)) |
|
394 | // A space after delimiters that are longer than 2 characters. |
||
395 | 7 | || ($prev->value === 'DELIMITER') |
|
396 | 7 | ) { |
|
397 | 3 | $ret .= ' '; |
|
398 | 3 | } |
|
399 | } |
||
400 | 7 | } |
|
401 | |||
402 | 7 | if (!empty($comment)) { |
|
403 | 1 | $ret .= $comment; |
|
404 | 1 | $comment = ''; |
|
405 | 1 | } |
|
406 | |||
407 | // Iteration finished, consider current token as previous. |
||
408 | 7 | $prev = $curr; |
|
409 | 7 | } |
|
410 | |||
411 | 7 | return $ret; |
|
412 | } |
||
413 | |||
534 |
PHP provides two ways to mark string literals. Either with single quotes
'literal'
or with double quotes"literal"
. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (
\'
) and the backslash (\\
). Every other character is displayed as is.Double quoted string literals may contain other variables or more complex escape sequences.
will print an indented:
Single is Value
If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.
For more information on PHP string literals and available escape sequences see the PHP core documentation.