GroupKeyword::parse() - Code Metrics - Inspection of "Merge pull request #535 from kamil-tekiela/Compone..." - phpmyadmin/sql-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 578d3a...04a929 )

by Maurício

created 2024-01-20 19:59 UTC

GroupKeyword::parse() C

↳ Parent: Project

Complexity

Conditions	14
Paths	6

Size

Total Lines	64
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	27
CRAP Score	14

Importance

Changes

Metric	Value
cc	14
eloc	28
c	0
b	0
f	0
nc	6
nop	3
dl	0
loc	64
ccs	27
cts	27
cp	1
crap	14
rs	6.2666

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace PhpMyAdmin\SqlParser\Components;

use PhpMyAdmin\SqlParser\Component;

use function trim;

/**
 * `GROUP BY` keyword parser.
 */
final class GroupKeyword implements Component
{
    /** @var 'ASC'|'DESC'|null */

    public string|null $type = null;

    /**
     * The expression that is used for grouping.
     *
     * @var Expression
     */
    public $expr;

    /** @param Expression $expr the expression that we are sorting by */
    public function __construct(Expression|null $expr = null)
    {
        $this->expr = $expr;
    }

    public function build(): string
    {
        return trim((string) $this->expr);
    }

    public function __toString(): string
    {
        return $this->build();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PhpMyAdmin\SqlParser\Components;
6
7		use PhpMyAdmin\SqlParser\Component;
8
9		use function trim;
10
11		/**
12		* `GROUP BY` keyword parser.
13		*/
14		final class GroupKeyword implements Component
15		{
16		/** @var 'ASC'\|'DESC'\|null */
		0 ignored issues – show Documentation Bug introduced 2024-01-02 16:09 UTC by Report Bug Copy Issue Report The doc comment `'ASC'\|'DESC'\|null` at position `0` could not be parsed: Unknown type name ''ASC'' at position 0 in 'ASC'\|'DESC'\|null. Loading history...
17		public string\|null $type = null;
18
19		/**
20		* The expression that is used for grouping.
21		*
22		* @var Expression
23		*/
24		public $expr;
25
26		/** @param Expression $expr the expression that we are sorting by */
27	38	public function __construct(Expression\|null $expr = null)
28		{
29	38	$this->expr = $expr;
30		}
31
32	36	public function build(): string
33		{
34	36	return trim((string) $this->expr);
35		}
36
37	30	public function __toString(): string
38		{
39	30	return $this->build();
40		}
41		}
42

phpmyadmin / sql-parser

Push — master ( 578d3a...04a929 )

GroupKeyword::parse() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like