Inspection of "Misc: Updated information after transfer from udan..." - phpmyadmin/sql-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (5b6e9b)

by Dan

created 2016-02-10 15:15 UTC

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -30,14 +30,14 @@  discard block
 block discarded – undo
      *
      * @var int
      */
-    const TYPE_NONE                     =  0;
+    const TYPE_NONE = 0;
 
     /**
      * SQL specific keywords: SELECT, UPDATE, INSERT, etc.
      *
      * @var int
      */
-    const TYPE_KEYWORD                  =  1;
+    const TYPE_KEYWORD = 1;
 
     /**
      * Any type of legal operator.
@@ -51,14 +51,14 @@  discard block
 block discarded – undo
      *
      * @var int
      */
-    const TYPE_OPERATOR                 =  2;
+    const TYPE_OPERATOR = 2;
 
     /**
      * Spaces, tabs, new lines, etc.
      *
      * @var int
      */
-    const TYPE_WHITESPACE               =  3;
+    const TYPE_WHITESPACE = 3;
 
     /**
      * Any type of legal comment.
@@ -80,21 +80,21 @@  discard block
 block discarded – undo
      *
      * @var int
      */
-    const TYPE_COMMENT                  =  4;
+    const TYPE_COMMENT = 4;
 
     /**
      * Boolean values: true or false.
      *
      * @var int
      */
-    const TYPE_BOOL                     =  5;
+    const TYPE_BOOL = 5;
 
     /**
      * Numbers: 4, 0x8, 15.16, 23e42, etc.
      *
      * @var int
      */
-    const TYPE_NUMBER                   =  6;
+    const TYPE_NUMBER = 6;
 
     /**
      * Literal strings: 'string', "test".
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
      *
      * @var int
      */
-    const TYPE_STRING                   =  7;
+    const TYPE_STRING = 7;
 
     /**
      * Database, table names, variables, etc.
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
      *
      * @var int
      */
-    const TYPE_SYMBOL                   =  8;
+    const TYPE_SYMBOL = 8;
 
     /**
      * Delimits an unknown string.
@@ -118,46 +118,46 @@  discard block
 block discarded – undo
      *
      * @var int
      */
-    const TYPE_DELIMITER                =  9;
+    const TYPE_DELIMITER = 9;
 
     // Flags that describe the tokens in more detail.
     // All keywords must have flag 1 so `Context::isKeyword` method doesn't
     // require strict comparison.
-    const FLAG_KEYWORD_RESERVED         =  2;
-    const FLAG_KEYWORD_COMPOSED         =  4;
-    const FLAG_KEYWORD_DATA_TYPE        =  8;
+    const FLAG_KEYWORD_RESERVED         = 2;
+    const FLAG_KEYWORD_COMPOSED         = 4;
+    const FLAG_KEYWORD_DATA_TYPE        = 8;
     const FLAG_KEYWORD_KEY              = 16;
     const FLAG_KEYWORD_FUNCTION         = 32;
 
     // Numbers related flags.
-    const FLAG_NUMBER_HEX               =  1;
-    const FLAG_NUMBER_FLOAT             =  2;
-    const FLAG_NUMBER_APPROXIMATE       =  4;
-    const FLAG_NUMBER_NEGATIVE          =  8;
+    const FLAG_NUMBER_HEX               = 1;
+    const FLAG_NUMBER_FLOAT             = 2;
+    const FLAG_NUMBER_APPROXIMATE       = 4;
+    const FLAG_NUMBER_NEGATIVE          = 8;
     const FLAG_NUMBER_BINARY            = 16;
 
     // Strings related flags.
-    const FLAG_STRING_SINGLE_QUOTES     =  1;
-    const FLAG_STRING_DOUBLE_QUOTES     =  2;
+    const FLAG_STRING_SINGLE_QUOTES     = 1;
+    const FLAG_STRING_DOUBLE_QUOTES     = 2;
 
     // Comments related flags.
-    const FLAG_COMMENT_BASH             =  1;
-    const FLAG_COMMENT_C                =  2;
-    const FLAG_COMMENT_SQL              =  4;
-    const FLAG_COMMENT_MYSQL_CMD        =  8;
+    const FLAG_COMMENT_BASH             = 1;
+    const FLAG_COMMENT_C                = 2;
+    const FLAG_COMMENT_SQL              = 4;
+    const FLAG_COMMENT_MYSQL_CMD        = 8;
 
     // Operators related flags.
-    const FLAG_OPERATOR_ARITHMETIC      =  1;
-    const FLAG_OPERATOR_LOGICAL         =  2;
-    const FLAG_OPERATOR_BITWISE         =  4;
-    const FLAG_OPERATOR_ASSIGNMENT      =  8;
+    const FLAG_OPERATOR_ARITHMETIC      = 1;
+    const FLAG_OPERATOR_LOGICAL         = 2;
+    const FLAG_OPERATOR_BITWISE         = 4;
+    const FLAG_OPERATOR_ASSIGNMENT      = 8;
     const FLAG_OPERATOR_SQL             = 16;
 
     // Symbols related flags.
-    const FLAG_SYMBOL_VARIABLE          =  1;
-    const FLAG_SYMBOL_BACKTICK          =  2;
-    const FLAG_SYMBOL_USER              =  4;
-    const FLAG_SYMBOL_SYSTEM            =  8;
+    const FLAG_SYMBOL_VARIABLE          = 1;
+    const FLAG_SYMBOL_BACKTICK          = 2;
+    const FLAG_SYMBOL_USER              = 4;
+    const FLAG_SYMBOL_SYSTEM            = 8;
 
     /**
      * The token it its raw string representation.

Please login to merge, or discard this patch.

src/Utils/BufferedQuery.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -295,7 +295,7 @@
		block discarded – undo
295	295	* statement. This is the reason for the last condition.
296	296	*/
297	297	if (($i + 9 < $len)
298		- && (($this->query[$i ] === 'D') \|\| ($this->query[$i ] === 'd'))
	298	+ && (($this->query[$i] === 'D') \|\| ($this->query[$i] === 'd'))
299	299	&& (($this->query[$i + 1] === 'E') \|\| ($this->query[$i + 1] === 'e'))
300	300	&& (($this->query[$i + 2] === 'L') \|\| ($this->query[$i + 2] === 'l'))
301	301	&& (($this->query[$i + 3] === 'I') \|\| ($this->query[$i + 3] === 'i'))

Please login to merge, or discard this patch.

tools/ContextGenerator.php 1 patch

Spacing +43 added lines, -43 removed lines patch added patch discarded remove patch

		@@ -53,47 +53,47 @@ discard block
		block discarded – undo
53	53	* @var string
54	54	*/
55	55	const TEMPLATE =
56		- '<?php' . "\n" .
57		- '' . "\n" .
58		- '/**' . "\n" .
59		- ' * Context for %1$s.' . "\n" .
60		- ' *' . "\n" .
61		- ' * This file was auto-generated.' . "\n" .
62		- ' *' . "\n" .
63		- ' * @package SqlParser' . "\n" .
64		- ' * @subpackage Contexts' . "\n" .
65		- ' * @link %3$s' . "\n" .
66		- ' */' . "\n" .
67		- 'namespace SqlParser\\Contexts;' . "\n" .
68		- '' . "\n" .
69		- 'use SqlParser\\Context;' . "\n" .
70		- '' . "\n" .
71		- '/**' . "\n" .
72		- ' * Context for %1$s.' . "\n" .
73		- ' *' . "\n" .
74		- ' * @category Contexts' . "\n" .
75		- ' * @package SqlParser' . "\n" .
76		- ' * @subpackage Contexts' . "\n" .
77		- ' * @author Dan Ungureanu <[email protected]>' . "\n" .
78		- ' * @license http://opensource.org/licenses/GPL-2.0 GNU Public License' . "\n" .
79		- ' */' . "\n" .
80		- 'class %2$s extends Context' . "\n" .
81		- '{' . "\n" .
82		- '' . "\n" .
83		- ' /**' . "\n" .
84		- ' * List of keywords.' . "\n" .
85		- ' *' . "\n" .
86		- ' * The value associated to each keyword represents its flags.' . "\n" .
87		- ' *' . "\n" .
88		- ' * @see Token::FLAG_KEYWORD_*' . "\n" .
89		- ' *' . "\n" .
90		- ' * @var array' . "\n" .
91		- ' */' . "\n" .
92		- ' public static $KEYWORDS = array(' . "\n" .
93		- '' . "\n" .
94		- '%4$s' .
95		- ' );' . "\n" .
96		- '}' . "\n";
	56	+ '<?php' . "\n" .
	57	+ '' . "\n" .
	58	+ '/**' . "\n" .
	59	+ ' * Context for %1$s.' . "\n" .
	60	+ ' *' . "\n" .
	61	+ ' * This file was auto-generated.' . "\n" .
	62	+ ' *' . "\n" .
	63	+ ' * @package SqlParser' . "\n" .
	64	+ ' * @subpackage Contexts' . "\n" .
	65	+ ' * @link %3$s' . "\n" .
	66	+ ' */' . "\n" .
	67	+ 'namespace SqlParser\\Contexts;' . "\n" .
	68	+ '' . "\n" .
	69	+ 'use SqlParser\\Context;' . "\n" .
	70	+ '' . "\n" .
	71	+ '/**' . "\n" .
	72	+ ' * Context for %1$s.' . "\n" .
	73	+ ' *' . "\n" .
	74	+ ' * @category Contexts' . "\n" .
	75	+ ' * @package SqlParser' . "\n" .
	76	+ ' * @subpackage Contexts' . "\n" .
	77	+ ' * @author Dan Ungureanu <[email protected]>' . "\n" .
	78	+ ' * @license http://opensource.org/licenses/GPL-2.0 GNU Public License' . "\n" .
	79	+ ' */' . "\n" .
	80	+ 'class %2$s extends Context' . "\n" .
	81	+ '{' . "\n" .
	82	+ '' . "\n" .
	83	+ ' /**' . "\n" .
	84	+ ' * List of keywords.' . "\n" .
	85	+ ' *' . "\n" .
	86	+ ' * The value associated to each keyword represents its flags.' . "\n" .
	87	+ ' *' . "\n" .
	88	+ ' * @see Token::FLAG_KEYWORD_*' . "\n" .
	89	+ ' *' . "\n" .
	90	+ ' * @var array' . "\n" .
	91	+ ' */' . "\n" .
	92	+ ' public static $KEYWORDS = array(' . "\n" .
	93	+ '' . "\n" .
	94	+ '%4$s' .
	95	+ ' );' . "\n" .
	96	+ '}' . "\n";
97	97
98	98	/**
99	99	* Sorts an array of words.
		@@ -288,8 +288,8 @@ discard block
		block discarded – undo
288	288	* @var string
289	289	*/
290	290	$formattedName = str_replace(
291		- array('Context', 'MySql', '00', '0'),
292		- array('', 'MySQL ', '', '.'),
	291	+ array('Context', 'MySql', '00', '0'),
	292	+ array('', 'MySQL ', '', '.'),
293	293	$class
294	294	);
295	295

Please login to merge, or discard this patch.

		@@ -30,14 +30,14 @@ discard block
		block discarded – undo
30	30	*
31	31	* @var int
32	32	*/
33		- const TYPE_NONE = 0;
	33	+ const TYPE_NONE = 0;
34	34
35	35	/**
36	36	* SQL specific keywords: SELECT, UPDATE, INSERT, etc.
37	37	*
38	38	* @var int
39	39	*/
40		- const TYPE_KEYWORD = 1;
	40	+ const TYPE_KEYWORD = 1;
41	41
42	42	/**
43	43	* Any type of legal operator.
		@@ -51,14 +51,14 @@ discard block
		block discarded – undo
51	51	*
52	52	* @var int
53	53	*/
54		- const TYPE_OPERATOR = 2;
	54	+ const TYPE_OPERATOR = 2;
55	55
56	56	/**
57	57	* Spaces, tabs, new lines, etc.
58	58	*
59	59	* @var int
60	60	*/
61		- const TYPE_WHITESPACE = 3;
	61	+ const TYPE_WHITESPACE = 3;
62	62
63	63	/**
64	64	* Any type of legal comment.
		@@ -80,21 +80,21 @@ discard block
		block discarded – undo
80	80	*
81	81	* @var int
82	82	*/
83		- const TYPE_COMMENT = 4;
	83	+ const TYPE_COMMENT = 4;
84	84
85	85	/**
86	86	* Boolean values: true or false.
87	87	*
88	88	* @var int
89	89	*/
90		- const TYPE_BOOL = 5;
	90	+ const TYPE_BOOL = 5;
91	91
92	92	/**
93	93	* Numbers: 4, 0x8, 15.16, 23e42, etc.
94	94	*
95	95	* @var int
96	96	*/
97		- const TYPE_NUMBER = 6;
	97	+ const TYPE_NUMBER = 6;
98	98
99	99	/**
100	100	* Literal strings: 'string', "test".
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	*
103	103	* @var int
104	104	*/
105		- const TYPE_STRING = 7;
	105	+ const TYPE_STRING = 7;
106	106
107	107	/**
108	108	* Database, table names, variables, etc.
		@@ -110,7 +110,7 @@ discard block
		block discarded – undo
110	110	*
111	111	* @var int
112	112	*/
113		- const TYPE_SYMBOL = 8;
	113	+ const TYPE_SYMBOL = 8;
114	114
115	115	/**
116	116	* Delimits an unknown string.
		@@ -118,46 +118,46 @@ discard block
		block discarded – undo
118	118	*
119	119	* @var int
120	120	*/
121		- const TYPE_DELIMITER = 9;
	121	+ const TYPE_DELIMITER = 9;
122	122
123	123	// Flags that describe the tokens in more detail.
124	124	// All keywords must have flag 1 so `Context::isKeyword` method doesn't
125	125	// require strict comparison.
126		- const FLAG_KEYWORD_RESERVED = 2;
127		- const FLAG_KEYWORD_COMPOSED = 4;
128		- const FLAG_KEYWORD_DATA_TYPE = 8;
	126	+ const FLAG_KEYWORD_RESERVED = 2;
	127	+ const FLAG_KEYWORD_COMPOSED = 4;
	128	+ const FLAG_KEYWORD_DATA_TYPE = 8;
129	129	const FLAG_KEYWORD_KEY = 16;
130	130	const FLAG_KEYWORD_FUNCTION = 32;
131	131
132	132	// Numbers related flags.
133		- const FLAG_NUMBER_HEX = 1;
134		- const FLAG_NUMBER_FLOAT = 2;
135		- const FLAG_NUMBER_APPROXIMATE = 4;
136		- const FLAG_NUMBER_NEGATIVE = 8;
	133	+ const FLAG_NUMBER_HEX = 1;
	134	+ const FLAG_NUMBER_FLOAT = 2;
	135	+ const FLAG_NUMBER_APPROXIMATE = 4;
	136	+ const FLAG_NUMBER_NEGATIVE = 8;
137	137	const FLAG_NUMBER_BINARY = 16;
138	138
139	139	// Strings related flags.
140		- const FLAG_STRING_SINGLE_QUOTES = 1;
141		- const FLAG_STRING_DOUBLE_QUOTES = 2;
	140	+ const FLAG_STRING_SINGLE_QUOTES = 1;
	141	+ const FLAG_STRING_DOUBLE_QUOTES = 2;
142	142
143	143	// Comments related flags.
144		- const FLAG_COMMENT_BASH = 1;
145		- const FLAG_COMMENT_C = 2;
146		- const FLAG_COMMENT_SQL = 4;
147		- const FLAG_COMMENT_MYSQL_CMD = 8;
	144	+ const FLAG_COMMENT_BASH = 1;
	145	+ const FLAG_COMMENT_C = 2;
	146	+ const FLAG_COMMENT_SQL = 4;
	147	+ const FLAG_COMMENT_MYSQL_CMD = 8;
148	148
149	149	// Operators related flags.
150		- const FLAG_OPERATOR_ARITHMETIC = 1;
151		- const FLAG_OPERATOR_LOGICAL = 2;
152		- const FLAG_OPERATOR_BITWISE = 4;
153		- const FLAG_OPERATOR_ASSIGNMENT = 8;
	150	+ const FLAG_OPERATOR_ARITHMETIC = 1;
	151	+ const FLAG_OPERATOR_LOGICAL = 2;
	152	+ const FLAG_OPERATOR_BITWISE = 4;
	153	+ const FLAG_OPERATOR_ASSIGNMENT = 8;
154	154	const FLAG_OPERATOR_SQL = 16;
155	155
156	156	// Symbols related flags.
157		- const FLAG_SYMBOL_VARIABLE = 1;
158		- const FLAG_SYMBOL_BACKTICK = 2;
159		- const FLAG_SYMBOL_USER = 4;
160		- const FLAG_SYMBOL_SYSTEM = 8;
	157	+ const FLAG_SYMBOL_VARIABLE = 1;
	158	+ const FLAG_SYMBOL_BACKTICK = 2;
	159	+ const FLAG_SYMBOL_USER = 4;
	160	+ const FLAG_SYMBOL_SYSTEM = 8;
161	161
162	162	/**
163	163	* The token it its raw string representation.

phpmyadmin / sql-parser

Branch — master (5b6e9b)

Category

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +43 added lines, -43 removed lines patch added patch discarded remove patch