WithStatement::build() - Code Metrics - Inspection of "Completing, refactoring and improving the `WITH` s..." - phpmyadmin/sql-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#363)

unknown

created 2021-12-06 01:34 UTC

WithStatement::build() A

↳ Parent: WithStatement

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	3
nop	0
dl	0
loc	10
ccs	0
cts	0
cp	0
crap	12
rs	10
c	1
b	0
f	0

<?php
/**
 * `WITH` statement.
 */

declare(strict_types=1);

namespace PhpMyAdmin\SqlParser\Statements;

use PhpMyAdmin\SqlParser\Components\Array2d;
use PhpMyAdmin\SqlParser\Components\OptionsArray;
use PhpMyAdmin\SqlParser\Components\WithKeyword;
use PhpMyAdmin\SqlParser\Exceptions\ParserException;
use PhpMyAdmin\SqlParser\Parser;
use PhpMyAdmin\SqlParser\Statement;
use PhpMyAdmin\SqlParser\Token;
use PhpMyAdmin\SqlParser\TokensList;
use PhpMyAdmin\SqlParser\Translator;

use function array_slice;
use function count;

/**
 * `WITH` statement.

 *  WITH [RECURSIVE] query_name [ (column_name [,...]) ] AS (SELECT ...) [, ...]
 */
final class WithStatement extends Statement
{
    /**
     * Options for `WITH` statements and their slot ID.
     *
     * @var mixed[]
     */
    public static $OPTIONS = ['RECURSIVE' => 1];

    /**
     * The clauses of this statement, in order.
     *
     * @see Statement::$CLAUSES
     *
     * @var mixed[]
     */
    public static $CLAUSES = [
        'WITH' => [
            'WITH',
            2,
        ],
        // Used for options.
        '_OPTIONS' => [
            '_OPTIONS',
            1,
        ],
        'AS' => [
            'AS',
            2,
        ],
    ];

    /** @var WithKeyword[] */
    public $withers = [];

    /**
     * @param Parser     $parser the instance that requests parsing
     * @param TokensList $list   the list of tokens to be parsed
     */
    public function parse(Parser $parser, TokensList $list)
    {
        /**
         * The state of the parser.
         *
         * Below are the states of the parser.
         *
         *      0 ---------------- [ name ] -----------------> 1
         *
         *      1 ------------------ [ ( ] ------------------> 2
         *
         *      2 ------------------ [ AS ] -----------------> 3
         *
         *      3 ------------------ [ ( ] ------------------> 4
         *
         *      4 ------------------ [ , ] ------------------> 1
         *
         *      4 ----- [ SELECT/UPDATE/DELETE/INSERT ] -----> 5
         *
         * @var int
         */
        $state = 0;
        $wither = null;

        ++$list->idx; // Skipping `WITH`.

        // parse any options if provided
        $this->options = OptionsArray::parse($parser, $list, static::$OPTIONS);
        ++$list->idx;

        for (; $list->idx < $list->count; ++$list->idx) {
            /**
             * Token parsed at this moment.
             *
             * @var Token
             */
            $token = $list->tokens[$list->idx];

            // Skipping whitespaces and comments.
            if ($token->type === Token::TYPE_WHITESPACE || $token->type === Token::TYPE_COMMENT) {
                continue;
            }

            if ($state === 0) {
                if ($token->type !== Token::TYPE_NONE) {
                    $parser->error('The name of the CTE was expected.', $token);
                    break;
                }

                $wither = $token->value;
                $this->withers[$wither] = new WithKeyword($wither);
                $state = 1;
            } elseif ($state === 1) {
                if ($token->type === Token::TYPE_OPERATOR && $token->value === '(') {
                    $this->withers[$wither]->columns = Array2d::parse($parser, $list);
                    $state = 2;
                } elseif ($token->type === Token::TYPE_KEYWORD && $token->keyword === 'AS') {
                    $state = 3;
                } else {
                    $parser->error('Unexpected token.', $token);
                    break;
                }
            } elseif ($state === 2) {
                if (! ($token->type === Token::TYPE_KEYWORD && $token->keyword === 'AS')) {
                    $parser->error('AS keyword was expected.', $token);
                    break;
                }

                $state = 3;
            } elseif ($state === 3) {
                $idxBeforeGetNext = $list->idx;

                // We want to get the next non-comment and non-space token after $token
                // therefore, the first getNext call will start with the current $idx which's $token,
                // will return it and increase $idx by 1, which's not guaranteed to be non-comment
                // and non-space, that's why we're calling getNext again.
                $list->getNext();
                $nextKeyword = $list->getNext();

                if (! ($token->value === '(' && ($nextKeyword && $nextKeyword->value === 'SELECT'))) {
                    $parser->error('Subquery of the CTE was expected.', $token);
                    $list->idx = $idxBeforeGetNext;
                    break;
                }

                // Restore the index
                $list->idx = $idxBeforeGetNext;

                ++$list->idx;
                $subList = $this->getSubTokenList($list);
                if ($subList instanceof ParserException) {
                    $parser->errors[] = $subList;
                    break;
                }

                $subParser = new Parser($subList);

                if (count($subParser->errors)) {
                    foreach ($subParser->errors as $error) {
                        $parser->errors[] = $error;
                    }

                    break;
                }

                $this->withers[$wither]->statement = $subParser;

                $state = 4;
            } elseif ($state === 4) {
                if ($token->value === ',') {
                    // There's another WITH expression to parse, go back to state=0
                    $state = 0;
                    continue;
                }

                if (
                    $token->type === Token::TYPE_KEYWORD && (
                    $token->value === 'SELECT'
                    || $token->value === 'INSERT'
                    || $token->value === 'UPDATE'
                    || $token->value === 'DELETE'
                    )
                ) {
                    $state = 5;
                    --$list->idx;
                    continue;
                }

                $parser->error('An expression was expected.', $token);
                break;
            } elseif ($state === 5) {
                /**
                 * We need to parse all of the remaining tokens becuase mostly, they are only the CTE expression
                 * which's mostly is SELECT, or INSERT, UPDATE, or delete statement.
                 * e.g: INSERT .. ( SELECT 1 ) SELECT col1 FROM cte ON DUPLICATE KEY UPDATE col_name = 3.
                 * The issue is that, `ON DUPLICATE KEY UPDATE col_name = 3` is related to the main INSERT query
                 * not the cte expression (SELECT col1 FROM cte) we need to determine the end of the expression
                 * to parse `ON DUPLICATE KEY UPDATE` from the InsertStatement parser instead.
                 */

                // Index of the last parsed token by default would be the last token in the $list, because we're
                // assuming that all remaining tokens at state 4, are related to the expression.
                $idxOfLastParsedToken = $list->count - 1;
                // Index before search to be able to restore the index.
                $idxBeforeSearch = $list->idx;
                // Length of expression tokens is null by default, in order for the $subList to start
                // from $list->idx to the end of the $list.
                $lengthOfExpressionTokens = null;

                if ($list->getNextOfTypeAndValue(Token::TYPE_KEYWORD, 'ON')) {
                    // (-1) because getNextOfTypeAndValue returned ON and increased the index.
                    $idxOfOn = $list->idx - 1;
                    // Index of the last parsed token will be the token before the ON Keyword, therefore $idxOfOn - 1.
                    $idxOfLastParsedToken = $idxOfOn - 1;
                    // The length of the expression tokens would be the position of
                    $lengthOfExpressionTokens = $idxOfOn - $idxBeforeSearch;
                }

                // Restore the index
                $list->idx = $idxBeforeSearch;

                $subList = new TokensList(array_slice($list->tokens, $list->idx, $lengthOfExpressionTokens));
                $subParser = new Parser($subList);
                if (count($subParser->errors)) {
                    foreach ($subParser->errors as $error) {
                        $parser->errors[] = $error;
                    }
                }

                $list->idx = $idxOfLastParsedToken;
                break;
            }
        }

        // 5 is the only valid end state
        if ($state !== 5) {

            $parser->error('Unexpected end of WITH CTE.', $list->tokens[$list->idx]);
        }

        --$list->idx;
    }

    /**
     * {@inheritdoc}
     */
    public function build()
    {
        $str = 'WITH ';

        foreach ($this->withers as $wither) {
            $str .= $str === 'WITH ' ? '' : ', ';
            $str .= WithKeyword::build($wither);
        }

        return $str;
    }

    /**
     * Get tokens within the WITH expression to use them in another parser
     *
     * @return ParserException|TokensList
     */
    private function getSubTokenList(TokensList $list)
    {
        $idx = $list->idx;
        /** @var Token $token */
        $token = $list->tokens[$list->idx];
        $openParenthesis = 0;

        while ($list->idx < $list->count) {
            if ($token->value === '(') {
                ++$openParenthesis;
            } elseif ($token->value === ')') {
                if (--$openParenthesis === -1) {
                    break;
                }
            }

            ++$list->idx;
            if (! isset($list->tokens[$list->idx])) {
                break;
            }

            $token = $list->tokens[$list->idx];
        }

        // performance improvement: return the error to avoid a try/catch in the loop
        if ($list->idx === $list->count) {
            --$list->idx;

            return new ParserException(
                Translator::gettext('A closing bracket was expected.'),
                $token
            );
        }

        $length = $list->idx - $idx;

        return new TokensList(array_slice($list->tokens, $idx, $length), $length);
    }
}


1		<?php
2		/**
3		* `WITH` statement.
4		*/
5
6		declare(strict_types=1);
7
8		namespace PhpMyAdmin\SqlParser\Statements;
9
10		use PhpMyAdmin\SqlParser\Components\Array2d;
11		use PhpMyAdmin\SqlParser\Components\OptionsArray;
12		use PhpMyAdmin\SqlParser\Components\WithKeyword;
13		use PhpMyAdmin\SqlParser\Exceptions\ParserException;
14		use PhpMyAdmin\SqlParser\Parser;
15		use PhpMyAdmin\SqlParser\Statement;
16		use PhpMyAdmin\SqlParser\Token;
17		use PhpMyAdmin\SqlParser\TokensList;
18		use PhpMyAdmin\SqlParser\Translator;
19
20		use function array_slice;
21		use function count;
22
23		/**
24		* `WITH` statement.
25
26		* WITH [RECURSIVE] query_name [ (column_name [,...]) ] AS (SELECT ...) [, ...]
27		*/
28		final class WithStatement extends Statement
29		{
30		/**
31		* Options for `WITH` statements and their slot ID.
32		*
33		* @var mixed[]
34		*/
35		public static $OPTIONS = ['RECURSIVE' => 1];
36
37		/**
38		* The clauses of this statement, in order.
39		*
40		* @see Statement::$CLAUSES
41		*
42		* @var mixed[]
43		*/
44		public static $CLAUSES = [
45		'WITH' => [
46		'WITH',
47		2,
48		],
49		// Used for options.
50		'_OPTIONS' => [
51		'_OPTIONS',
52		1,
53		],
54		'AS' => [
55		'AS',
56		2,
57		],
58		];
59
60		/** @var WithKeyword[] */
61		public $withers = [];
62
63		/**
64		* @param Parser $parser the instance that requests parsing
65		* @param TokensList $list the list of tokens to be parsed
66		*/
67	16	public function parse(Parser $parser, TokensList $list)
68		{
69	16	/**
70		* The state of the parser.
71		*
72	16	* Below are the states of the parser.
73	16	*
74		* 0 ---------------- [ name ] -----------------> 1
75		*
76		* 1 ------------------ [ ( ] ------------------> 2
77		*
78		* 2 ------------------ [ AS ] -----------------> 3
79		*
80		* 3 ------------------ [ ( ] ------------------> 4
81		*
82		* 4 ------------------ [ , ] ------------------> 1
83		*
84		* 4 ----- [ SELECT/UPDATE/DELETE/INSERT ] -----> 5
85		*
86	16	* @var int
87	16	*/
88		$state = 0;
89	16	$wither = null;
90
91		++$list->idx; // Skipping `WITH`.
92
93		// parse any options if provided
94		$this->options = OptionsArray::parse($parser, $list, static::$OPTIONS);
95	16	++$list->idx;
96
97		for (; $list->idx < $list->count; ++$list->idx) {
98	16	/**
99	12	* Token parsed at this moment.
100		*
101		* @var Token
102	16	*/
103	16	$token = $list->tokens[$list->idx];
104	16
105	16	// Skipping whitespaces and comments.
106	16	if ($token->type === Token::TYPE_WHITESPACE \|\| $token->type === Token::TYPE_COMMENT) {
107		continue;
108		}
109	16
110	16	if ($state === 0) {
111	12	if ($token->type !== Token::TYPE_NONE) {
112	12	$parser->error('The name of the CTE was expected.', $token);
113		break;
114		}
115	16
116	16	$wither = $token->value;
117	16	$this->withers[$wither] = new WithKeyword($wither);
118	16	$state = 1;
119		} elseif ($state === 1) {
120	16	if ($token->type === Token::TYPE_OPERATOR && $token->value === '(') {
121	16	$this->withers[$wither]->columns = Array2d::parse($parser, $list);
122	16	$state = 2;
123	16	} elseif ($token->type === Token::TYPE_KEYWORD && $token->keyword === 'AS') {
124	16	$state = 3;
125	4	} else {
126	4	$parser->error('Unexpected token.', $token);
127		break;
128		}
129	12	} elseif ($state === 2) {
130		if (! ($token->type === Token::TYPE_KEYWORD && $token->keyword === 'AS')) {
131	12	$parser->error('AS keyword was expected.', $token);
132	4	break;
133	4	}
134
135		$state = 3;
136		} elseif ($state === 3) {
137	12	$idxBeforeGetNext = $list->idx;
138	12
139		// We want to get the next non-comment and non-space token after $token
140		// therefore, the first getNext call will start with the current $idx which's $token,
141		// will return it and increase $idx by 1, which's not guaranteed to be non-comment
142	12	// and non-space, that's why we're calling getNext again.
143	4	$list->getNext();
144	4	$nextKeyword = $list->getNext();
145	4
146		if (! ($token->value === '(' && ($nextKeyword && $nextKeyword->value === 'SELECT'))) {
147		$parser->error('Subquery of the CTE was expected.', $token);
148		$list->idx = $idxBeforeGetNext;
149	12	break;
150		}
151
152		// Restore the index
153	16	$list->idx = $idxBeforeGetNext;
154	16
155		++$list->idx;
156		$subList = $this->getSubTokenList($list);
157		if ($subList instanceof ParserException) {
158		$parser->errors[] = $subList;
159	8	break;
160		}
161	8
162		$subParser = new Parser($subList);
163	8
164	8	if (count($subParser->errors)) {
165	8	foreach ($subParser->errors as $error) {
166		$parser->errors[] = $error;
167		}
168	8
169		break;
170		}
171
172		$this->withers[$wither]->statement = $subParser;
173
174		$state = 4;
175		} elseif ($state === 4) {
176	16	if ($token->value === ',') {
177		// There's another WITH expression to parse, go back to state=0
178	16	$state = 0;
179		continue;
180	16	}
181	16
182		if (
183	16	$token->type === Token::TYPE_KEYWORD && (
184	16	$token->value === 'SELECT'
185	8	\|\| $token->value === 'INSERT'
186	16	\|\| $token->value === 'UPDATE'
187	16	\|\| $token->value === 'DELETE'
188	12	)
189		) {
190		$state = 5;
191		--$list->idx;
192	16	continue;
193	16	}
194	4
195		$parser->error('An expression was expected.', $token);
196		break;
197	16	} elseif ($state === 5) {
198		/**
199		* We need to parse all of the remaining tokens becuase mostly, they are only the CTE expression
200		* which's mostly is SELECT, or INSERT, UPDATE, or delete statement.
201	16	* e.g: INSERT .. ( SELECT 1 ) SELECT col1 FROM cte ON DUPLICATE KEY UPDATE col_name = 3.
202	4	* The issue is that, `ON DUPLICATE KEY UPDATE col_name = 3` is related to the main INSERT query
203		* not the cte expression (SELECT col1 FROM cte) we need to determine the end of the expression
204	4	* to parse `ON DUPLICATE KEY UPDATE` from the InsertStatement parser instead.
205	4	*/
206	1
207		// Index of the last parsed token by default would be the last token in the $list, because we're
208		// assuming that all remaining tokens at state 4, are related to the expression.
209		$idxOfLastParsedToken = $list->count - 1;
210	12	// Index before search to be able to restore the index.
211		$idxBeforeSearch = $list->idx;
212	12	// Length of expression tokens is null by default, in order for the $subList to start
213		// from $list->idx to the end of the $list.
214		$lengthOfExpressionTokens = null;
215
216		if ($list->getNextOfTypeAndValue(Token::TYPE_KEYWORD, 'ON')) {
217		// (-1) because getNextOfTypeAndValue returned ON and increased the index.
218		$idxOfOn = $list->idx - 1;
219		// Index of the last parsed token will be the token before the ON Keyword, therefore $idxOfOn - 1.
220		$idxOfLastParsedToken = $idxOfOn - 1;
221		// The length of the expression tokens would be the position of
222		$lengthOfExpressionTokens = $idxOfOn - $idxBeforeSearch;
223		}
224
225		// Restore the index
226		$list->idx = $idxBeforeSearch;
227
228		$subList = new TokensList(array_slice($list->tokens, $list->idx, $lengthOfExpressionTokens));
229		$subParser = new Parser($subList);
230		if (count($subParser->errors)) {
231		foreach ($subParser->errors as $error) {
232		$parser->errors[] = $error;
233		}
234		}
235
236		$list->idx = $idxOfLastParsedToken;
237		break;
238		}
239		}
240
241		// 5 is the only valid end state
242		if ($state !== 5) {
		0 ignored issues – show introduced 2021-12-05 22:53 UTC by Report Bug Copy Issue Report The condition `$state !== 5` is always `true`. Loading history...
243		$parser->error('Unexpected end of WITH CTE.', $list->tokens[$list->idx]);
244		}
245
246		--$list->idx;
247		}
248
249		/**
250		* {@inheritdoc}
251		*/
252		public function build()
253		{
254		$str = 'WITH ';
255
256		foreach ($this->withers as $wither) {
257		$str .= $str === 'WITH ' ? '' : ', ';
258		$str .= WithKeyword::build($wither);
259		}
260
261		return $str;
262		}
263
264		/**
265		* Get tokens within the WITH expression to use them in another parser
266		*
267		* @return ParserException\|TokensList
268		*/
269		private function getSubTokenList(TokensList $list)
270		{
271		$idx = $list->idx;
272		/** @var Token $token */
273		$token = $list->tokens[$list->idx];
274		$openParenthesis = 0;
275
276		while ($list->idx < $list->count) {
277		if ($token->value === '(') {
278		++$openParenthesis;
279		} elseif ($token->value === ')') {
280		if (--$openParenthesis === -1) {
281		break;
282		}
283		}
284
285		++$list->idx;
286		if (! isset($list->tokens[$list->idx])) {
287		break;
288		}
289
290		$token = $list->tokens[$list->idx];
291		}
292
293		// performance improvement: return the error to avoid a try/catch in the loop
294		if ($list->idx === $list->count) {
295		--$list->idx;
296
297		return new ParserException(
298		Translator::gettext('A closing bracket was expected.'),
299		$token
300		);
301		}
302
303		$length = $list->idx - $idx;
304
305		return new TokensList(array_slice($list->tokens, $idx, $length), $length);
306		}
307		}
308

phpmyadmin / sql-parser

Pull Request — master (#363)

WithStatement::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like