TerminalExpression::factory() - Code Metrics - Inspection of "Define type methods at TerminalExpression class" - phpmyadmin/simple-math - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6a8856...a11be9 )

by Michal

created 2016-10-12 14:41 UTC

TerminalExpression::factory() D

↳ Parent: TerminalExpression

Complexity

Conditions	22
Paths	21

Size

Total Lines	46
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	46
rs	4.8056
cc	22
eloc	41
nc	21
nop	1

How to fix Complexity

<?php
namespace SimpleMath;

abstract class TerminalExpression {

    protected $value = '';
    protected $precidence = 0;
    protected $leftAssoc = true;

    public function __construct($value) {
        $this->value = $value;
    }

    public function getPrecidence() {
        return $this->precidence;
    }

    public function isLeftAssoc() {
        return $this->leftAssoc;
    }

    public function isOpen() {
        return false;
    }

    public static function factory($value) {
        if (is_object($value) && $value instanceof TerminalExpression) {
            return $value;
        } elseif (is_numeric($value)) {
            return new Number($value);
        } elseif (preg_match('/^\$?[a-z]+$/', $value)) {
            return new Variable($value);
        }

        switch ($value) {
            case '+':
                return new Addition($value);
            case '-':
                return new Subtraction($value);
            case '*':
                return new Multiplication($value);
            case '/':
                return new Division($value);
            case '%':
                return new Modulo($value);
            case '?':
            case ':':
                return new Ternary($value);
            case '(':
            case ')':
                return new Parenthesis($value);
            case '==':
                return new ComparisonEQ($value);
            case '<':
                return new ComparisonLT($value);
            case '>':
                return new ComparisonGT($value);
            case '<=':
                return new ComparisonLTE($value);
            case '>=':
                return new ComparisonGTE($value);
            case '!=':
                return new ComparisonNE($value);
            case '||':
                return new OperatorOr($value);
            case '&&':
                return new OperatorAnd($value);
        }

        throw new \Exception('Undefined Value ' . $value);
    }

    abstract public function operate(Stack $stack, $variables=array());

    public function isOperator() {
        return false;
    }

    public function isParenthesis() {
        return false;
    }

    public function render() {
        return $this->value;
    }
}


1			<?php
2			namespace SimpleMath;
3
4			abstract class TerminalExpression {
5
6			protected $value = '';
7			protected $precidence = 0;
8			protected $leftAssoc = true;
9
10			public function __construct($value) {
11			$this->value = $value;
12			}
13
14			public function getPrecidence() {
15			return $this->precidence;
16			}
17
18			public function isLeftAssoc() {
19			return $this->leftAssoc;
20			}
21
22			public function isOpen() {
23			return false;
24			}
25
26			public static function factory($value) {
27			if (is_object($value) && $value instanceof TerminalExpression) {
28			return $value;
29			} elseif (is_numeric($value)) {
30			return new Number($value);
31			} elseif (preg_match('/^\$?[a-z]+$/', $value)) {
32			return new Variable($value);
33			}
34
35			switch ($value) {
36			case '+':
37			return new Addition($value);
38			case '-':
39			return new Subtraction($value);
40			case '*':
41			return new Multiplication($value);
42			case '/':
43			return new Division($value);
44			case '%':
45			return new Modulo($value);
46			case '?':
47			case ':':
48			return new Ternary($value);
49			case '(':
50			case ')':
51			return new Parenthesis($value);
52			case '==':
53			return new ComparisonEQ($value);
54			case '<':
55			return new ComparisonLT($value);
56			case '>':
57			return new ComparisonGT($value);
58			case '<=':
59			return new ComparisonLTE($value);
60			case '>=':
61			return new ComparisonGTE($value);
62			case '!=':
63			return new ComparisonNE($value);
64			case '\|\|':
65			return new OperatorOr($value);
66			case '&&':
67			return new OperatorAnd($value);
68			}
69
70			throw new \Exception('Undefined Value ' . $value);
71			}
72
73			abstract public function operate(Stack $stack, $variables=array());
74
75			public function isOperator() {
76			return false;
77			}
78
79			public function isParenthesis() {
80			return false;
81			}
82
83			public function render() {
84			return $this->value;
85			}
86			}
87

phpmyadmin / simple-math

Push — master ( 6a8856...a11be9 )

TerminalExpression::factory() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like