Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
23 | View Code Duplication | abstract class Comparison extends Operator { |
|
24 | |||
25 | protected $precidence = 3; |
||
26 | |||
27 | public function operate(\SimpleMath\Stack $stack, $variables=array()) |
||
33 | |||
34 | abstract protected function cmp($left, $right); |
||
35 | } |
||
36 |