ShapeFile::addRecord() - Code Metrics - Inspection of "Split code based on classes" - phpmyadmin/shapefile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 001830...de2f31 )

by Michal

created 2016-06-14 09:37 UTC

ShapeFile::addRecord() F

↳ Parent: ShapeFile

Complexity

Conditions	25
Paths	800

Size

Total Lines	27
Code Lines	17

Duplication

Lines	4
Ratio	14.81 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	4
loc	27
rs	2.771
cc	25
eloc	17
nc	800
nop	1

How to fix Complexity

<?php
/**
 * BytesFall ShapeFiles library
 *
 * The library implements the 2D variants of the ShapeFile format as defined in
 * http://www.esri.com/library/whitepapers/pdfs/shapefile.pdf.
 * The library currently supports reading and editing of ShapeFiles and the
 * Associated information (DBF file).
 *
 * @package bfShapeFiles
 * @version 0.0.2
 * @link http://bfshapefiles.sourceforge.net/
 * @license http://www.gnu.org/licenses/gpl-2.0.html GPLv2-or-later
 *
 * Copyright 2006-2007 Ovidio <ovidio AT users.sourceforge.net>
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, you can download one from
 * http://www.gnu.org/copyleft/gpl.html.
 *
 */
namespace ShapeFile;

/**
 * ShapeFile class
 *
 * @package bfShapeFiles
 */
  class ShapeFile {
    var $FileName;
class A {
    var $property;
}

    var $SHPFile;
class A {
    var $property;
}
    var $SHXFile;
class A {
    var $property;
}
    var $DBFFile;
class A {
    var $property;
}

    var $DBFHeader;
class A {
    var $property;
}

    var $lastError = "";
class A {
    var $property;
}

    var $boundingBox = array("xmin" => 0.0, "ymin" => 0.0, "xmax" => 0.0, "ymax" => 0.0);
class A {
    var $property;
}
    var $fileLength = 0;
class A {
    var $property;
}
    var $shapeType = 0;
class A {
    var $property;
}

    var $records;
class A {
    var $property;
}

    public function __construct($shapeType, $boundingBox = array("xmin" => 0.0, "ymin" => 0.0, "xmax" => 0.0, "ymax" => 0.0), $FileName = NULL) {
      $this->shapeType = $shapeType;
      $this->boundingBox = $boundingBox;
      $this->FileName = $FileName;
      $this->fileLength = 50; // The value for file length is the total length of the file in 16-bit words (including the fifty 16-bit words that make up the header).
    }

    function loadFromFile($FileName) {

      $this->FileName = $FileName;

      if (($this->_openSHPFile()) && ($this->_openDBFFile())) {
        $this->_loadHeaders();
        $this->_loadRecords();
        $this->_closeSHPFile();
        $this->_closeDBFFile();
      } else {
        return false;
      }
    }

    function saveToFile($FileName = NULL) {

      if ($FileName != NULL) $this->FileName = $FileName;

      if (($this->_openSHPFile(TRUE)) && ($this->_openSHXFile(TRUE)) && ($this->_openDBFFile(TRUE))) {
        $this->_saveHeaders();
        $this->_saveRecords();
        $this->_closeSHPFile();
        $this->_closeSHXFile();
        $this->_closeDBFFile();
      } else {
        return false;
      }
    }

    function addRecord($record) {

      if ((isset($this->DBFHeader)) && (is_array($this->DBFHeader))) {
        $record->updateDBFInfo($this->DBFHeader);
      }

      $this->fileLength += ($record->getContentLength() + 4);
      $this->records[] = $record;
      $this->records[count($this->records) - 1]->recordNumber = count($this->records);

      if ($this->boundingBox["xmin"]==0.0 || ($this->boundingBox["xmin"]>$record->SHPData["xmin"])) $this->boundingBox["xmin"] = $record->SHPData["xmin"];
      if ($this->boundingBox["xmax"]==0.0 || ($this->boundingBox["xmax"]<$record->SHPData["xmax"])) $this->boundingBox["xmax"] = $record->SHPData["xmax"];

      if ($this->boundingBox["ymin"]==0.0 || ($this->boundingBox["ymin"]>$record->SHPData["ymin"])) $this->boundingBox["ymin"] = $record->SHPData["ymin"];
      if ($this->boundingBox["ymax"]==0.0 || ($this->boundingBox["ymax"]<$record->SHPData["ymax"])) $this->boundingBox["ymax"] = $record->SHPData["ymax"];

      if (in_array($this->shapeType,array(11,13,15,18,21,23,25,28))) {
        if (!isset($this->boundingBox["mmin"]) || $this->boundingBox["mmin"]==0.0 || ($this->boundingBox["mmin"]>$record->SHPData["mmin"])) $this->boundingBox["mmin"] = $record->SHPData["mmin"];

        if (!isset($this->boundingBox["mmax"]) || $this->boundingBox["mmax"]==0.0 || ($this->boundingBox["mmax"]<$record->SHPData["mmax"])) $this->boundingBox["mmax"] = $record->SHPData["mmax"];

      }

      if (in_array($this->shapeType,array(11,13,15,18))) {
        if (!isset($this->boundingBox["zmin"]) || $this->boundingBox["zmin"]==0.0 || ($this->boundingBox["zmin"]>$record->SHPData["zmin"])) $this->boundingBox["zmin"] = $record->SHPData["zmin"];

        if (!isset($this->boundingBox["zmax"]) || $this->boundingBox["zmax"]==0.0 || ($this->boundingBox["zmax"]<$record->SHPData["zmax"])) $this->boundingBox["zmax"] = $record->SHPData["zmax"];

      }

      return (count($this->records) - 1);
    }

    function deleteRecord($index) {

      if (isset($this->records[$index])) {
        $this->fileLength -= ($this->records[$index]->getContentLength() + 4);
        for ($i = $index; $i < (count($this->records) - 1); $i++) {
          $this->records[$i] = $this->records[$i + 1];
        }
        unset($this->records[count($this->records) - 1]);
        $this->_deleteRecordFromDBF($index);
      }
    }

    function getDBFHeader() {

      return $this->DBFHeader;
    }

    function setDBFHeader($header) {

      $this->DBFHeader = $header;

      for ($i = 0; $i < count($this->records); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
        $this->records[$i]->updateDBFInfo($header);
      }
    }

    function getIndexFromDBFData($field, $value) {

      $result = -1;
      for ($i = 0; $i < (count($this->records) - 1); $i++) {
        if (isset($this->records[$i]->DBFData[$field]) && (strtoupper($this->records[$i]->DBFData[$field]) == strtoupper($value))) {
          $result = $i;
        }
      }

      return $result;
    }

    function _loadDBFHeader() {

      $DBFFile = fopen(str_replace('.*', '.dbf', $this->FileName), 'r');

      $result = array();
      $buff32 = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
      $i = 1;
      $inHeader = true;

      while ($inHeader) {
        if (!feof($DBFFile)) {
          $buff32 = fread($DBFFile, 32);
          if ($i > 1) {
            if (substr($buff32, 0, 1) == chr(13)) {
              $inHeader = false;
            } else {
              $pos = strpos(substr($buff32, 0, 10), chr(0));
              $pos = ($pos == 0 ? 10 : $pos);

              $fieldName = substr($buff32, 0, $pos);
              $fieldType = substr($buff32, 11, 1);
              $fieldLen = ord(substr($buff32, 16, 1));
              $fieldDec = ord(substr($buff32, 17, 1));

              array_push($result, array($fieldName, $fieldType, $fieldLen, $fieldDec));
            }
          }
          $i++;
        } else {
          $inHeader = false;
        }
      }

      fclose($DBFFile);
      return($result);
    }

    function _deleteRecordFromDBF($index) {

      if (@dbase_delete_record($this->DBFFile, $index)) {
        @dbase_pack($this->DBFFile);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
      }
    }

    function _loadHeaders() {

      fseek($this->SHPFile, 24, SEEK_SET);
      $this->fileLength = Util::loadData("N", fread($this->SHPFile, 4));

      fseek($this->SHPFile, 32, SEEK_SET);
      $this->shapeType = Util::loadData("V", fread($this->SHPFile, 4));

      $this->boundingBox = array();
      $this->boundingBox["xmin"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["ymin"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["xmax"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["ymax"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["zmin"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["zmax"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["mmin"] = Util::loadData("d", fread($this->SHPFile, 8));
      $this->boundingBox["mmax"] = Util::loadData("d", fread($this->SHPFile, 8));

      $this->DBFHeader = $this->_loadDBFHeader();
    }

    function _saveHeaders() {

      fwrite($this->SHPFile, pack("NNNNNN", 9994, 0, 0, 0, 0, 0));
      fwrite($this->SHPFile, pack("N", $this->fileLength));
      fwrite($this->SHPFile, pack("V", 1000));
      fwrite($this->SHPFile, pack("V", $this->shapeType));
      fwrite($this->SHPFile, Util::packDouble($this->boundingBox['xmin']));
      fwrite($this->SHPFile, Util::packDouble($this->boundingBox['ymin']));
      fwrite($this->SHPFile, Util::packDouble($this->boundingBox['xmax']));
      fwrite($this->SHPFile, Util::packDouble($this->boundingBox['ymax']));
      fwrite($this->SHPFile, Util::packDouble(isset($this->boundingBox['zmin'])?$this->boundingBox['zmin']:0));
      fwrite($this->SHPFile, Util::packDouble(isset($this->boundingBox['zmax'])?$this->boundingBox['zmax']:0));
      fwrite($this->SHPFile, Util::packDouble(isset($this->boundingBox['mmin'])?$this->boundingBox['mmin']:0));
      fwrite($this->SHPFile, Util::packDouble(isset($this->boundingBox['mmax'])?$this->boundingBox['mmax']:0));

      fwrite($this->SHXFile, pack("NNNNNN", 9994, 0, 0, 0, 0, 0));
      fwrite($this->SHXFile, pack("N", 50 + 4*count($this->records)));
      fwrite($this->SHXFile, pack("V", 1000));
      fwrite($this->SHXFile, pack("V", $this->shapeType));
      fwrite($this->SHXFile, Util::packDouble($this->boundingBox['xmin']));
      fwrite($this->SHXFile, Util::packDouble($this->boundingBox['ymin']));
      fwrite($this->SHXFile, Util::packDouble($this->boundingBox['xmax']));
      fwrite($this->SHXFile, Util::packDouble($this->boundingBox['ymax']));
      fwrite($this->SHXFile, Util::packDouble(isset($this->boundingBox['zmin'])?$this->boundingBox['zmin']:0));
      fwrite($this->SHXFile, Util::packDouble(isset($this->boundingBox['zmax'])?$this->boundingBox['zmax']:0));
      fwrite($this->SHXFile, Util::packDouble(isset($this->boundingBox['mmin'])?$this->boundingBox['mmin']:0));
      fwrite($this->SHXFile, Util::packDouble(isset($this->boundingBox['mmax'])?$this->boundingBox['mmax']:0));
    }

    function _loadRecords() {

      fseek($this->SHPFile, 100);
      while (!feof($this->SHPFile)) {
        $bByte = ftell($this->SHPFile);
        $record = new ShapeRecord(-1);
        $record->loadFromFile($this->SHPFile, $this->DBFFile);
        $eByte = ftell($this->SHPFile);
        if (($eByte <= $bByte) || ($record->lastError != "")) {

          return false;
        }

        $this->records[] = $record;
      }
    }

    function _saveRecords() {

      if (file_exists(str_replace('.*', '.dbf', $this->FileName))) {
        @unlink(str_replace('.*', '.dbf', $this->FileName));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
      }
      if (!($this->DBFFile = @dbase_create(str_replace('.*', '.dbf', $this->FileName), $this->DBFHeader))) {

        return $this->setError(sprintf("It wasn't possible to create the DBase file '%s'", str_replace('.*', '.dbf', $this->FileName)));
      }

      $offset = 50;
      if (is_array($this->records) && (count($this->records) > 0)) {
        reset($this->records);
        while (list($index, $record) = each($this->records)) {
          //Save the record to the .shp file
          $record->saveToFile($this->SHPFile, $this->DBFFile, $index + 1);

          //Save the record to the .shx file
          fwrite($this->SHXFile, pack("N", $offset));
          fwrite($this->SHXFile, pack("N", $record->getContentLength()));
          $offset += (4 + $record->getContentLength());
        }
      }
      @dbase_pack($this->DBFFile);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    function _openSHPFile($toWrite = false) {

      $this->SHPFile = @fopen(str_replace('.*', '.shp', $this->FileName), ($toWrite ? "wb+" : "rb"));
      if (!$this->SHPFile) {
        return $this->setError(sprintf("It wasn't possible to open the Shape file '%s'", str_replace('.*', '.shp', $this->FileName)));
      }

      return TRUE;
    }

    function _closeSHPFile() {

      if ($this->SHPFile) {
        fclose($this->SHPFile);
        $this->SHPFile = NULL;
      }
    }

    function _openSHXFile($toWrite = false) {

      $this->SHXFile = @fopen(str_replace('.*', '.shx', $this->FileName), ($toWrite ? "wb+" : "rb"));
      if (!$this->SHXFile) {
        return $this->setError(sprintf("It wasn't possible to open the Index file '%s'", str_replace('.*', '.shx', $this->FileName)));
      }

      return TRUE;
    }

    function _closeSHXFile() {

      if ($this->SHXFile) {
        fclose($this->SHXFile);
        $this->SHXFile = NULL;
      }
    }

    function _openDBFFile($toWrite = false) {

      $checkFunction = $toWrite ? "is_writable" : "is_readable";
      if (($toWrite) && (!file_exists(str_replace('.*', '.dbf', $this->FileName)))) {
        if (!@dbase_create(str_replace('.*', '.dbf', $this->FileName), $this->DBFHeader)) {

          return $this->setError(sprintf("It wasn't possible to create the DBase file '%s'", str_replace('.*', '.dbf', $this->FileName)));
        }
      }
      if ($checkFunction(str_replace('.*', '.dbf', $this->FileName))) {
        $this->DBFFile = dbase_open(str_replace('.*', '.dbf', $this->FileName), ($toWrite ? 2 : 0));
        if (!$this->DBFFile) {
          return $this->setError(sprintf("It wasn't possible to open the DBase file '%s'", str_replace('.*', '.dbf', $this->FileName)));
        }
      } else {
        return $this->setError(sprintf("It wasn't possible to find the DBase file '%s'", str_replace('.*', '.dbf', $this->FileName)));
      }
      return TRUE;
    }

    function _closeDBFFile() {

      if ($this->DBFFile) {
        dbase_close($this->DBFFile);
        $this->DBFFile = NULL;
      }
    }

    function setError($error) {

      $this->lastError = $error;
      return false;
    }
  }



1			<?php
2			/**
3			* BytesFall ShapeFiles library
4			*
5			* The library implements the 2D variants of the ShapeFile format as defined in
6			* http://www.esri.com/library/whitepapers/pdfs/shapefile.pdf.
7			* The library currently supports reading and editing of ShapeFiles and the
8			* Associated information (DBF file).
9			*
10			* @package bfShapeFiles
11			* @version 0.0.2
12			* @link http://bfshapefiles.sourceforge.net/
13			* @license http://www.gnu.org/licenses/gpl-2.0.html GPLv2-or-later
14			*
15			* Copyright 2006-2007 Ovidio <ovidio AT users.sourceforge.net>
16			*
17			* This program is free software; you can redistribute it and/or
18			* modify it under the terms of the GNU General Public License
19			* as published by the Free Software Foundation.
20			*
21			* This program is distributed in the hope that it will be useful,
22			* but WITHOUT ANY WARRANTY; without even the implied warranty of
23			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24			* GNU General Public License for more details.
25			*
26			* You should have received a copy of the GNU General Public License
27			* along with this program; if not, you can download one from
28			* http://www.gnu.org/copyleft/gpl.html.
29			*
30			*/
31			namespace ShapeFile;
32
33			/**
34			* ShapeFile class
35			*
36			* @package bfShapeFiles
37			*/
38			class ShapeFile {
39			var $FileName;
			0 ignored issues – show Coding Style introduced 2016-06-14 08:02 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$FileName`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...

phpmyadmin / shapefile

Push — master ( 001830...de2f31 )

ShapeFile::addRecord() F

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like