ReportsController::view() - Code Metrics - Inspection of "Fix php 7.1 object return by ORM Entity" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 07e3a8...9561cd )

by William
created 2020-05-29 12:11 UTC
ReportsController::view() A

↳ Parent: ReportsController
Complexity

Conditions	5
Paths	4
Size

Total Lines	40
Code Lines	26
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	22
CRAP Score	5.1588
Importance

Changes
Metric	Value
cc	5
eloc	26
nc	4
nop	1
dl	0
loc	40
ccs	22
cts	27
cp	0.8148
crap	5.1588
rs	9.1928
c	0
b	0
f	0
<?php

/**
 * Reports controller handling reports creation and rendering.
 *
 * phpMyAdmin Error reporting server
 * Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 * @license   https://opensource.org/licenses/mit-license.php MIT License
 *
 * @see      https://www.phpmyadmin.net/
 */

namespace App\Controller;

use Cake\Core\Configure;
use Cake\Http\Exception\NotFoundException;
use Cake\Http\Response;
use Cake\Log\Log;
use Cake\ORM\TableRegistry;
use function __;
use function array_key_exists;
use function array_push;
use function array_unshift;
use function count;
use function json_encode;

/**
 * Reports controller handling reports modification and rendering.
 */
class ReportsController extends AppController
{
    /** @var string */
    public $components = [
        'RequestHandler',
        'OrderSearch',
    ];

    /** @var string */
    public $helpers = [
        'Html',
        'Form',
        'Reports',
        'Incidents',
    ];

    /** @var string */
    public $uses = [
        'Incidents',
        'Reports',
        'Notifications',
        'Developers',
    ];

    public function index(): void
    {
        $this->Reports->recursive = -1;

        $this->set(
            'distinct_statuses',
            $this->findArrayList(
                $this->Reports->find()->select(['status'])->distinct(['status']),
                'status'
            )
        );
        $this->set(
            'distinct_locations',
            $this->findArrayList(
                $this->Reports->find()->select(['location'])
                    ->distinct(['location']),
                'location'
            )
        );
        $this->set(
            'distinct_versions',
            $this->findArrayList($this->Reports->find()->select(['pma_version'])->distinct(['pma_version']), 'pma_version')
        );
        $this->set(
            'distinct_error_names',
            $this->findArrayList($this->Reports->find('all', [
                'fields' => ['error_name'],
                'conditions' => ['error_name !=' => ''],
            ])->distinct(['error_name']), 'error_name')
        );
        $this->set('statuses', $this->Reports->status);
        $this->autoRender = true;
    }

    public function view(?string $reportId): void
    {
        if (empty($reportId)) {
            throw new NotFoundException(__('Invalid Report'));
        }
        $report = $this->Reports->findById($reportId)->toArray();

        if (! $report) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $this->set('report', $report);
        $this->set('project_name', Configure::read('GithubRepoPath'));
        $this->Reports->id = $reportId;
        $this->set('incidents', $this->Reports->getIncidents()->toArray());
        $this->set(
            'incidents_with_description',
            $this->Reports->getIncidentsWithDescription()
        );
        $this->set(
            'incidents_with_stacktrace',
            $this->Reports->getIncidentsWithDifferentStacktrace()
        );
        $this->set('related_reports', $this->Reports->getRelatedReports());
        $this->set('status', $this->Reports->status);
        $this->setSimilarFields($reportId);
        $this->setSimilarFields(/** @scrutinizer ignore-type */ $reportId);

        // if there is an unread notification for this report, then mark it as read
        $current_developer = TableRegistry::getTableLocator()->get('Developers')->
                    findById($this->request->getSession()->read('Developer.id'))->all()->first();

        if (! $current_developer || ! $current_developer['Developer']) {
            return;
        }

        TableRegistry::getTableLocator()->get('Notifications')->deleteAll(
            [
                'developer_id' => $current_developer['Developer']['id'],
                'report_id' => $reportId,
            ],
            false
        TableRegistry::getTableLocator()->get('Notifications')->/** @scrutinizer ignore-call */ deleteAll(
        );
    }

    public function data_tables(): ?Response
    {
        $subquery_params = [
            'fields' => [
                'report_id' => 'report_id',
                'inci_count' => 'COUNT(id)',
            ],
            'group' => 'report_id',
        ];
        $subquery = TableRegistry::getTableLocator()->get('incidents')->find('all', $subquery_params);

        // override automatic aliasing, for proper usage in joins
        $aColumns = [
            'id' => 'id',
            'error_name' => 'error_name',
            'error_message' => 'error_message',
            'location' => 'location',
            'pma_version' => 'pma_version',
            'status' => 'status',
            'exception_type' => 'exception_type',
            'inci_count' => 'inci_count',
        ];

        $searchConditions = $this->OrderSearch->getSearchConditions($aColumns);

        $orderConditions = $this->OrderSearch->getOrder($aColumns);

        $params = [
            'fields' => $aColumns,
            'conditions' => [
                $searchConditions,
                'related_to is NULL',
            ],
            'order' => $orderConditions,
        ];

        $pagedParams = $params;
        $pagedParams['limit'] = (int) $this->request->query('iDisplayLength');
        $pagedParams['limit'] = (int) /** @scrutinizer ignore-deprecated */ $this->request->query('iDisplayLength');
        $pagedParams['offset'] = (int) $this->request->query('iDisplayStart');
        $pagedParams['offset'] = (int) /** @scrutinizer ignore-deprecated */ $this->request->query('iDisplayStart');

        $rows = $this->findAllDataTable(
            $this->Reports->find('all', $pagedParams)->innerJoin(

                ['incidents' => $subquery],
                ['incidents.report_id = Reports.id']
            )
        );
        //$rows = Sanitize::clean($rows);
        $totalFiltered = $this->Reports->find('all', $params)->count();

        // change exception_type from boolean values to strings
        // add incident count for related reports
        $dispRows = [];
        foreach ($rows as $row) {
            $row[5] = $this->Reports->status[$row[5]];
            $row[6] = (int) $row[6] ? 'php' : 'js';
            $input_elem = "<input type='checkbox' name='reports[]' value='"
                . $row[0]
                . "'/>";

            $subquery_params_count = [
                'fields' => ['report_id' => 'report_id'],
            ];
            $subquery_count = TableRegistry::getTableLocator()->get('incidents')->find(
                'all',
                $subquery_params_count
            );

            $params_count = [
                'fields' => ['inci_count' => 'inci_count'],
                'conditions' => [
                    'related_to = ' . $row[0],
                ],
            ];

            $inci_count_related = $this->Reports->find('all', $params_count)->innerJoin(
                ['incidents' => $subquery_count],
                ['incidents.report_id = Reports.related_to']
            )->count();

            $row[7] += $inci_count_related;

            array_unshift($row, $input_elem);
            array_push($dispRows, $row);
        }

        $response = [
            'iTotalRecords' => $this->Reports->find('all')->count(),
            'iTotalDisplayRecords' => $totalFiltered,
            'sEcho' => (int) $this->request->query('sEcho'),
            'sEcho' => (int) /** @scrutinizer ignore-deprecated */ $this->request->query('sEcho'),
            'aaData' => $dispRows,
        ];
        $this->autoRender = false;
        $this->response->body(json_encode($response));
        /** @scrutinizer ignore-deprecated */ $this->response->body(json_encode($response));

        return $this->response;
    }

    public function mark_related_to(?string $reportId): void
    {
        // Only allow POST requests
        $this->request->allowMethod(['post']);

        $relatedTo = $this->request->getData('related_to');
        if (! $reportId
            || ! $relatedTo
            || $reportId === $relatedTo
        ) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $report = $this->Reports->get($reportId);

        if (! $report) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $this->Reports->addToRelatedGroup($report, $relatedTo);

        $flash_class = 'alert alert-success';
        $this->Flash->default(
            'This report has been marked the same as #'
                . $relatedTo,
                . /** @scrutinizer ignore-type */ $relatedTo,
            ['params' => ['class' => $flash_class]]
        );
        $this->redirect('/reports/view/' . $reportId);
    }

    public function unmark_related_to(?string $reportId): void
    {
        // Only allow POST requests
        $this->request->allowMethod(['post']);

        if (! $reportId) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $report = $this->Reports->get($reportId);

        if (! $report) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $this->Reports->removeFromRelatedGroup($report);

        $flash_class = 'alert alert-success';
        $this->Flash->default(
            'This report has been marked as different.',
            ['params' => ['class' => $flash_class]]
        );
        $this->redirect('/reports/view/' . $reportId);
    }

    public function change_state(?string $reportId): void
    {
        if (! $reportId) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $report = $this->Reports->get($reportId);

        if (! $report) {
            throw new NotFoundException(__('Invalid Report'));
        }

        $state = $this->request->data['state'];
        $state = /** @scrutinizer ignore-deprecated */ $this->request->data['state'];
        $newState = null;

        if (array_key_exists($state, $this->Reports->status)) {
            $newState = $this->Reports->status[$state];
        }
        if (! $newState) {
            throw new NotFoundException(__('Invalid State'));
        }
        $report->status = $state;
        $this->Reports->save($report);

        $flash_class = 'alert alert-success';
        $this->Flash->default(
            'The state has been successfully changed.',
            ['params' => ['class' => $flash_class]]
        );
        $this->redirect('/reports/view/' . $reportId);
    }

    /**
     * To carry out mass actions on Reports
     * Currently only to change their statuses.
     * Can be Extended for other mass operations as well.
     * Expects an array of Report Ids as a POST parameter.
     *
     * @return void Nothing
     */
    public function mass_action(): void
    {
        $flash_class = 'alert alert-error';
        $state = $this->request->data['state'];
        $state = /** @scrutinizer ignore-deprecated */ $this->request->data['state'];
        $newState = null;
        if (array_key_exists($state, $this->Reports->status)) {

            $newState = $this->Reports->status[$state];
        }

        if (! $newState) {
            Log::write(
                'error',
                'ERRORED: Invalid param "state" in ReportsController::mass_action()',
                'alert'
            );
            $msg = 'ERROR: Invalid State!!';
        } elseif (count($this->request->data['reports']) === 0) {
        } elseif (count(/** @scrutinizer ignore-deprecated */ $this->request->data['reports']) === 0) {
            $msg = 'No Reports Selected!! Please Select Reports and try again.';
        } else {
            $msg = "Status has been changed to '"
                . $this->request->data['state']
                . /** @scrutinizer ignore-deprecated */ $this->request->data['state']
                . "' for selected Reports!";
            $flash_class = 'alert alert-success';
            foreach ($this->request->data['reports'] as $report_id) {
            foreach (/** @scrutinizer ignore-deprecated */ $this->request->data['reports'] as $report_id) {
                $report = $this->Reports->get($report_id);
                if (! $report) {
                    Log::write(
                        'error',
                        'ERRORED: Invalid report_id in ReportsController::mass_action()',
                        'alert'
                    );
                    $msg = 'ERROR:Invalid Report ID:' . $report_id;
                    $flash_class = 'alert alert-error';
                    break;
                }
                $report->status = $state;
                $this->Reports->save($report);
            }
        }

        $this->Flash->default(
            $msg,
            ['params' => ['class' => $flash_class]]
        );
        $this->redirect('/reports/');
    }

    protected function setSimilarFields(int $id): void
    {
        $this->Reports->id = $id;


        $this->set('columns', TableRegistry::getTableLocator()->get('Incidents')->summarizableFields);
        $relatedEntries = [];

        foreach (TableRegistry::getTableLocator()->get('Incidents')->summarizableFields as $field) {
            [$entriesWithCount, $totalEntries] =
                    $this->Reports->getRelatedByField($field, 25, true);
            $relatedEntries[$field] = $entriesWithCount;
            $this->set("${field}_distinct_count", $totalEntries);
        }
        //error_log(json_encode($relatedEntries));
        $this->set('related_entries', $relatedEntries);
    }

    /**
     * @param array|mixed $results The row
     * @param string      $key     The search in the row
     * @return array Results
     */
    protected function findArrayList($results, string $key): array
    {
        $output = [];
        foreach ($results as $row) {
            $output[] = $row[$key];
        }

        return $output;
    }

    /**
     * @param mixed $results
     * @return array
     */
    protected function findAllDataTable($results): array
    {
        $output = [];
        foreach ($results as $row) {
            $output_row = [];
            $row = $row->toArray();
            foreach ($row as $key => $value) {
                $output_row[] = $value;
            }
            $output[] = $output_row;
        }

        return $output;
    }
}

phpmyadmin / error-reporting-server

Push — master ( 07e3a8...9561cd )

ReportsController::view() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
