OrderSearchComponent::getSearchConditions() - Code Metrics - Inspection of "Add tests for shells" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#168)

by Deven

created 2017-06-30 15:51 UTC

OrderSearchComponent::getSearchConditions() B

↳ Parent: OrderSearchComponent

Complexity

Conditions	6
Paths	6

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	22
rs	8.6737
c	0
b	0
f	0
ccs	11
cts	11
cp	1
cc	6
eloc	11
nc	6
nop	1
crap	6

<?php

/* vim: set expandtab sw=4 ts=4 sts=4: */
/**
 * Order and search component handling generation of ordering and
 * searching conditions in loading data tables.
 *
 * phpMyAdmin Error reporting server
 * Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 * @license   https://opensource.org/licenses/mit-license.php MIT License
 *
 * @see      https://www.phpmyadmin.net/
 */

namespace App\Controller\Component;

use Cake\Controller\Component;

/**
 * Github api component handling comunication with github.
 */
class OrderSearchComponent extends Component
{
    /**
     * Indexes are +1'ed because first column is of checkboxes
     * and hence it should be ingnored.
     *
     * @param string[] $aColumns
     *
     * @return array
     */
    public function getSearchConditions($aColumns)
    {
        $searchConditions = array('OR' => array());
        $keys = array_keys($aColumns);

        if ($this->request->query('sSearch') != '') {

            for ($i = 0; $i < count($aColumns); ++$i) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                if ($this->request->query('bSearchable_' . ($i + 1)) == 'true') {

                    $searchConditions['OR'][] = array($aColumns[$keys[$i]] . ' LIKE' => '%' . $this->request->query('sSearch') . '%');

                }
            }
        }

        /* Individual column filtering */
        for ($i = 0; $i < count($aColumns); ++$i) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            if ($this->request->query('sSearch_' . ($i + 1)) != '') {

                $searchConditions[] = array($aColumns[$keys[$i]] . ' LIKE' => $this->request->query('sSearch_' . ($i + 1)));

            }
        }

        return $searchConditions;
    }

    /**
     * @param string[] $aColumns
     *
     * @return array
     */
    public function getOrder($aColumns)
    {
        if ($this->request->query('iSortCol_0') != null) {

            $order = array();
            //Seems like we need to sort with only one column each time, so no need to loop
            $sort_column_index = intval($this->request->query('iSortCol_0'));


            $keys = array_keys($aColumns);

            if ($sort_column_index > 0
                && $this->request->query('bSortable_' . $sort_column_index) == 'true'

            ) {
                $order[$aColumns[$keys[$sort_column_index - 1]]] = $this->request->query('sSortDir_0');

            }

            return $order;
        }

        return null;
    }
}


1		<?php
2
3		/* vim: set expandtab sw=4 ts=4 sts=4: */
4		/**
5		* Order and search component handling generation of ordering and
6		* searching conditions in loading data tables.
7		*
8		* phpMyAdmin Error reporting server
9		* Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
10		*
11		* Licensed under The MIT License
12		* For full copyright and license information, please see the LICENSE.txt
13		* Redistributions of files must retain the above copyright notice.
14		*
15		* @copyright Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
16		* @license https://opensource.org/licenses/mit-license.php MIT License
17		*
18		* @see https://www.phpmyadmin.net/
19		*/
20
21		namespace App\Controller\Component;
22
23		use Cake\Controller\Component;
24
25		/**
26		* Github api component handling comunication with github.
27		*/
28		class OrderSearchComponent extends Component
29		{
30		/**
31		* Indexes are +1'ed because first column is of checkboxes
32		* and hence it should be ingnored.
33		*
34		* @param string[] $aColumns
35		*
36		* @return array
37		*/
38	1	public function getSearchConditions($aColumns)
39		{
40	1	$searchConditions = array('OR' => array());
41	1	$keys = array_keys($aColumns);
42
43	1	if ($this->request->query('sSearch') != '') {
		0 ignored issues – show Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
44	1	for ($i = 0; $i < count($aColumns); ++$i) {
		0 ignored issues – show Performance Best Practice introduced 2016-01-30 17:10 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
45	1	if ($this->request->query('bSearchable_' . ($i + 1)) == 'true') {
		0 ignored issues – show Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
46	1	$searchConditions['OR'][] = array($aColumns[$keys[$i]] . ' LIKE' => '%' . $this->request->query('sSearch') . '%');
		0 ignored issues – show Deprecated Code introduced 2017-05-07 08:45 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-05-07 08:46 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
47		}
48		}
49		}
50
51		/* Individual column filtering */
52	1	for ($i = 0; $i < count($aColumns); ++$i) {
		0 ignored issues – show Performance Best Practice introduced 2017-05-07 08:46 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
53	1	if ($this->request->query('sSearch_' . ($i + 1)) != '') {
		0 ignored issues – show Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
54	1	$searchConditions[] = array($aColumns[$keys[$i]] . ' LIKE' => $this->request->query('sSearch_' . ($i + 1)));
		0 ignored issues – show Deprecated Code introduced 2017-05-07 08:46 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-05-07 08:46 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
55		}
56		}
57
58	1	return $searchConditions;
59		}
60
61		/**
62		* @param string[] $aColumns
63		*
64		* @return array
65		*/
66	1	public function getOrder($aColumns)
67		{
68	1	if ($this->request->query('iSortCol_0') != null) {
		0 ignored issues – show Bug introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->request->query('iSortCol_0')` of type `array\|null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `!==` instead. Loading history... Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
69	1	$order = array();
70		//Seems like we need to sort with only one column each time, so no need to loop
71	1	$sort_column_index = intval($this->request->query('iSortCol_0'));
		0 ignored issues – show Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
72
73	1	$keys = array_keys($aColumns);
74
75	1	if ($sort_column_index > 0
76	1	&& $this->request->query('bSortable_' . $sort_column_index) == 'true'
		0 ignored issues – show Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
77		) {
78		$order[$aColumns[$keys[$sort_column_index - 1]]] = $this->request->query('sSortDir_0');
		0 ignored issues – show Deprecated Code introduced 2017-02-22 10:31 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component::$request` has been deprecated with message: 3.4.0 Storing references to the request is deprecated. Use Component::getController() or callback $event->getSubject() to access the controller & request instead. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history... Deprecated Code introduced 2017-03-12 05:11 UTC by Report Bug Copy Issue Report The method `Cake\Http\ServerRequest::query()` has been deprecated with message: 3.4.0 Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
79		}
80
81	1	return $order;
82		}
83
84	1	return null;
85		}
86		}
87

phpmyadmin / error-reporting-server

Pull Request — master (#168)

OrderSearchComponent::getSearchConditions() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like