ReportsControllerTest::testDataTables() - Code Metrics - Inspection of "Remove composer.phar from Git" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c9c188...858b2f )

by Deven

created 2017-05-15 03:48 UTC

ReportsControllerTest::testDataTables() A

↳ Parent: ReportsControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	9.4109
c	0
b	0
f	0
cc	1
eloc	38
nc	1
nop	0

How to fix Long Method

<?php

namespace App\Test\TestCase\Controller;

use Cake\ORM\TableRegistry;
use Cake\TestSuite\IntegrationTestCase;

class ReportsControllerTest extends IntegrationTestCase
{
    public $fixtures = array(
        'app.notifications',
        'app.developers',
        'app.reports',
        'app.incidents',
    );

    public function setUp()
    {
        $this->Reports = TableRegistry::get('Reports');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->session(array('Developer.id' => 1));
    }

    public function testIndex()
    {
        $this->get('/reports');
        $this->assertEquals(array('3.8', '4.0'), $this->viewVariable('distinct_versions'));
        $this->assertEquals(array('new'), $this->viewVariable('distinct_statuses'));
        $this->assertEquals(array('error1', 'error2'),
                $this->viewVariable('distinct_error_names'));
    }

    public function testView()
    {
        $this->get('/reports/view/1');

        $this->assertEquals(1, $this->viewVariable('report')[0]['id']);
        $this->assertEquals('error2', $this->viewVariable('report')[0]['error_name']);

        $this->assertNotEmpty($this->viewVariable('project_name'));
        $this->assertNotEmpty($this->viewVariable('columns'));

        $this->assertNotEmpty($this->viewVariable('related_entries'));
        $this->assertEquals(count($this->viewVariable('columns')),
                count($this->viewVariable('related_entries')));

        foreach ($this->viewVariable('columns') as $column) {
            $this->assertNotEmpty($this->viewVariable("${column}_distinct_count"));
        }

        $this->assertNotEmpty($this->viewVariable('incidents'));
        $this->assertEquals(1, count($this->viewVariable('incidents')));

        $this->assertNotEmpty($this->viewVariable('incidents_with_description'));
        $this->assertEquals(1, count($this->viewVariable('incidents_with_description')));

        $this->assertNotEmpty($this->viewVariable('incidents_with_stacktrace'));
        $this->assertEquals(1, count($this->viewVariable('incidents_with_stacktrace')));

        $this->assertNotEmpty($this->viewVariable('related_reports'));
        $this->assertEquals(1, count($this->viewVariable('related_reports')));

        $this->get('/reports/view/3');
        $this->assertResponseContains('Invalid Report');
       // $this->assertResponseOk();
        //$this->setExpectedException('NotFoundException');
        //	$this->get('/reports/view');
    }

    public function testDataTables()
    {
        $this->get('/reports/data_tables?sEcho=1&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 3,
            'iTotalDisplayRecords' => 3,
            'sEcho' => 1,
            'aaData' => array(
                array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
                array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
                array("<input type='checkbox' name='reports[]' value='4'/>", 4, 'error1', 'Lorem ipsum dolor sit amet', '3.8', 'New', 'js', '2'),
            ),
        );
        $this->assertEquals($expected, json_decode($this->_response->body(), true));

        $this->get('/reports/data_tables?sEcho=1&sSearch=error2&bSearchable_2=true&iSortCol_0=0&sSortDir_0=desc&bSortable_0=true&iSortingCols=2&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 3,
            'iTotalDisplayRecords' => 2,
            'sEcho' => 1,
            'aaData' => array(
                array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
                array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
            ),
        );
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals($expected, $result);

        $this->get('/reports/data_tables?sEcho=1&sSearch_1=1&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 3,
            'iTotalDisplayRecords' => 1,
            'sEcho' => 1,
            'aaData' => array(
                array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
            ),
        );
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals($expected, $result);

        $this->get('/reports/data_tables?sEcho=1&sSearch_1=error&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 3,
            'iTotalDisplayRecords' => 0,
            'sEcho' => 1,
            'aaData' => array(
            ),
        );
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals($expected, $result);
    }

    public function testMarkRelatedTo() {
        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(1, $incidents->count());

        $this->post(
            '/reports/mark_related_to/2',
            ['related_to' => 4]
        );

        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(3, $incidents->count());

        $this->_testUnmarkRelatedTo();
    }


    /**
     * Don't run this as a separate test,
     * as the fixture tables are re-created and
     * we lose the previous related_to updations.
     *
     * So, call at the end of testMarkRelatedTo()
     */
    private function _testUnmarkRelatedTo() {
        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(3, $incidents->count());

        $this->post('/reports/unmark_related_to/2');

        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(1, $incidents->count());
    }
}


1		<?php
2
3		namespace App\Test\TestCase\Controller;
4
5		use Cake\ORM\TableRegistry;
6		use Cake\TestSuite\IntegrationTestCase;
7
8		class ReportsControllerTest extends IntegrationTestCase
9		{
10		public $fixtures = array(
11		'app.notifications',
12		'app.developers',
13		'app.reports',
14		'app.incidents',
15		);
16
17		public function setUp()
18		{
19		$this->Reports = TableRegistry::get('Reports');
		0 ignored issues – show Bug introduced 2015-12-24 09:14 UTC by Report Bug Copy Issue Report The property `Reports` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20		$this->session(array('Developer.id' => 1));
21		}
22
23		public function testIndex()
24		{
25		$this->get('/reports');
26		$this->assertEquals(array('3.8', '4.0'), $this->viewVariable('distinct_versions'));
27		$this->assertEquals(array('new'), $this->viewVariable('distinct_statuses'));
28		$this->assertEquals(array('error1', 'error2'),
29		$this->viewVariable('distinct_error_names'));
30		}
31
32		public function testView()
33		{
34		$this->get('/reports/view/1');
35
36		$this->assertEquals(1, $this->viewVariable('report')[0]['id']);
37		$this->assertEquals('error2', $this->viewVariable('report')[0]['error_name']);
38
39		$this->assertNotEmpty($this->viewVariable('project_name'));
40		$this->assertNotEmpty($this->viewVariable('columns'));
41
42		$this->assertNotEmpty($this->viewVariable('related_entries'));
43		$this->assertEquals(count($this->viewVariable('columns')),
44		count($this->viewVariable('related_entries')));
45
46		foreach ($this->viewVariable('columns') as $column) {
47		$this->assertNotEmpty($this->viewVariable("${column}_distinct_count"));
48		}
49
50		$this->assertNotEmpty($this->viewVariable('incidents'));
51		$this->assertEquals(1, count($this->viewVariable('incidents')));
52
53		$this->assertNotEmpty($this->viewVariable('incidents_with_description'));
54		$this->assertEquals(1, count($this->viewVariable('incidents_with_description')));
55
56		$this->assertNotEmpty($this->viewVariable('incidents_with_stacktrace'));
57		$this->assertEquals(1, count($this->viewVariable('incidents_with_stacktrace')));
58
59		$this->assertNotEmpty($this->viewVariable('related_reports'));
60		$this->assertEquals(1, count($this->viewVariable('related_reports')));
61
62		$this->get('/reports/view/3');
63		$this->assertResponseContains('Invalid Report');
64		// $this->assertResponseOk();
65		//$this->setExpectedException('NotFoundException');
66		// $this->get('/reports/view');
67		}
68
69		public function testDataTables()
70		{
71		$this->get('/reports/data_tables?sEcho=1&iDisplayLength=25');
72		$expected = array(
73		'iTotalRecords' => 3,
74		'iTotalDisplayRecords' => 3,
75		'sEcho' => 1,
76		'aaData' => array(
77		array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
78		array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
79		array("<input type='checkbox' name='reports[]' value='4'/>", 4, 'error1', 'Lorem ipsum dolor sit amet', '3.8', 'New', 'js', '2'),
80		),
81		);
82		$this->assertEquals($expected, json_decode($this->_response->body(), true));
83
84		$this->get('/reports/data_tables?sEcho=1&sSearch=error2&bSearchable_2=true&iSortCol_0=0&sSortDir_0=desc&bSortable_0=true&iSortingCols=2&iDisplayLength=25');
85		$expected = array(
86		'iTotalRecords' => 3,
87		'iTotalDisplayRecords' => 2,
88		'sEcho' => 1,
89		'aaData' => array(
90		array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
91		array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
92		),
93		);
94		$result = json_decode($this->_response->body(), true);
95		$this->assertEquals($expected, $result);
96
97		$this->get('/reports/data_tables?sEcho=1&sSearch_1=1&iDisplayLength=25');
98		$expected = array(
99		'iTotalRecords' => 3,
100		'iTotalDisplayRecords' => 1,
101		'sEcho' => 1,
102		'aaData' => array(
103		array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', '4.0', 'New', 'js', '1'),
104		),
105		);
106		$result = json_decode($this->_response->body(), true);
107		$this->assertEquals($expected, $result);
108
109		$this->get('/reports/data_tables?sEcho=1&sSearch_1=error&iDisplayLength=25');
110		$expected = array(
111		'iTotalRecords' => 3,
112		'iTotalDisplayRecords' => 0,
113		'sEcho' => 1,
114		'aaData' => array(
115		),
116		);
117		$result = json_decode($this->_response->body(), true);
118		$this->assertEquals($expected, $result);
119		}
120
121	View Code Duplication	public function testMarkRelatedTo() {
122		$this->Reports->id = 2;
123		$incidents = $this->Reports->getIncidents();
124		$this->assertEquals(1, $incidents->count());
125
126		$this->post(
127		'/reports/mark_related_to/2',
128		['related_to' => 4]
129		);
130
131		$this->Reports->id = 2;
132		$incidents = $this->Reports->getIncidents();
133		$this->assertEquals(3, $incidents->count());
134
135		$this->_testUnmarkRelatedTo();
136		}
137
138
139		/**
140		* Don't run this as a separate test,
141		* as the fixture tables are re-created and
142		* we lose the previous related_to updations.
143		*
144		* So, call at the end of testMarkRelatedTo()
145		*/
146	View Code Duplication	private function _testUnmarkRelatedTo() {
147		$this->Reports->id = 2;
148		$incidents = $this->Reports->getIncidents();
149		$this->assertEquals(3, $incidents->count());
150
151		$this->post('/reports/unmark_related_to/2');
152
153		$this->Reports->id = 2;
154		$incidents = $this->Reports->getIncidents();
155		$this->assertEquals(1, $incidents->count());
156		}
157		}
158

phpmyadmin / error-reporting-server

Push — master ( c9c188...858b2f )

ReportsControllerTest::testDataTables() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like