IncidentsController::_sendNotificationMail() - Code Metrics - Inspection of "Some minor improvements" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1aba9a...2acbdd )

by William

created 2019-07-02 00:00 UTC

IncidentsController::_sendNotificationMail() A

↳ Parent: IncidentsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	13
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	18
ccs	0
cts	16
cp	0
crap	2
rs	9.8333

<?php

/* vim: set expandtab sw=4 ts=4 sts=4: */
/**
 * Incidents controller handling incident creation and rendering.
 *
 * phpMyAdmin Error reporting server
 * Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 * @license   https://opensource.org/licenses/mit-license.php MIT License
 *
 * @see      https://www.phpmyadmin.net/
 */

namespace App\Controller;

use Cake\Core\Configure;
use Cake\Http\Exception\NotFoundException;
use Cake\ORM\TableRegistry;

/**
 * Incidents controller handling incident creation and rendering.
 */
class IncidentsController extends AppController
{
    public $uses = [
        'Incident',
        'Notification',
    ];

    public $components = ['Mailer'];

    public function create()
    {
        // Only allow POST requests
        $this->request->allowMethod(['post']);

        $bugReport = $this->request->input('json_decode', true);
        $result = $this->Incidents->createIncidentFromBugReport($bugReport);


        if (count($result['incidents']) > 0
            && ! in_array(false, $result['incidents'])
        ) {
            $response = [
                'success' => true,
                'message' => 'Thank you for your submission',
                'incident_id' => $result['incidents'],        // Return a list of incident ids.
            ];
        } else {
            $response = [
                'success' => false,
                'message' => 'There was a problem with your submission.',
            ];
        }
        $this->autoRender = false;
        $this->response->header([
        /** @scrutinizer ignore-deprecated */ $this->response->header([
            'Content-Type' => 'application/json',
            'X-Content-Type-Options' => 'nosniff',
        ]);
        $this->response->body(
        /** @scrutinizer ignore-deprecated */ $this->response->body(
            json_encode($response, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)
        );

        // For all the newly added reports,
        // send notification emails
        foreach ($result['reports'] as $report_id) {
            $this->_sendNotificationMail($report_id);
        }

        return $this->response;
    }

    public function json($id)
    {
        if (! isset($id) || ! $id) {
            throw new NotFoundException(__('Invalid Incident'));
        }

        $this->Incidents->recursive = -1;

        $incident = $this->Incidents->findById($id)->all()->first();
        if (! $incident) {
            throw new NotFoundException(__('Invalid Incident'));
        }

        $incident['full_report'] =
            json_decode($incident['full_report'], true);
        $incident['stacktrace'] =
            json_decode($incident['stacktrace'], true);

        $this->autoRender = false;
        $this->response->body(json_encode($incident, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES));
        /** @scrutinizer ignore-deprecated */ $this->response->body(json_encode($incident, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES));

        return $this->response;
    }

    public function view($incidentId)
    {
        if (! isset($incidentId) || ! $incidentId) {
            throw new NotFoundException(__('Invalid Incident'));
        }

        $incident = $this->Incidents->findById($incidentId)->all()->first();

        if (! $incident) {
            throw new NotFoundException(__('Invalid Incident'));
        }

        $incident['full_report'] =
            json_decode($incident['full_report'], true);
        $incident['stacktrace'] =
            json_decode($incident['stacktrace'], true);

        $this->set('incident', $incident);
    }

    private function _sendNotificationMail($reportId)
    {
        $this->Reports = TableRegistry::get('Reports');
        $this->Reports = /** @scrutinizer ignore-deprecated */ TableRegistry::get('Reports');
        $report = $this->Reports->findById($reportId)->all()->first()->toArray();
        $this->Reports->id = $reportId;


        $viewVars = [
            'report' => $report,
            'project_name' => Configure::read('GithubRepoPath'),
            'incidents' => $this->Reports->getIncidents()->toArray(),
            'incidents_with_description' => $this->Reports->getIncidentsWithDescription(),
            'incidents_with_stacktrace' => $this->Reports->getIncidentsWithDifferentStacktrace(),
            'related_reports' => $this->Reports->getRelatedReports(),
            'status' => $this->Reports->status
        ];
        $viewVars = array_merge($viewVars, $this->_getSimilarFields($reportId));

        $this->Mailer->sendReportMail($viewVars);

    }

    protected function _getSimilarFields($id)
    {
        $this->Reports->id = $id;

        $viewVars = [
            'columns' => TableRegistry::get('Incidents')->summarizableFields,
            'columns' => /** @scrutinizer ignore-deprecated */ TableRegistry::get('Incidents')->summarizableFields,
        ];
        $relatedEntries = [];

        foreach (TableRegistry::get('Incidents')->summarizableFields as $field) {
        foreach (/** @scrutinizer ignore-deprecated */ TableRegistry::get('Incidents')->summarizableFields as $field) {
            list($entriesWithCount, $totalEntries) =
                    $this->Reports->getRelatedByField($field, 25, true);
            $relatedEntries[$field] = $entriesWithCount;
            $viewVars["${field}_distinct_count"] = $totalEntries;
        }

        $viewVars['related_entries'] = $relatedEntries;

        return $viewVars;
    }
}


phpmyadmin / error-reporting-server

Push — master ( 1aba9a...2acbdd )

IncidentsController::_sendNotificationMail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like