IncidentsControllerTest::testCreate() - Code Metrics - Inspection of "Send Email Notifications on newly added reports" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#153)

by Deven

created 2017-06-08 16:58 UTC

IncidentsControllerTest::testCreate() A

↳ Parent: IncidentsControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	62
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	62
rs	9.4743
cc	1
eloc	43
nc	1
nop	0

How to fix Long Method

<?php

namespace App\Test\TestCase\Controller;

use Cake\Core\Configure;
use Cake\ORM\TableRegistry;
use Cake\TestSuite\IntegrationTestCase;

class IncidentsControllerTest extends IntegrationTestCase
{
    public $fixtures = array(
        'app.notifications',
        'app.developers',
        'app.reports',
        'app.incidents',
    );

    public function setUp()
    {
        $this->Incidents = TableRegistry::get('Incidents');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //$Session = new SessionComponent(new ComponentRegistry());
        $this->session(array('Developer.id' => 1));
        $this->Reports = TableRegistry::get('Reports');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function testView()
    {
        $this->get('/incidents/view/1');

        $this->assertNotEmpty($this->viewVariable('incident'));
        $this->assertInternalType('array',
                $this->viewVariable('incident')['stacktrace']);
        $this->assertInternalType('array',
                $this->viewVariable('incident')['full_report']);
    }

    public function testJson()
    {
        $this->get('/incidents/json/1');
        $incident = json_decode($this->_response->body(), true);
        $expected = array(
                'id' => 1,
                'error_name' => 'Lorem ipsum dolor sit amet',
                'error_message' => 'Lorem ipsum dolor sit amet',
                'pma_version' => 'Lorem ipsum dolor sit amet',
                'php_version' => '5.5',
                'browser' => 'Lorem ipsum dolor sit amet',
                'user_os' => 'Lorem ipsum dolor sit amet',
                'locale' => 'Lorem ipsum dolor sit amet',
                'server_software' => 'Lorem ipsum dolor sit amet',
                'stackhash' => 'hash1',
                'configuration_storage' => 'Lorem ipsum dolor sit amet',
                'script_name' => 'Lorem ipsum dolor sit amet',
                'steps' => 'Lorem ipsum dolor sit amet',
                'stacktrace' => array(array('context' => array('test'))),
                'full_report' => array(
                    'pma_version' => '',
          'php_version' => '',
          'browser_name' => '',
          'browser_version' => '',
          'user_agent_string' => '',
          'server_software' => '',
          'locale' => '',
          'exception' => array('uri' => ''),
          'configuration_storage' => '',
          'microhistory' => '',
                ),
                'report_id' => 1,
                'created' => '2013-08-29T18:10:01',
                'modified' => '2013-08-29T18:10:01',
                'exception_type' => null,
        );

        $this->assertEquals($expected, $incident);
    }

    public function testCreate()
    {
        $bugReport = file_get_contents(TESTS . 'Fixture' . DS . 'report_js.json');
        $bugReportDecoded = json_decode($bugReport, true);
        $this->configRequest(array('input' => $bugReport));
        $this->post('/incidents/create');

        $report = $this->Reports->find('all',
            array('order' => 'Reports.created desc'))->all()->first();
        $subject = 'A new report has been submitted '
            . 'on the Error Reporting Server: '
            . $report['id'];

        // Test notification email
        $emailContent = Configure::read('test_transport_email');

        $this->assertEquals('[email protected]', $emailContent['headers']['From']);
        $this->assertEquals('[email protected]', $emailContent['headers']['To']);
        $this->assertEquals($subject, $emailContent['headers']['Subject']);

        $this->post('/incidents/create');

        $report = $this->Reports->find('all',
                array('order' => 'Reports.created desc'))->all()->first();
        //$report = $report->hydrate(false)->toArray();
        $this->Reports->id = $report['id'];
        $incidents = $this->Reports->getIncidents();
        $incidents = $incidents->hydrate(false)->toArray();
        $this->assertEquals(2, count($incidents));
        $this->assertEquals($bugReportDecoded['exception']['message'],
                $report['error_message']);
        $this->assertEquals($bugReportDecoded['exception']['name'],
                $report['error_name']);
        $this->assertEquals($bugReportDecoded['pma_version'],
                $report['pma_version']);
        $this->configRequest(array('input' => array()));
        $this->post('/incidents/create');
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals(false, $result['success']);



        // Test invalid Notification email configuration
        Configure::write('NotificationEmailsTo', '');

        $bugReport = file_get_contents(TESTS . 'Fixture' . DS . 'report_php.json');
        $bugReportDecoded = json_decode($bugReport, true);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $this->configRequest(array('input' => $bugReport));
        $this->post('/incidents/create');

        $report = $this->Reports->find('all',
            array('order' => 'Reports.created desc'))->all()->first();
        $subject = 'A new report has been submitted '
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            . 'on the Error Reporting Server: '
            . $report['id'];

        $emailContent = Configure::read('test_transport_email');

        // Since no email sent
        $this->assertEquals(null, $emailContent);

    }
}


1			<?php
2
3			namespace App\Test\TestCase\Controller;
4
5			use Cake\Core\Configure;
6			use Cake\ORM\TableRegistry;
7			use Cake\TestSuite\IntegrationTestCase;
8
9			class IncidentsControllerTest extends IntegrationTestCase
10			{
11			public $fixtures = array(
12			'app.notifications',
13			'app.developers',
14			'app.reports',
15			'app.incidents',
16			);
17
18			public function setUp()
19			{
20			$this->Incidents = TableRegistry::get('Incidents');
			0 ignored issues – show Bug introduced 2015-12-24 09:14 UTC by Report Bug Copy Issue Report The property `Incidents` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			//$Session = new SessionComponent(new ComponentRegistry());
22			$this->session(array('Developer.id' => 1));
23			$this->Reports = TableRegistry::get('Reports');
			0 ignored issues – show Bug introduced 2015-12-24 09:14 UTC by Report Bug Copy Issue Report The property `Reports` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			}
25
26			public function testView()
27			{
28			$this->get('/incidents/view/1');
29
30			$this->assertNotEmpty($this->viewVariable('incident'));
31			$this->assertInternalType('array',
32			$this->viewVariable('incident')['stacktrace']);
33			$this->assertInternalType('array',
34			$this->viewVariable('incident')['full_report']);
35			}
36
37			public function testJson()
38			{
39			$this->get('/incidents/json/1');
40			$incident = json_decode($this->_response->body(), true);
41			$expected = array(
42			'id' => 1,
43			'error_name' => 'Lorem ipsum dolor sit amet',
44			'error_message' => 'Lorem ipsum dolor sit amet',
45			'pma_version' => 'Lorem ipsum dolor sit amet',
46			'php_version' => '5.5',
47			'browser' => 'Lorem ipsum dolor sit amet',
48			'user_os' => 'Lorem ipsum dolor sit amet',
49			'locale' => 'Lorem ipsum dolor sit amet',
50			'server_software' => 'Lorem ipsum dolor sit amet',
51			'stackhash' => 'hash1',
52			'configuration_storage' => 'Lorem ipsum dolor sit amet',
53			'script_name' => 'Lorem ipsum dolor sit amet',
54			'steps' => 'Lorem ipsum dolor sit amet',
55			'stacktrace' => array(array('context' => array('test'))),
56			'full_report' => array(
57			'pma_version' => '',
58			'php_version' => '',
59			'browser_name' => '',
60			'browser_version' => '',
61			'user_agent_string' => '',
62			'server_software' => '',
63			'locale' => '',
64			'exception' => array('uri' => ''),
65			'configuration_storage' => '',
66			'microhistory' => '',
67			),
68			'report_id' => 1,
69			'created' => '2013-08-29T18:10:01',
70			'modified' => '2013-08-29T18:10:01',
71			'exception_type' => null,
72			);
73
74			$this->assertEquals($expected, $incident);
75			}
76
77			public function testCreate()
78			{
79			$bugReport = file_get_contents(TESTS . 'Fixture' . DS . 'report_js.json');
80			$bugReportDecoded = json_decode($bugReport, true);
81			$this->configRequest(array('input' => $bugReport));
82			$this->post('/incidents/create');
83
84			$report = $this->Reports->find('all',
85			array('order' => 'Reports.created desc'))->all()->first();
86			$subject = 'A new report has been submitted '
87			. 'on the Error Reporting Server: '
88			. $report['id'];
89
90			// Test notification email
91			$emailContent = Configure::read('test_transport_email');
92
93			$this->assertEquals('[email protected]', $emailContent['headers']['From']);
94			$this->assertEquals('[email protected]', $emailContent['headers']['To']);
95			$this->assertEquals($subject, $emailContent['headers']['Subject']);
96
97			$this->post('/incidents/create');
98
99			$report = $this->Reports->find('all',
100			array('order' => 'Reports.created desc'))->all()->first();
101			//$report = $report->hydrate(false)->toArray();
102			$this->Reports->id = $report['id'];
103			$incidents = $this->Reports->getIncidents();
104			$incidents = $incidents->hydrate(false)->toArray();
105			$this->assertEquals(2, count($incidents));
106			$this->assertEquals($bugReportDecoded['exception']['message'],
107			$report['error_message']);
108			$this->assertEquals($bugReportDecoded['exception']['name'],
109			$report['error_name']);
110			$this->assertEquals($bugReportDecoded['pma_version'],
111			$report['pma_version']);
112			$this->configRequest(array('input' => array()));
113			$this->post('/incidents/create');
114			$result = json_decode($this->_response->body(), true);
115			$this->assertEquals(false, $result['success']);
116
117
118
119			// Test invalid Notification email configuration
120			Configure::write('NotificationEmailsTo', '');
121
122			$bugReport = file_get_contents(TESTS . 'Fixture' . DS . 'report_php.json');
123			$bugReportDecoded = json_decode($bugReport, true);
			0 ignored issues – show Unused Code introduced 2017-06-08 16:38 UTC by Report Bug Copy Issue Report `$bugReportDecoded` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
124			$this->configRequest(array('input' => $bugReport));
125			$this->post('/incidents/create');
126
127			$report = $this->Reports->find('all',
128			array('order' => 'Reports.created desc'))->all()->first();
129			$subject = 'A new report has been submitted '
			0 ignored issues – show Unused Code introduced 2017-06-08 16:38 UTC by Report Bug Copy Issue Report `$subject` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
130			. 'on the Error Reporting Server: '
131			. $report['id'];
132
133			$emailContent = Configure::read('test_transport_email');
134
135			// Since no email sent
136			$this->assertEquals(null, $emailContent);
137
138			}
139			}
140

phpmyadmin / error-reporting-server

Pull Request — master (#153)

IncidentsControllerTest::testCreate() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like