App\Test\TestCase\Model\Table\DevelopersTableTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	tearDown()	0	6	1
A	testSaveFromGithub()	0	55	3

<?php
/* vim: set expandtab sw=4 ts=4 sts=4: */

/**
 * Tests for Developer Table model
 *
 * phpMyAdmin Error reporting server
 * Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 * @license   https://opensource.org/licenses/mit-license.php MIT License
 *
 * @see      https://www.phpmyadmin.net/
 */
namespace App\Test\TestCase\Model\Table;

use App\Model\Table\DevelopersTable;
use Cake\ORM\TableRegistry;
use Cake\TestSuite\TestCase;

/**
 * App\Model\Table\DevelopersTable Test Case
 */
class DevelopersTableTest extends TestCase
{

    /**
     * Test subject
     *
     * @var \App\Model\Table\DevelopersTable
     */
    public $Developers;

    /**
     * Fixtures
     *
     * @var array
     */
    public $fixtures = [
        'app.developers'
    ];

    /**
     * setUp method
     *
     * @return void
     */
    public function setUp()
    {
        parent::setUp();
        $this->Developers = TableRegistry::get('Developers');
    }

    /**
     * tearDown method
     *
     * @return void
     */
    public function tearDown()
    {
        unset($this->Developers);

        parent::tearDown();
    }

    /**
     * Test saveFromGithub method
     *
     * @return void
     */
    public function testSaveFromGithub()
    {
        $i = 0;
        while (1) {
            try {
                $i++;
                $savedDeveloper = $this->Developers->get($i);

$savedDeveloper is not used, you could remove the assignment.

            } catch (\Cake\Datasource\Exception\RecordNotFoundException $e) {
                break;
            }
        }

        $nextId = $i;

        $githubInfo = array(
            'login' => 'pma-bot',
            'id' => 1231231,
            'gravatar_id' => '',
            'url' => 'https://api.github.com/users/pma-bot',
            'name' => 'PMA BOT',
            'email' => 'pma-bot@phpmyadmin.net',
            'has_commit_access' => 0
        );
        $developer = $this->Developers->newEntity();
        $access_token = 'abc';

        $this->Developers->saveFromGithub($githubInfo, $access_token, $developer);

        $savedDeveloper = $this->Developers->get($nextId);
        $this->assertNotEquals(null, $savedDeveloper);
        $this->assertEquals(1231231, $savedDeveloper->github_id);

Accessing github_id on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals('PMA BOT', $savedDeveloper->full_name);

Accessing full_name on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals('pma-bot@phpmyadmin.net', $savedDeveloper->email);

Accessing email on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals(false, $savedDeveloper->has_commit_access);

Accessing has_commit_access on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $updatedGithubInfo = array(
            'login' => 'pma-bot',
            'id' => 1231231,
            'gravatar_id' => '',
            'url' => 'https://api.github.com/users/pma-bot',
            'name' => 'PMA BOT',
            'email' => 'pma-bot@phpmyadmin.net',
            'has_commit_access' => 1 // changed
        );

        $this->Developers->saveFromGithub($updatedGithubInfo, $access_token, $developer);

        $savedDeveloper = $this->Developers->get($nextId);
        $this->assertNotEquals(null, $savedDeveloper);
        $this->assertEquals(1231231, $savedDeveloper->github_id);

Accessing github_id on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals('PMA BOT', $savedDeveloper->full_name);

Accessing full_name on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals('pma-bot@phpmyadmin.net', $savedDeveloper->email);

Accessing email on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals(true, $savedDeveloper->has_commit_access);

Accessing has_commit_access on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}