ReportsControllerTest - Code Metrics - Inspection of "Add tests for NotificationsController Data tables" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f9dc97...9ded53 )

by Deven

created 2017-07-05 08:07 UTC

ReportsControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	233
Duplicated Lines	11.59 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	2
dl	27
loc	233
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	testMarkRelatedTo()	16	16	1
A	setUp()	0	5	1
A	testIndex()	0	8	1
B	testView()	0	34	2
A	testDataTables()	0	52	1
A	_testUnmarkRelatedTo()	11	12	1
A	testMassAction()	0	49	1
B	testChangeState()	0	26	1

How to fix Duplicated Code

<?php

namespace App\Test\TestCase\Controller;

use Cake\ORM\TableRegistry;
use Cake\TestSuite\IntegrationTestCase;
use Cake\Network\Exception\NotFoundException;

class ReportsControllerTest extends IntegrationTestCase
{
    public $fixtures = array(
        'app.notifications',
        'app.developers',
        'app.reports',
        'app.incidents',
    );

    public function setUp()
    {
        $this->Reports = TableRegistry::get('Reports');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->session(array('Developer.id' => 1));
    }

    public function testIndex()
    {
        $this->get('/reports');
        $this->assertEquals(array('3.8', '4.0'), $this->viewVariable('distinct_versions'));
        $this->assertEquals(array('forwarded', 'new'), $this->viewVariable('distinct_statuses'));
        $this->assertEquals(array('error1', 'error2'),
                $this->viewVariable('distinct_error_names'));
    }

    public function testView()
    {
        $this->get('/reports/view/1');

        $this->assertEquals(1, $this->viewVariable('report')[0]['id']);
        $this->assertEquals('error2', $this->viewVariable('report')[0]['error_name']);

        $this->assertNotEmpty($this->viewVariable('project_name'));
        $this->assertNotEmpty($this->viewVariable('columns'));

        $this->assertNotEmpty($this->viewVariable('related_entries'));
        $this->assertEquals(count($this->viewVariable('columns')),
                count($this->viewVariable('related_entries')));

        foreach ($this->viewVariable('columns') as $column) {
            $this->assertNotEmpty($this->viewVariable("${column}_distinct_count"));
        }

        $this->assertNotEmpty($this->viewVariable('incidents'));
        $this->assertEquals(1, count($this->viewVariable('incidents')));

        $this->assertNotEmpty($this->viewVariable('incidents_with_description'));
        $this->assertEquals(1, count($this->viewVariable('incidents_with_description')));

        $this->assertNotEmpty($this->viewVariable('incidents_with_stacktrace'));
        $this->assertEquals(1, count($this->viewVariable('incidents_with_stacktrace')));

        $this->assertNotEmpty($this->viewVariable('related_reports'));
        $this->assertEquals(1, count($this->viewVariable('related_reports')));

        $this->get('/reports/view/3');
        $this->assertResponseContains('Invalid Report');
        $this->assertResponseContains('/reports/view/3');
    }

    public function testDataTables()
    {
        $this->get('/reports/data_tables?sEcho=1&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 4,
            'iTotalDisplayRecords' => 4,
            'sEcho' => 1,
            'aaData' => array(
                array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', 'filename_1.php', '4.0', 'Forwarded', 'js', '1'),
                array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', 'filename_2.php', '4.0', 'Forwarded', 'js', '1'),
                array("<input type='checkbox' name='reports[]' value='4'/>", 4, 'error1', 'Lorem ipsum dolor sit amet', 'filename_3.js', '3.8', 'Forwarded', 'js', '2'),
                array("<input type='checkbox' name='reports[]' value='5'/>", 5, 'error1', 'Lorem ipsum dolor sit amet', 'filename_4.js', '3.8', 'New', 'js', '1')
            ),
        );
        $this->assertEquals($expected, json_decode($this->_response->body(), true));

        $this->get('/reports/data_tables?sEcho=1&sSearch=error2&bSearchable_2=true&iSortCol_0=0&sSortDir_0=desc&bSortable_0=true&iSortingCols=2&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 4,
            'iTotalDisplayRecords' => 2,
            'sEcho' => 1,
            'aaData' => array(
                array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', 'filename_1.php', '4.0', 'Forwarded', 'js', '1'),
                array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', 'filename_2.php', '4.0', 'Forwarded', 'js', '1'),
            ),
        );
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals($expected, $result);

        $this->get('/reports/data_tables?sEcho=1&sSearch_1=1&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 4,
            'iTotalDisplayRecords' => 1,
            'sEcho' => 1,
            'aaData' => array(
                array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', 'filename_1.php', '4.0', 'Forwarded', 'js', '1'),
            ),
        );
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals($expected, $result);

        $this->get('/reports/data_tables?sEcho=1&sSearch_1=error&iDisplayLength=25');
        $expected = array(
            'iTotalRecords' => 4,
            'iTotalDisplayRecords' => 0,
            'sEcho' => 1,
            'aaData' => array(
            ),
        );
        $result = json_decode($this->_response->body(), true);
        $this->assertEquals($expected, $result);
    }

    public function testMarkRelatedTo() {
        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(1, $incidents->count());

        $this->post(
            '/reports/mark_related_to/2',
            ['related_to' => 4]
        );

        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(3, $incidents->count());

        $this->_testUnmarkRelatedTo();
    }


    /**
     * Don't run this as a separate test,
     * as the fixture tables are re-created and
     * we lose the previous related_to updations.
     *
     * So, call at the end of testMarkRelatedTo()
     */
    private function _testUnmarkRelatedTo()
    {
        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(3, $incidents->count());

        $this->post('/reports/unmark_related_to/2');

        $this->Reports->id = 2;
        $incidents = $this->Reports->getIncidents();
        $this->assertEquals(1, $incidents->count());
    }

    /**
     * Test for 'mass_action' action
     */
    public function testMassAction()
    {
        $report1 = $this->Reports->get(1);
        $this->assertEquals('forwarded', $report1->status);

        $report5 = $this->Reports->get(5);
        $this->assertEquals('new', $report5->status);

        /* Test case 1: Incorrect state */
        $this->post('/reports/mass_action',
            array('reports' => array('1', '5'), 'state' => 'incorrect_state')
        );

        // Should not change
        $report1 = $this->Reports->get(1);
        $this->assertEquals('forwarded', $report1->status);

        $report5 = $this->Reports->get(5);
        $this->assertEquals('new', $report5->status);

        /* Test case 2: No reports selected */
        $this->post('/reports/mass_action',
            array('reports' => array(), 'state' => 'resolved')
        );

        // Should not change
        $report1 = $this->Reports->get(1);
        $this->assertEquals('forwarded', $report1->status);

        $report5 = $this->Reports->get(5);
        $this->assertEquals('new', $report5->status);

        /* Test case 3: Invalid report id passed */
        $this->post('/reports/mass_action',
            array('reports' => array(10), 'state' => 'resolved')
        );

        /* Test case 4 */
        $this->post('/reports/mass_action',
            array('reports' => array(1, 5), 'state' => 'resolved')
        );

        // Should change
        $report1 = $this->Reports->get(1);
        $this->assertEquals('resolved', $report1->status);

        $report5 = $this->Reports->get(5);
        $this->assertEquals('resolved', $report5->status);
    }

    /**
     * Test for 'change_state' action
     */
    public function testChangeState()
    {
        $this->session(array('Developer.id' => 1, 'read_only' => false));

        $report = $this->Reports->get(1);
        $this->assertEquals('forwarded', $report->status);

        /* Test case 1: Incorrect Report ID */
        $this->post('/reports/change_state/6',
            array('state' => 'resolved')
        );

        /* Test case 2: Incorrect State */
        $this->post('/reports/change_state/1',
            array('state' => 'incorrect_state')
        );
        $report = $this->Reports->get(1);
        $this->assertEquals('forwarded', $report->status);

        /* Test case 3 */
        $this->post('/reports/change_state/1',
            array('state' => 'resolved')
        );
        $report = $this->Reports->get(1);
        $this->assertEquals('resolved', $report->status);
    }
}


1		<?php
2
3		namespace App\Test\TestCase\Controller;
4
5		use Cake\ORM\TableRegistry;
6		use Cake\TestSuite\IntegrationTestCase;
7		use Cake\Network\Exception\NotFoundException;
8
9		class ReportsControllerTest extends IntegrationTestCase
10		{
11		public $fixtures = array(
12		'app.notifications',
13		'app.developers',
14		'app.reports',
15		'app.incidents',
16		);
17
18		public function setUp()
19		{
20		$this->Reports = TableRegistry::get('Reports');
		0 ignored issues – show Bug introduced 2015-12-24 09:14 UTC by Report Bug Copy Issue Report The property `Reports` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21		$this->session(array('Developer.id' => 1));
22		}
23
24		public function testIndex()
25		{
26		$this->get('/reports');
27		$this->assertEquals(array('3.8', '4.0'), $this->viewVariable('distinct_versions'));
28		$this->assertEquals(array('forwarded', 'new'), $this->viewVariable('distinct_statuses'));
29		$this->assertEquals(array('error1', 'error2'),
30		$this->viewVariable('distinct_error_names'));
31		}
32
33		public function testView()
34		{
35		$this->get('/reports/view/1');
36
37		$this->assertEquals(1, $this->viewVariable('report')[0]['id']);
38		$this->assertEquals('error2', $this->viewVariable('report')[0]['error_name']);
39
40		$this->assertNotEmpty($this->viewVariable('project_name'));
41		$this->assertNotEmpty($this->viewVariable('columns'));
42
43		$this->assertNotEmpty($this->viewVariable('related_entries'));
44		$this->assertEquals(count($this->viewVariable('columns')),
45		count($this->viewVariable('related_entries')));
46
47		foreach ($this->viewVariable('columns') as $column) {
48		$this->assertNotEmpty($this->viewVariable("${column}_distinct_count"));
49		}
50
51		$this->assertNotEmpty($this->viewVariable('incidents'));
52		$this->assertEquals(1, count($this->viewVariable('incidents')));
53
54		$this->assertNotEmpty($this->viewVariable('incidents_with_description'));
55		$this->assertEquals(1, count($this->viewVariable('incidents_with_description')));
56
57		$this->assertNotEmpty($this->viewVariable('incidents_with_stacktrace'));
58		$this->assertEquals(1, count($this->viewVariable('incidents_with_stacktrace')));
59
60		$this->assertNotEmpty($this->viewVariable('related_reports'));
61		$this->assertEquals(1, count($this->viewVariable('related_reports')));
62
63		$this->get('/reports/view/3');
64		$this->assertResponseContains('Invalid Report');
65		$this->assertResponseContains('/reports/view/3');
66		}
67
68		public function testDataTables()
69		{
70		$this->get('/reports/data_tables?sEcho=1&iDisplayLength=25');
71		$expected = array(
72		'iTotalRecords' => 4,
73		'iTotalDisplayRecords' => 4,
74		'sEcho' => 1,
75		'aaData' => array(
76		array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', 'filename_1.php', '4.0', 'Forwarded', 'js', '1'),
77		array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', 'filename_2.php', '4.0', 'Forwarded', 'js', '1'),
78		array("<input type='checkbox' name='reports[]' value='4'/>", 4, 'error1', 'Lorem ipsum dolor sit amet', 'filename_3.js', '3.8', 'Forwarded', 'js', '2'),
79		array("<input type='checkbox' name='reports[]' value='5'/>", 5, 'error1', 'Lorem ipsum dolor sit amet', 'filename_4.js', '3.8', 'New', 'js', '1')
80		),
81		);
82		$this->assertEquals($expected, json_decode($this->_response->body(), true));
83
84		$this->get('/reports/data_tables?sEcho=1&sSearch=error2&bSearchable_2=true&iSortCol_0=0&sSortDir_0=desc&bSortable_0=true&iSortingCols=2&iDisplayLength=25');
85		$expected = array(
86		'iTotalRecords' => 4,
87		'iTotalDisplayRecords' => 2,
88		'sEcho' => 1,
89		'aaData' => array(
90		array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', 'filename_1.php', '4.0', 'Forwarded', 'js', '1'),
91		array("<input type='checkbox' name='reports[]' value='2'/>", 2, 'error2', 'Lorem ipsum dolor sit amet', 'filename_2.php', '4.0', 'Forwarded', 'js', '1'),
92		),
93		);
94		$result = json_decode($this->_response->body(), true);
95		$this->assertEquals($expected, $result);
96
97		$this->get('/reports/data_tables?sEcho=1&sSearch_1=1&iDisplayLength=25');
98		$expected = array(
99		'iTotalRecords' => 4,
100		'iTotalDisplayRecords' => 1,
101		'sEcho' => 1,
102		'aaData' => array(
103		array("<input type='checkbox' name='reports[]' value='1'/>", 1, 'error2', 'Lorem ipsum dolor sit amet', 'filename_1.php', '4.0', 'Forwarded', 'js', '1'),
104		),
105		);
106		$result = json_decode($this->_response->body(), true);
107		$this->assertEquals($expected, $result);
108
109		$this->get('/reports/data_tables?sEcho=1&sSearch_1=error&iDisplayLength=25');
110		$expected = array(
111		'iTotalRecords' => 4,
112		'iTotalDisplayRecords' => 0,
113		'sEcho' => 1,
114		'aaData' => array(
115		),
116		);
117		$result = json_decode($this->_response->body(), true);
118		$this->assertEquals($expected, $result);
119		}
120
121	View Code Duplication	public function testMarkRelatedTo() {
122		$this->Reports->id = 2;
123		$incidents = $this->Reports->getIncidents();
124		$this->assertEquals(1, $incidents->count());
125
126		$this->post(
127		'/reports/mark_related_to/2',
128		['related_to' => 4]
129		);
130
131		$this->Reports->id = 2;
132		$incidents = $this->Reports->getIncidents();
133		$this->assertEquals(3, $incidents->count());
134
135		$this->_testUnmarkRelatedTo();
136		}
137
138
139		/**
140		* Don't run this as a separate test,
141		* as the fixture tables are re-created and
142		* we lose the previous related_to updations.
143		*
144		* So, call at the end of testMarkRelatedTo()
145		*/
146	View Code Duplication	private function _testUnmarkRelatedTo()
147		{
148		$this->Reports->id = 2;
149		$incidents = $this->Reports->getIncidents();
150		$this->assertEquals(3, $incidents->count());
151
152		$this->post('/reports/unmark_related_to/2');
153
154		$this->Reports->id = 2;
155		$incidents = $this->Reports->getIncidents();
156		$this->assertEquals(1, $incidents->count());
157		}
158
159		/**
160		* Test for 'mass_action' action
161		*/
162		public function testMassAction()
163		{
164		$report1 = $this->Reports->get(1);
165		$this->assertEquals('forwarded', $report1->status);
166
167		$report5 = $this->Reports->get(5);
168		$this->assertEquals('new', $report5->status);
169
170		/* Test case 1: Incorrect state */
171		$this->post('/reports/mass_action',
172		array('reports' => array('1', '5'), 'state' => 'incorrect_state')
173		);
174
175		// Should not change
176		$report1 = $this->Reports->get(1);
177		$this->assertEquals('forwarded', $report1->status);
178
179		$report5 = $this->Reports->get(5);
180		$this->assertEquals('new', $report5->status);
181
182		/* Test case 2: No reports selected */
183		$this->post('/reports/mass_action',
184		array('reports' => array(), 'state' => 'resolved')
185		);
186
187		// Should not change
188		$report1 = $this->Reports->get(1);
189		$this->assertEquals('forwarded', $report1->status);
190
191		$report5 = $this->Reports->get(5);
192		$this->assertEquals('new', $report5->status);
193
194		/* Test case 3: Invalid report id passed */
195		$this->post('/reports/mass_action',
196		array('reports' => array(10), 'state' => 'resolved')
197		);
198
199		/* Test case 4 */
200		$this->post('/reports/mass_action',
201		array('reports' => array(1, 5), 'state' => 'resolved')
202		);
203
204		// Should change
205		$report1 = $this->Reports->get(1);
206		$this->assertEquals('resolved', $report1->status);
207
208		$report5 = $this->Reports->get(5);
209		$this->assertEquals('resolved', $report5->status);
210		}
211
212		/**
213		* Test for 'change_state' action
214		*/
215		public function testChangeState()
216		{
217		$this->session(array('Developer.id' => 1, 'read_only' => false));
218
219		$report = $this->Reports->get(1);
220		$this->assertEquals('forwarded', $report->status);
221
222		/* Test case 1: Incorrect Report ID */
223		$this->post('/reports/change_state/6',
224		array('state' => 'resolved')
225		);
226
227		/* Test case 2: Incorrect State */
228		$this->post('/reports/change_state/1',
229		array('state' => 'incorrect_state')
230		);
231		$report = $this->Reports->get(1);
232		$this->assertEquals('forwarded', $report->status);
233
234		/* Test case 3 */
235		$this->post('/reports/change_state/1',
236		array('state' => 'resolved')
237		);
238		$report = $this->Reports->get(1);
239		$this->assertEquals('resolved', $report->status);
240		}
241		}
242

phpmyadmin / error-reporting-server

Push — master ( f9dc97...9ded53 )

ReportsControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like