GithubController::link_issue() - Code Metrics - Inspection of "Add tests for GitHub controller" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#170)

by Deven
created 2017-07-03 06:17 UTC
GithubController::link_issue() B

↳ Parent: GithubController
Complexity

Conditions	8
Paths	9
Size

Total Lines	59
Code Lines	38
Duplication

Lines	5
Ratio	8.47 %
Code Coverage

Tests	37
CRAP Score	8.001
Importance

Changes	3
Bugs	0	Features	0
Metric	Value
dl	5
loc	59
ccs	37
cts	38
cp	0.9737
rs	7.132
c	3
b	0
f	0
cc	8
eloc	38
nc	9
nop	1
crap	8.001
How to fix Long Method

<?php
/* vim: set expandtab sw=4 ts=4 sts=4: */

/**
 * Github controller handling issue creation, comments and sync.
 *
 * phpMyAdmin Error reporting server
 * Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright (c) phpMyAdmin project (https://www.phpmyadmin.net/)
 * @license   https://opensource.org/licenses/mit-license.php MIT License
 *
 * @see      https://www.phpmyadmin.net/
 */

namespace App\Controller;

use Cake\Core\Configure;
use Cake\Event\Event;
use Cake\Log\Log;
use Cake\Network\Exception\NotFoundException;
use Cake\ORM\TableRegistry;
use Cake\Routing\Router;

/**
 * Github controller handling github issue submission and creation.
 */
class GithubController extends AppController
{
    public $helpers = array('Html', 'Form');

    public $components = array('GithubApi');

    public function beforeFilter(Event $event)
    {
        parent::beforeFilter($event);
        $this->GithubApi->githubConfig = Configure::read('GithubConfig');
        $this->GithubApi->githubRepo = Configure::read('GithubRepoPath');
    }

    /**
     * create Github Issue.
     *
     * @param int $reportId
     *
     * @throws NotFoundException
     */
    public function create_issue($reportId)
    {
        if (!isset($reportId) || !$reportId) {
            throw new NotFoundException(__('Invalid report'));
        }

        $reportsTable = TableRegistry::get('Reports');
        $report = $reportsTable->findById($reportId)->all()->first();

        if (!$report) {
            throw new NotFoundException(__('Invalid report'));
        }

        $reportArray = $report->toArray();
        if (empty($this->request->data)) {

            $this->set('pma_version', $reportArray['pma_version']);
            $this->set('error_name', $reportArray['error_name']);
            $this->set('error_message', $reportArray['error_message']);

            return;
        }

        $this->autoRender = false;
        $data = array(
            'title' => $this->request->data['summary'],

            'labels' => $this->request->data['labels'] ? explode(',', $this->request->data['labels']) : array(),

        );
        $incidents_query = TableRegistry::get('Incidents')->findByReportId($reportId)->all();
        $incident = $incidents_query->first();
        $reportArray['exception_type'] = $incident['exception_type'] ? 'php' : 'js';
        $reportArray['description'] = $this->request->data['description'];


        $data['body']
            = $this->_getReportDescriptionText($reportId, $reportArray);
        $data['labels'][] = 'automated-error-report';

        list($issueDetails, $status) = $this->GithubApi->createIssue(
            Configure::read('GithubRepoPath'),
            $data,
            $this->request->session()->read('access_token')
        );

        if ($this->_handleGithubResponse($status, 1, $reportId, $issueDetails['number'])) {
            // Update report status
            $report->status = $this->_getReportStatusFromIssueState($issueDetails['state']);
            $reportsTable->save($report);

            $this->redirect(array('controller' => 'reports', 'action' => 'view',
                $reportId, ));
        } else {
            $flash_class = 'alert alert-error';
            $this->Flash->default($this->_getErrors($issueDetails, $status),
                array('params' => array('class' => $flash_class)));
        }
    }

    /**
     * Links error report to existing issue on Github.
     *
     * @param mixed $reportId
     */
    public function link_issue($reportId)
    {
        if (!isset($reportId) || !$reportId) {
            throw new NotFoundException(__('Invalid reportId'));
        }

        $reportsTable = TableRegistry::get('Reports');
        $report = $reportsTable->findById($reportId)->all()->first();

        if (!$report) {
            throw new NotFoundException(__('Invalid report'));
        }

        $ticket_id = intval($this->request->query['ticket_id']);

        if (!$ticket_id) {
            throw new NotFoundException(__('Invalid Ticket ID!!'));
        }
        $reportArray = $report->toArray();

        $incidents_query = TableRegistry::get('Incidents')->findByReportId($reportId)->all();
        $incident = $incidents_query->first();
        $reportArray['exception_type'] = $incident['exception_type'] ? 'php' : 'js';

        $commentText = $this->_getReportDescriptionText(
            $reportId, $reportArray
        );
        list($commentDetails, $status) = $this->GithubApi->createComment(
            Configure::read('GithubRepoPath'),
            array('body' => $commentText),
            $ticket_id,
            $this->request->session()->read('access_token')
        );
        if ($this->_handleGithubResponse($status, 2, $reportId, $ticket_id)) {
            // Update report status
            $report->status = 'forwarded';

            list($issueDetails, $status) = $this->GithubApi->getIssue(
                Configure::read('GithubRepoPath'),
                array(),
                $ticket_id,
                $this->request->session()->read('access_token')
            );
            if ($this->_handleGithubResponse($status, 4, $reportId, $ticket_id)) {
                // If linked Github issue state is available, use it to update Report's status
                $report->status = $this->_getReportStatusFromIssueState(
                    $issueDetails['state']
                );
            }

            $reportsTable->save($report);
        } else {
            $flash_class = 'alert alert-error';
            $this->Flash->default($this->_getErrors($commentDetails, $status),
                    array('params' => array('class' => $flash_class)));
        }

        $this->redirect(array('controller' => 'reports', 'action' => 'view',
                        $reportId, ));
    }

    /**
     * Un-links error report to associated issue on Github.
     *
     * @param mixed $reportId
     */
    public function unlink_issue($reportId)
    {
        if (!isset($reportId) || ! $reportId) {
            throw new NotFoundException(__('Invalid reportId'));
        }

        $reportsTable = TableRegistry::get('Reports');
        $report = $reportsTable->findById($reportId)->all()->first();

        if (!$report) {
            throw new NotFoundException(__('Invalid report'));
        }

        $reportArray = $report->toArray();
        $ticket_id = $reportArray['sourceforge_bug_id'];

        if (!$ticket_id) {
            throw new NotFoundException(__('Invalid Ticket ID!!'));
        }

        // "formatted" text of the comment.
        $commentText = 'This Issue is no longer associated with [Report#'
            . $reportId
            . ']('
            . Router::url('/reports/view/' . $reportId, true)
            . ')'
            . "\n\n*This comment is posted automatically by phpMyAdmin's "
            . '[error-reporting-server](https://reports.phpmyadmin.net).*';

        list($commentDetails, $status) = $this->GithubApi->createComment(
            Configure::read('GithubRepoPath'),
            array('body' => $commentText),
            $ticket_id,
            $this->request->session()->read('access_token')
        );

        if ($this->_handleGithubResponse($status, 3, $reportId)) {
            // Update report status
            $report->status = 'new';
            $reportsTable->save($report);
        } else {
            $flash_class = 'alert alert-error';
            $this->Flash->default($this->_getErrors($commentDetails, $status),
                    array('params' => array('class' => $flash_class)));
        }

        $this->redirect(array('controller' => 'reports', 'action' => 'view',
                        $reportId, ));
    }

    /**
     * Returns pretty error message string.
     *
     * @param object $response the response returned by Github api
     * @param int    $status   status returned by Github API
     *
     * @return error string
     */
    protected function _getErrors($response, $status)
    {
        $errorString = 'There were some problems with the issue submission.'
            . ' Returned status is (' . $status . ')';
        $errorString .= '<br/> Here is the dump for the errors field provided by'
            . ' github: <br/>'
            . '<pre>'
            . print_r($response, true)
            . '</pre>';

        return $errorString;
    }

    /**
     * Returns the text to be added while creating an issue
     *
     * @param integer $reportId       Report Id
     * @param array   $report         Report associative array
     *
     * @return string
     */
    protected function _getReportDescriptionText($reportId, $report)
    {
        $incident_count = $this->_getTotalIncidentCount($reportId);

        // "formatted" text of the comment.
        $formattedText
            = array_key_exists('description', $report) ? $report['description'] . "\n\n"
                : '';
        $formattedText .= "\nParam | Value "
            . "\n -----------|--------------------"
            . "\n Error Type | " . $report['error_name']
            . "\n Error Message |" . $report['error_message']
            . "\n Exception Type |" . $report['exception_type']
            . "\n phpMyAdmin version |" . $report['pma_version']
            . "\n Incident count | " . $incident_count
            . "\n Link | [Report#"
                . $reportId
                . ']('
                . Router::url('/reports/view/' . $reportId, true)
                . ')'
            . "\n\n*This comment is posted automatically by phpMyAdmin's "
            . '[error-reporting-server](https://reports.phpmyadmin.net).*';

        return $formattedText;
    }

    /**
     * Github Response Handler.
     *
     * @param int $response  the status returned by Github API
     * @param int $type      type of response. 1 for create_issue, 2 for link_issue, 3 for unlink_issue,
     *                       1 for create_issue,
     *                       2 for link_issue,
     *                       3 for unlink_issue,
     *                       4 for get_issue
     * @param int $report_id report id
     * @param int $ticket_id ticket id, required for link ticket only
     *
     * @return bool value. True on success. False on any type of failure.
     */
    protected function _handleGithubResponse($response, $type, $report_id, $ticket_id = 1)
    {
        if (!in_array($type, array(1, 2, 3, 4))) {
            throw new InvalidArgumentException('Invalid Argument "$type".');
        }

        $updateReport = true;

        if ($type == 4 && $response == 200) {
            // issue details fetched successfully
            return true;
        } elseif ($response == 201) {
            // success
            switch ($type) {
                case 1:
                    $msg = 'Github issue has been created for this report.';
                    break;
                case 2:
                    $msg = 'Github issue has been linked with this report.';
                    break;
                case 3:
                    $msg = 'Github issue has been unlinked with this report.';
                    $ticket_id = null;
                    break;

                default:
                    $msg = 'Something went wrong!';
                    break;
            }

            if ($updateReport) {
                $report = TableRegistry::get('Reports')->get($report_id);
                $report->sourceforge_bug_id = $ticket_id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                TableRegistry::get('Reports')->save($report);
            }

            if ($msg !== '') {
                $flash_class = 'alert alert-success';
                $this->Flash->default($msg,
                    array('params' => array('class' => $flash_class)));
            }

            return true;
        } elseif ($response === 403) {
            $flash_class = 'alert alert-error';
            $this->Flash->default(
                    'Unauthorised access to Github. github'
                    . ' credentials may be out of date. Please check and try again'
                    . ' later.',
                    array('params' => array('class' => $flash_class)));

            return false;
        } elseif ($response === 404
            && $type == 2
        ) {
            $flash_class = 'alert alert-error';
            $this->Flash->default(
                    'Bug Issue not found on Github.'
                    . ' Are you sure the issue number is correct? Please check and try again!',
                     array('params' => array('class' => $flash_class)));

            return false;
        }

        // unknown response code
        $flash_class = 'alert alert-error';
        $this->Flash->default('Unhandled response code recieved: ' . $response,
                    array('params' => array('class' => $flash_class)));

        return false;
    }

    /**
     * Get Incident counts for a report and
     * all its related reports
     *
     * @param $reportId Report ID
     *
     * @return $total_incident_count Total Incident count for a report

     */
    protected function _getTotalIncidentCount($reportId)
    {
        $incidents_query = TableRegistry::get('Incidents')->findByReportId($reportId)->all();
        $incident_count = $incidents_query->count();

        $params_count = array(
            'fields' => array('inci_count' => 'inci_count'),
            'conditions' => array(
                    'related_to = ' . $reportId,
            ),
        );
        $subquery_params_count = array(
            'fields' => array(
                'report_id' => 'report_id',
            ),
        );
        $subquery_count = TableRegistry::get('Incidents')->find(
            'all', $subquery_params_count
        );
        $inci_count_related = TableRegistry::get('Reports')->find('all', $params_count)->innerJoin(
                array('incidents' => $subquery_count),
                array('incidents.report_id = Reports.related_to')
            )->count();

        return $incident_count + $inci_count_related;
    }

    /**
     * Get corresponding report status from Github issue state
     *
     * @param $issueState Linked Github issue's state
     *
     * @return Corresponding status to which the linked report should be updated to
     */
    protected function _getReportStatusFromIssueState($issueState)
    {
        // default
        $reportStatus = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        switch ($issueState) {
            case 'closed':
                $reportStatus = 'resolved';
                break;

            default:
                $reportStatus = 'forwarded';
                break;
        }

        return $reportStatus;
    }

    /**
     * Synchronize Report Statuses from Github issues
     *
     * To be used as a cron job (using webroot/cron_dispatcher.php).
     *
     * Can not (& should not) be directly accessed via web.
     */
    public function sync_issue_status()
    {
        if (!defined('CRON_DISPATCHER')) {
            $flash_class = 'alert alert-error';
            $this->Flash->default(
                'Unauthorised action! This action is not available on Web interface',
                array('params' => array('class' => $flash_class))
            );

            $this->redirect('/');
            return;
        }

        $this->autoRender = false;
        $reportsTable = TableRegistry::get('Reports');

        // Fetch all linked reports
        $reports = $reportsTable->find(
            'all',
            array(
                'conditions' => array(
                    'sourceforge_bug_id IS NOT NULL',
                    'NOT' => array(
                        'status' => 'resolved'
                    )
                )
            )
        );

        foreach ($reports as $report) {
            $report = $report->toArray();

            // fetch the new issue status
            list($issueDetails, $status) = $this->GithubApi->getIssue(
                Configure::read('GithubRepoPath'),
                array(),
                $report['sourceforge_bug_id'],
                Configure::read('GithubAccessToken')
            );

            if (!$this->_handleGithubResponse($status, 4, $report['id'], $report['sourceforge_bug_id'])) {
                Log::error(
                    'FAILED: Fetching status of Issue #'
                        . ($report['sourceforge_bug_id'])
                        . ' associated with Report#'
                        . ($report['id'])
                        . '. Status returned: ' . $status,
                    ['scope' => 'cron_jobs']
                );
                continue;
            }

            // if Github issue state has changed, update the status of report
            if ($report['status'] !== $issueDetails['state']) {
                $rep = $reportsTable->get($report['id']);
                $rep->status = $this->_getReportStatusFromIssueState($issueDetails['state']);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

                // Save the report
                $reportsTable->save($rep);

                Log::debug(
                    'SUCCESS: Updated status of Report #'
                    . $report['id'] . ' from state of its linked Github issue #'
                    . $report['sourceforge_bug_id'] . ' to ' . $rep->status,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    ['scope' => 'cron_jobs']
                );
            }
        }
    }
}

Pull Request — master (#170)

GithubController::link_issue() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

phpmyadmin / error-reporting-server

Pull Request — master (#170)

GithubController::link_issue() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
