SyncGithubIssueStatesShellTest::testExecute() - Code Metrics - Inspection of "Create the logs folder for cli tests" - phpmyadmin/error-reporting-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 083ff7...c84473 )

by William

created 2021-03-08 22:23 UTC

SyncGithubIssueStatesShellTest::testExecute() A

↳ Parent: SyncGithubIssueStatesShellTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	65
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	37
nc	1
nop	0
dl	0
loc	65
rs	9.328
c	1
b	0
f	0

How to fix Long Method

<?php

namespace App\Test\TestCase\Shell;

use Cake\Command\Command;
use Cake\TestSuite\ConsoleIntegrationTestTrait;
use Cake\TestSuite\TestCase;
use phpmock\phpunit\PHPMock;
use const DS;
use function file_get_contents;
use function json_decode;
use function json_encode;

/**
 * App\Shell\SyncGithubIssueStatesShell Test Case
 */
class SyncGithubIssueStatesShellTest extends TestCase
{
    use ConsoleIntegrationTestTrait;
    use PHPMock;

    /**
     * Fixtures.
     *
     * @var array
     */
    public $fixtures = ['app.Reports'];

    public function setUp(): void
    {
        parent::setUp();
        $this->useCommandRunner();
    }

    /**
     * Test execute method
     */
    public function testExecute(): void
    {
        $Reports = $this->getTableLocator()->get('Reports');
        // Mock functions `curl_exec` and `curl_getinfo` in GithubApiComponent
        // so that we don't actually hit the Github Api
        $curlExecMock = $this->getFunctionMock('\App\Controller\Component', 'curl_exec');
        $curlGetInfoMock = $this->getFunctionMock('\App\Controller\Component', 'curl_getinfo');

        $issueResponse = file_get_contents(TESTS . 'Fixture' . DS . 'issue_response.json');
        $decodedResponse = json_decode($issueResponse, true);
        $decodedResponse['state'] = 'closed';
        $issueResponseWithClosed = json_encode($decodedResponse);

        $curlExecMock->expects($this->exactly(3))->willReturnOnConsecutiveCalls(
            $issueResponse,
            $issueResponse,
            $issueResponseWithClosed
        );
        $curlGetInfoMock->expects($this->exactly(3))->willReturnOnConsecutiveCalls(
            200,
            200,
            200
        );

        // Fetch all linked reports
        $reports = $Reports->find(
            'all',
            [
                'conditions' => [
                    'sourceforge_bug_id IS NOT NULL',
                    'NOT' => ['status' => 'resolved'],
                ],
            ]
        );
        $this->assertEquals(3, $reports->count());

        // Run the shell command
        $this->exec('sync_github_issue_states');
        $this->assertExitCode(Command::CODE_SUCCESS);

        // Fetch all linked reports
        $reports = $Reports->find(
            'all',
            [
                'conditions' => [
                    'sourceforge_bug_id IS NOT NULL',
                    'NOT' => ['status' => 'resolved'],
                ],
            ]
        );
        $this->assertEquals(2, $reports->count());

        // Fetch all closed reports
        $reports = $Reports->find(
            'all',
            [
                'conditions' => [
                    'sourceforge_bug_id IS NOT NULL',
                    'status' => 'resolved',
                ],
            ]
        );
        $this->assertEquals(1, $reports->count());
        $report5 = $Reports->get(4);
        $this->assertEquals('resolved', $report5->status);
    }
}


1			<?php
2
3			namespace App\Test\TestCase\Shell;
4
5			use Cake\Command\Command;
6			use Cake\TestSuite\ConsoleIntegrationTestTrait;
7			use Cake\TestSuite\TestCase;
8			use phpmock\phpunit\PHPMock;
9			use const DS;
10			use function file_get_contents;
11			use function json_decode;
12			use function json_encode;
13
14			/**
15			* App\Shell\SyncGithubIssueStatesShell Test Case
16			*/
17			class SyncGithubIssueStatesShellTest extends TestCase
18			{
19			use ConsoleIntegrationTestTrait;
20			use PHPMock;
21
22			/**
23			* Fixtures.
24			*
25			* @var array
26			*/
27			public $fixtures = ['app.Reports'];
28
29			public function setUp(): void
30			{
31			parent::setUp();
32			$this->useCommandRunner();
33			}
34
35			/**
36			* Test execute method
37			*/
38			public function testExecute(): void
39			{
40			$Reports = $this->getTableLocator()->get('Reports');
41			// Mock functions `curl_exec` and `curl_getinfo` in GithubApiComponent
42			// so that we don't actually hit the Github Api
43			$curlExecMock = $this->getFunctionMock('\App\Controller\Component', 'curl_exec');
44			$curlGetInfoMock = $this->getFunctionMock('\App\Controller\Component', 'curl_getinfo');
45
46			$issueResponse = file_get_contents(TESTS . 'Fixture' . DS . 'issue_response.json');
47			$decodedResponse = json_decode($issueResponse, true);
48			$decodedResponse['state'] = 'closed';
49			$issueResponseWithClosed = json_encode($decodedResponse);
50
51			$curlExecMock->expects($this->exactly(3))->willReturnOnConsecutiveCalls(
52			$issueResponse,
53			$issueResponse,
54			$issueResponseWithClosed
55			);
56			$curlGetInfoMock->expects($this->exactly(3))->willReturnOnConsecutiveCalls(
57			200,
58			200,
59			200
60			);
61
62			// Fetch all linked reports
63			$reports = $Reports->find(
64			'all',
65			[
66			'conditions' => [
67			'sourceforge_bug_id IS NOT NULL',
68			'NOT' => ['status' => 'resolved'],
69			],
70			]
71			);
72			$this->assertEquals(3, $reports->count());
73
74			// Run the shell command
75			$this->exec('sync_github_issue_states');
76			$this->assertExitCode(Command::CODE_SUCCESS);
77
78			// Fetch all linked reports
79			$reports = $Reports->find(
80			'all',
81			[
82			'conditions' => [
83			'sourceforge_bug_id IS NOT NULL',
84			'NOT' => ['status' => 'resolved'],
85			],
86			]
87			);
88			$this->assertEquals(2, $reports->count());
89
90			// Fetch all closed reports
91			$reports = $Reports->find(
92			'all',
93			[
94			'conditions' => [
95			'sourceforge_bug_id IS NOT NULL',
96			'status' => 'resolved',
97			],
98			]
99			);
100			$this->assertEquals(1, $reports->count());
101			$report5 = $Reports->get(4);
102			$this->assertEquals('resolved', $report5->status);
103			}
104			}
105

phpmyadmin / error-reporting-server

Push — master ( 083ff7...c84473 )

SyncGithubIssueStatesShellTest::testExecute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like