Issues in CompositeSettingProvider.php (master) - Issues in master - phpmob/settings - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Provider/CompositeSettingProvider.php (4 issues)

Labels

Bug 4

Severity

Minor 4

liverbool 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the PhpMob package.
 *
 * (c) Ishmael Doss <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace PhpMob\Settings\Provider;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use PhpMob\Settings\Model\SettingInterface;

/**
 * @author Ishmael Doss <[email protected]>
 */
class CompositeSettingProvider implements SettingProviderInterface
{
    /**
     * @var SettingProviderInterface
     */
    private $localProvider;

    /**
     * @var SettingProviderInterface
     */
    private $remoteProvider;

    /**
     * @param SettingProviderInterface $localProvider
     * @param SettingProviderInterface $remoteProvider
     */
    public function __construct(SettingProviderInterface $localProvider, SettingProviderInterface $remoteProvider)
    {
        $this->localProvider = $localProvider;
        $this->remoteProvider = $remoteProvider;
    }

    /**
     * {@inheritdoc}
     */
    public function findUserSettings(string $owner): Collection
    {
        return $this->mergeSettings(
            $this->remoteProvider->findUserSettings($owner),

            $this->localProvider->findUserSettings($owner)

        );
    }

    /**
     * {@inheritdoc}
     */
    public function findGlobalSettings(): Collection
    {
        return $this->mergeSettings(
            $this->remoteProvider->findGlobalSettings(),

            $this->localProvider->findGlobalSettings()

        );
    }

    /**
     * @param Collection $remotes
     * @param Collection $locals
     *
     * @return ArrayCollection
     */
    private function mergeSettings(Collection $remotes, Collection $locals): ArrayCollection
    {
        $settings = $remotes->toArray();

        /** @var SettingInterface $local */
        foreach ($locals->toArray() as $local) {
            if (!$this->exists($remotes, $local)) {
                $settings[] = $local;
            }
        }

        return new ArrayCollection($settings);
    }

    /**
     * @param Collection $remote
     * @param SettingInterface $object
     *
     * @return bool
     */
    private function exists(Collection $remote, SettingInterface $object): bool
    {
        return $remote->exists(function (int $key, SettingInterface $setting) use ($object) {
            return $setting->isEqual($object);
        });
    }
}


1		<?php
2
3		/*
4		* This file is part of the PhpMob package.
5		*
6		* (c) Ishmael Doss <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		declare(strict_types=1);
13
14		namespace PhpMob\Settings\Provider;
15
16		use Doctrine\Common\Collections\ArrayCollection;
17		use Doctrine\Common\Collections\Collection;
18		use PhpMob\Settings\Model\SettingInterface;
19
20		/**
21		* @author Ishmael Doss <[email protected]>
22		*/
23		class CompositeSettingProvider implements SettingProviderInterface
24		{
25		/**
26		* @var SettingProviderInterface
27		*/
28		private $localProvider;
29
30		/**
31		* @var SettingProviderInterface
32		*/
33		private $remoteProvider;
34
35		/**
36		* @param SettingProviderInterface $localProvider
37		* @param SettingProviderInterface $remoteProvider
38		*/
39	4	public function __construct(SettingProviderInterface $localProvider, SettingProviderInterface $remoteProvider)
40		{
41	4	$this->localProvider = $localProvider;
42	4	$this->remoteProvider = $remoteProvider;
43	4	}
44
45		/**
46		* {@inheritdoc}
47		*/
48	2	public function findUserSettings(string $owner): Collection
49		{
50	2	return $this->mergeSettings(
51	2	$this->remoteProvider->findUserSettings($owner),
		0 ignored issues – show Bug introduced 2017-10-04 11:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->remoteProvider->findUserSettings($owner)` targeting `PhpMob\Settings\Provider...ace::findUserSettings()` can also be of type `array<integer,object<Php...odel\SettingInterface>>`; however, `PhpMob\Settings\Provider...ovider::mergeSettings()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
52	2	$this->localProvider->findUserSettings($owner)
		0 ignored issues – show Bug introduced 2017-10-04 11:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->localProvider->findUserSettings($owner)` targeting `PhpMob\Settings\Provider...ace::findUserSettings()` can also be of type `array<integer,object<Php...odel\SettingInterface>>`; however, `PhpMob\Settings\Provider...ovider::mergeSettings()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
53		);
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59	1	public function findGlobalSettings(): Collection
60		{
61	1	return $this->mergeSettings(
62	1	$this->remoteProvider->findGlobalSettings(),
		0 ignored issues – show Bug introduced 2017-10-04 11:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->remoteProvider->findGlobalSettings()` targeting `PhpMob\Settings\Provider...e::findGlobalSettings()` can also be of type `array<integer,object<Php...odel\SettingInterface>>`; however, `PhpMob\Settings\Provider...ovider::mergeSettings()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
63	1	$this->localProvider->findGlobalSettings()
		0 ignored issues – show Bug introduced 2017-10-04 11:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->localProvider->findGlobalSettings()` targeting `PhpMob\Settings\Provider...e::findGlobalSettings()` can also be of type `array<integer,object<Php...odel\SettingInterface>>`; however, `PhpMob\Settings\Provider...ovider::mergeSettings()` does only seem to accept `object<Doctrine\Common\Collections\Collection>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
64		);
65		}
66
67		/**
68		* @param Collection $remotes
69		* @param Collection $locals
70		*
71		* @return ArrayCollection
72		*/
73	3	private function mergeSettings(Collection $remotes, Collection $locals): ArrayCollection
74		{
75	3	$settings = $remotes->toArray();
76
77		/** @var SettingInterface $local */
78	3	foreach ($locals->toArray() as $local) {
79	3	if (!$this->exists($remotes, $local)) {
80	3	$settings[] = $local;
81		}
82		}
83
84	3	return new ArrayCollection($settings);
85		}
86
87		/**
88		* @param Collection $remote
89		* @param SettingInterface $object
90		*
91		* @return bool
92		*/
93		private function exists(Collection $remote, SettingInterface $object): bool
94		{
95	3	return $remote->exists(function (int $key, SettingInterface $setting) use ($object) {
96	3	return $setting->isEqual($object);
97	3	});
98		}
99		}
100

phpmob / settings

Issues (16)

Security Analysis no request data

Provider/CompositeSettingProvider.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like