CachedManager::getSetting() - Code Metrics - phpmob/settings - Measure and Improve Code Quality continuously with Scrutinizer

CachedManager::getSetting() A
last analyzed 2018-02-10 12:17 UTC

↳ Parent: CachedManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	12
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	3
crap	6

<?php

/*
 * This file is part of the PhpMob package.
 *
 * (c) Ishmael Doss <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace PhpMob\Settings\Manager;

use Psr\Cache\CacheItemPoolInterface;

/**
 * @author Ishmael Doss <[email protected]>
 */
class CachedManager implements SettingManagerInterface
{
    /**
     * @var CacheItemPoolInterface
     */
    private $cache;

    /**
     * @var int|\DateInterval|null
     */
    private $ttl = 0;

    /**
     * @var SettingManagerInterface
     */
    private $decoratedManager;

    public function __construct(SettingManagerInterface $manager, CacheItemPoolInterface $cache, $ttl = 0)
    {
        $this->decoratedManager = $manager;
        $this->cache = $cache;
        $this->ttl = $ttl;
    }

    /**
     * @param $section
     * @param $key
     * @param string|null $owner
     *
     * @return string
     */
    private function getCacheKey($section, $key, ?string $owner = null)
    {
        return 'phpmob-settings.' . ($owner
                ? sprintf('%s.%s.%s', $section, $key, $owner)
                : sprintf('%s.%s', $section, $key)
            );
    }

    /**
     * {@inheritdoc}
     */
    public function setSetting(string $section, string $key, $value, ?string $owner = null, $autoFlush = false): void
    {
        $cacheKey = $this->getCacheKey($section, $key, $owner);

        if ($this->cache->hasItem($cacheKey) && $value === $this->cache->getItem($cacheKey)->get()) {
            return;
        }

        $this->decoratedManager->setSetting($section, $key, $value, $owner, $autoFlush);

        $this->cache->save(
            $this->cache->getItem($cacheKey)->set($value)->expiresAfter($this->ttl)
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getSetting(string $section, string $key, ?string $owner = null)
    {
        $cacheKey = $this->getCacheKey($section, $key, $owner);

        if ($this->cache->hasItem($cacheKey)) {
            return $this->cache->getItem($cacheKey)->get();
        }

        $value = $this->decoratedManager->getSetting($section, $key, $owner);

        $this->cache->save(
            $this->cache->getItem($cacheKey)->set($value)->expiresAfter($this->ttl)
        );

        return $value;
    }

    /**
     * {@inheritdoc}
     */
    public function flush(): void
    {
        $this->decoratedManager->flush();
    }

    /**
     * {@inheritdoc}
     */
    public function get(string $path, ?string $owner = null)
    {
        @list($section, $key) = explode('.', $path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return $this->getSetting($section, $key, $owner);
    }

    /**
     * {@inheritdoc}
     */
    public function set(string $path, $value, ?string $owner = null): void
    {
        @list($section, $key) = explode('.', $path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $this->setSetting($section, $key, $value, $owner, true);
    }
}


1			<?php
2
3			/*
4			* This file is part of the PhpMob package.
5			*
6			* (c) Ishmael Doss <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace PhpMob\Settings\Manager;
15
16			use Psr\Cache\CacheItemPoolInterface;
17
18			/**
19			* @author Ishmael Doss <[email protected]>
20			*/
21			class CachedManager implements SettingManagerInterface
22			{
23			/**
24			* @var CacheItemPoolInterface
25			*/
26			private $cache;
27
28			/**
29			* @var int\|\DateInterval\|null
30			*/
31			private $ttl = 0;
32
33			/**
34			* @var SettingManagerInterface
35			*/
36			private $decoratedManager;
37
38			public function __construct(SettingManagerInterface $manager, CacheItemPoolInterface $cache, $ttl = 0)
39			{
40			$this->decoratedManager = $manager;
41			$this->cache = $cache;
42			$this->ttl = $ttl;
43			}
44
45			/**
46			* @param $section
47			* @param $key
48			* @param string\|null $owner
49			*
50			* @return string
51			*/
52			private function getCacheKey($section, $key, ?string $owner = null)
53			{
54			return 'phpmob-settings.' . ($owner
55			? sprintf('%s.%s.%s', $section, $key, $owner)
56			: sprintf('%s.%s', $section, $key)
57			);
58			}
59
60			/**
61			* {@inheritdoc}
62			*/
63			public function setSetting(string $section, string $key, $value, ?string $owner = null, $autoFlush = false): void
64			{
65			$cacheKey = $this->getCacheKey($section, $key, $owner);
66
67			if ($this->cache->hasItem($cacheKey) && $value === $this->cache->getItem($cacheKey)->get()) {
68			return;
69			}
70
71			$this->decoratedManager->setSetting($section, $key, $value, $owner, $autoFlush);
72
73			$this->cache->save(
74			$this->cache->getItem($cacheKey)->set($value)->expiresAfter($this->ttl)
75			);
76			}
77
78			/**
79			* {@inheritdoc}
80			*/
81			public function getSetting(string $section, string $key, ?string $owner = null)
82			{
83			$cacheKey = $this->getCacheKey($section, $key, $owner);
84
85			if ($this->cache->hasItem($cacheKey)) {
86			return $this->cache->getItem($cacheKey)->get();
87			}
88
89			$value = $this->decoratedManager->getSetting($section, $key, $owner);
90
91			$this->cache->save(
92			$this->cache->getItem($cacheKey)->set($value)->expiresAfter($this->ttl)
93			);
94
95			return $value;
96			}
97
98			/**
99			* {@inheritdoc}
100			*/
101			public function flush(): void
102			{
103			$this->decoratedManager->flush();
104			}
105
106			/**
107			* {@inheritdoc}
108			*/
109			public function get(string $path, ?string $owner = null)
110			{
111			@list($section, $key) = explode('.', $path);
			0 ignored issues – show Security Best Practice introduced 2017-12-26 12:06 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
112
113			return $this->getSetting($section, $key, $owner);
114			}
115
116			/**
117			* {@inheritdoc}
118			*/
119			public function set(string $path, $value, ?string $owner = null): void
120			{
121			@list($section, $key) = explode('.', $path);
			0 ignored issues – show Security Best Practice introduced 2017-12-26 12:06 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
122
123			$this->setSetting($section, $key, $value, $owner, true);
124			}
125			}
126

phpmob / settings

CachedManager::getSetting() A last analyzed 2018-02-10 12:17 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CachedManager::getSetting() A
last analyzed 2018-02-10 12:17 UTC