phpmetrics / PhpMetrics

src/Hal/Metrics/Complexity/Structural/CardAndAgresti/FileSystemComplexity.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
         $len = 0;
         $sy = $dc = $sc = array();
         $calculator = new SystemComplexity();
-        foreach($rOOP->getClasses() as $class) {
+        foreach ($rOOP->getClasses() as $class) {
             $r = $calculator->calculate($class);
 
             $len += sizeof($class->getMethods(), COUNT_NORMAL);
@@ -58,7 +58,7 @@ 
             $sc[] = $r->getTotalStructuralComplexity();
         }
 
-        if($len > 0 &&sizeof($dc, COUNT_NORMAL) > 0) {
+        if ($len > 0 && sizeof($dc, COUNT_NORMAL) > 0) {
             $result
                 ->setRelativeStructuralComplexity(round(array_sum($sc) / $len, 2))
                 ->setRelativeDataComplexity(round(array_sum($dc) / $len, 2))

src/Hal/Metrics/Complexity/Structural/CardAndAgresti/SystemComplexity.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 
 
         $sy = $dc = $sc = array(); // in system
-        foreach($class->getMethods() as $method) {
+        foreach ($class->getMethods() as $method) {
             $fanout = sizeof($method->getDependencies(), COUNT_NORMAL);
             $v = sizeof($method->getArguments(), COUNT_NORMAL) + sizeof($method->getReturns(), COUNT_NORMAL);
 

src/Hal/Metrics/Complexity/Structural/HenryAndKafura/Coupling.php

Spacing +7 added lines, -7 removed lines

@@ -29,8 +29,8 @@ 
         $map = $this->extractCoupling($result);
 
         // instability
-        foreach($map as &$class) {
-            if($class->getAfferentCoupling() + $class->getEfferentCoupling() > 0) {
+        foreach ($map as &$class) {
+            if ($class->getAfferentCoupling() + $class->getEfferentCoupling() > 0) {
                 $class->setInstability($class->getEfferentCoupling() / ($class->getAfferentCoupling() + $class->getEfferentCoupling()));
             }
         }
@@ -49,22 +49,22 @@ 
         $results = $result->all();
 
         $classes = array();
-        foreach($results as $result) {
+        foreach ($results as $result) {
             $classes = array_merge($classes, $result->getClasses());
         }
 
         $map = array();
-        foreach($classes as $class) {
+        foreach ($classes as $class) {
 
-            if(!isset($map[$class->getFullname()])) {
+            if (!isset($map[$class->getFullname()])) {
                 $map[$class->getFullname()] = new Result($class->getFullname());
             }
 
             $dependencies = $class->getDependencies();
             $map[$class->getFullname()]->setEfferentCoupling(sizeof($dependencies, COUNT_NORMAL));
 
-            foreach($dependencies as $dependency) {
-                if(!isset($map[$dependency])) {
+            foreach ($dependencies as $dependency) {
+                if (!isset($map[$dependency])) {
                     $map[$dependency] = new Result($dependency);
                 }
                 $map[$dependency]->setAfferentCoupling($map[$dependency]->getAfferentCoupling() + 1);

src/Hal/Metrics/Complexity/Structural/HenryAndKafura/FileCoupling.php

Spacing +3 added lines, -3 removed lines

@@ -54,21 +54,21 @@
         $result = new Result($filename);
 
         // case of file doesn't contain any class
-        if(null === $rOOP) {
+        if (null === $rOOP) {
             return $result;
         }
 
         $instability = $ce = $ca = 0;
 
         $classes = $rOOP->getClasses();
-        foreach($classes as $declaredClass) {
+        foreach ($classes as $declaredClass) {
             $declaredClassCoupling = $this->couplingMap->get($declaredClass->getFullname());
 
             $ce += $declaredClassCoupling->getEfferentCoupling();
             $ca += $declaredClassCoupling->getAfferentCoupling();
         }
 
-        if($ca + $ce > 0) {
+        if ($ca + $ce > 0) {
             $instability = $ce / ($ca + $ce);
         }
 

src/Hal/Metrics/Complexity/Structural/LCOM/FileLackOfCohesionOfMethods.php

Spacing +2 added lines, -2 removed lines

@@ -50,9 +50,9 @@
         $n = 0;
         $lcom = new LackOfCohesionOfMethods();
 
-        foreach($rOOP->getClasses() as $class) {
+        foreach ($rOOP->getClasses() as $class) {
 
-            if($class instanceof ReflectedInterface) {
+            if ($class instanceof ReflectedInterface) {
                 continue;
             }
 

src/Hal/Metrics/Complexity/Structural/LCOM/LackOfCohesionOfMethods.php

Spacing +15 added lines, -15 removed lines

@@ -34,13 +34,13 @@ 
         $methodsToInspect = $class->getMethods();
 
         $toSkip = array();
-        foreach($methodsToInspect as $method) {
+        foreach ($methodsToInspect as $method) {
 
-            if(in_array($method->getName(), $toSkip)) {
+            if (in_array($method->getName(), $toSkip)) {
                 continue;
             }
 
-            if($method->isSetter() ||$method->isGetter()) {
+            if ($method->isSetter() || $method->isGetter()) {
                 continue;
             }
 
@@ -78,8 +78,8 @@ 
 
         // foreach directly linked methods, recurs
         $methods = $class->getMethods();
-        foreach($linked as $link) {
-            if(!isset( $methods[$link])) {
+        foreach ($linked as $link) {
+            if (!isset($methods[$link])) {
                 continue;
             }
             $linked = array_merge($linked, $this->getLinkedMethods($class, $methods[$link], $toSkip));
@@ -99,18 +99,18 @@ 
         $linked = array();
 
         // A calls B
-        if(preg_match_all('!\\$this\\->(\w*?)\\(!im', $method->getContent(), $matches)) {
+        if (preg_match_all('!\\$this\\->(\w*?)\\(!im', $method->getContent(), $matches)) {
             list(, $linked) = $matches;
         }
 
         // B calls A
-        foreach($class->getMethods() as $otherMethod) {
+        foreach ($class->getMethods() as $otherMethod) {
             $otherCalls = array();
-            if(preg_match_all('!\\$this\\->(\w*?)\\(!im', $otherMethod->getContent(), $matches)) {
+            if (preg_match_all('!\\$this\\->(\w*?)\\(!im', $otherMethod->getContent(), $matches)) {
                 list(, $otherCalls) = $matches;
             }
 
-            if(in_array($method->getName(), $otherCalls)) {
+            if (in_array($method->getName(), $otherCalls)) {
                 array_push($linked, $otherMethod->getName());
             }
         }
@@ -128,29 +128,29 @@ 
 
         $linked = array();
         $members = array();
-        if(preg_match_all('!\\$this\\->([\w\\(]+)!im', $method->getContent(), $matches)) {
+        if (preg_match_all('!\\$this\\->([\w\\(]+)!im', $method->getContent(), $matches)) {
             list(, $members) = $matches;
         }
 
 
         // search in other methods if they share attribute
-        foreach($class->getMethods() as $otherMethod) {
+        foreach ($class->getMethods() as $otherMethod) {
             $otherMembers = array();
-            if(preg_match_all('!\\$this\\->([\w\\(]+)!im', $otherMethod->getContent(), $matches)) {
+            if (preg_match_all('!\\$this\\->([\w\\(]+)!im', $otherMethod->getContent(), $matches)) {
                 list(, $otherMembers) = $matches;
             }
 
             $intersect = array_intersect($members, $otherMembers);
 
             // remove calls (members and calls are mixed : regex is too complex to be read)
-            foreach($intersect as $k => $name) {
-                if(preg_match('!\($!', $name)) {
+            foreach ($intersect as $k => $name) {
+                if (preg_match('!\($!', $name)) {
                     unset($intersect[$k]);
                 }
             }
 
 
-            if(sizeof($intersect, COUNT_NORMAL) > 0) {
+            if (sizeof($intersect, COUNT_NORMAL) > 0) {
 
                 array_push($linked, $otherMethod->getName());
             }

src/Hal/Metrics/Complexity/Text/Halstead/Halstead.php

Spacing +12 added lines, -12 removed lines

@@ -77,11 +77,11 @@ 
 
         $tokens = $this->tokenizer->tokenize($filename);
 
-        foreach($tokens as $token) {
-            if($this->tokenType->isOperator($token)) {
+        foreach ($tokens as $token) {
+            if ($this->tokenType->isOperator($token)) {
                 $this->operators[] = $token;
             }
-            else if($this->tokenType->isOperand($token)) {
+            else if ($this->tokenType->isOperand($token)) {
                 $this->operands[] = $token;
             }
         }
@@ -99,23 +99,23 @@ 
         $this->inventory($filename);
         $result = new Result;
 
-        $uniqueOperators = array_map( 'unserialize', array_unique( array_map( 'serialize', $this->operators ) ) );
-        $uniqueOperands = array_map( 'unserialize', array_unique( array_map( 'serialize', $this->operands ) ) );
+        $uniqueOperators = array_map('unserialize', array_unique(array_map('serialize', $this->operators)));
+        $uniqueOperands = array_map('unserialize', array_unique(array_map('serialize', $this->operands)));
 
         $n1 = sizeof($uniqueOperators, COUNT_NORMAL);
         $n2 = sizeof($uniqueOperands, COUNT_NORMAL);
         $N1 = sizeof($this->operators, COUNT_NORMAL);
         $N2 = sizeof($this->operands, COUNT_NORMAL);
 
-        if(($n2 == 0)||($N2 == 0)||($n2 == 2)) {
+        if (($n2 == 0) || ($N2 == 0) || ($n2 == 2)) {
             // files without operators
             $V = $n1 = $n2 = $N1 = $N2 = $E = $D = $B = $T = $I = $L = 0;
         } else {
             $devAbility = 3000;
             $N = $N1 + $N2;
             $n = $n1 + $n2;
-            $V = $N * log($n ,2);
-            $L = (2 / max(1,$n1)) * ($n2 / $N2);
+            $V = $N * log($n, 2);
+            $L = (2 / max(1, $n1)) * ($n2 / $N2);
             $D = ($n1 / 2) * ($N2 / $n2);
             $E = $V * $D;
             $B = $V / $devAbility;
@@ -126,13 +126,13 @@ 
         $result
             ->setLength($N1 + $N2)
             ->setVocabulary($n1 + $n2)
-            ->setVolume(round($V,2))
-            ->setDifficulty(round($D,2))
-            ->setEffort(round($E,2))
+            ->setVolume(round($V, 2))
+            ->setDifficulty(round($D, 2))
+            ->setEffort(round($E, 2))
             ->setLevel(round($L, 2))
             ->setBugs(round($B, 2))
             ->setTime(round($T))
-            ->setIntelligentContent(round($I,2))
+            ->setIntelligentContent(round($I, 2))
             ->setNumberOfOperators($N1)
             ->setNumberOfOperands($N2)
             ->setNumberOfUniqueOperators($n1)

Braces +1 added lines, -2 removed lines

@@ -80,8 +80,7 @@
         foreach($tokens as $token) {
             if($this->tokenType->isOperator($token)) {
                 $this->operators[] = $token;
-            }
-            else if($this->tokenType->isOperand($token)) {
+            } else if($this->tokenType->isOperand($token)) {
                 $this->operands[] = $token;
             }
         }

src/Hal/Metrics/Complexity/Text/Length/Loc.php

Spacing +3 added lines, -3 removed lines

@@ -48,11 +48,11 @@
         $content = file_get_contents($filename);
 
         $cloc = $lloc = 0;
-        foreach($tokens as $token) {
+        foreach ($tokens as $token) {
 
-            switch($token->getType()) {
+            switch ($token->getType()) {
                 case T_STRING:
-                    if(';' == $token->getValue()) {
+                    if (';' == $token->getValue()) {
                         $lloc++;
                     }
                     break;

src/Hal/Metrics/Complexity/Text/Length/Result.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      * @inheritdoc
      */
     public function asArray() {
-        return array (
+        return array(
             'loc' => $this->getLoc()
             ,'logicalLoc' => $this->getLogicalLoc()
         );