Hal\Metric\Class_\Coupling\ExternalsVisitor::leaveNode()

Complexity

Conditions	24
Paths	1504

Size

Total Lines	89
Code Lines	43

Duplication

Lines	10
Ratio	11.24 %

Importance

Changes

0

<?php
    public function leaveNode(Node $node)
    {

        if ($node instanceof Stmt\Namespace_) {
            $this->uses = [];
        }

        if ($node instanceof Stmt\Use_) {
            $this->uses = array_merge($this->uses, $node->uses);

It seems like array_merge($this->uses, $node->uses) of type array is incompatible with the declared type array<integer,object<PhpParser\Node\Stmt\Use_>> of property $uses.

        }

        if ($node instanceof Stmt\Class_
            || $node instanceof Stmt\Interface_
        ) {

            $class = $this->metrics->get($node->namespacedName->toString());

Are you sure the assignment to $class is correct as $this->metrics->get($node->namespacedName->toString()) (which targets Hal\Metric\Metrics::get()) seems to always return null.

            $nodeClass = $node;

$nodeClass is not used, you could remove the assignment.

            $dependencies = [];

            // extends
            if (isset($node->extends)) {
                if (is_array($node->extends)) {
                    foreach ((array)$node->extends as $interface) {
                        array_push($dependencies, (string)$interface);
                    }
                } else {
                    array_push($dependencies, (string)$node->extends);
                }
            }

            // implements
            if (isset($node->implements)) {
                foreach ($node->implements as $interface) {
                    array_push($dependencies, (string)$interface);
                }
            }

            foreach ($node->stmts as $stmt) {
                if ($stmt instanceof Stmt\ClassMethod) {


                    // return
                    if (isset($stmt->returnType)) {
                        if ($stmt->returnType instanceof Node\Name\FullyQualified) {
                            array_push($dependencies, (string)$stmt->returnType);
                        }
                    }

                    // Type hint of method's parameters
                    foreach ($stmt->params as $param) {
                        if ($param->type) {
                            if ($param->type instanceof Node\Name\FullyQualified) {
                                array_push($dependencies, (string)$param->type);
                            }
                        }
                    }

                    // instanciations, static calls
                    \iterate_over_node($stmt, function ($node) use (&$dependencies) {
                        switch (true) {

This code seems to be duplicated across your project.

                            case $node instanceof Node\Expr\New_:
                                // new MyClass
                                array_push($dependencies, getNameOfNode($node));
                                break;
                            case $node instanceof Node\Expr\StaticCall:
                                // MyClass::Call
                                array_push($dependencies, getNameOfNode($node));
                                break;
                        }
                    });

                    // annotations
                    $comments = $stmt->getDocComment();
                    if ($comments && false !== preg_match_all('!\s+\*\s+@(\w+)!', $comments->getText(), $matches)) {
                        foreach ($matches[1] as $check) {
                            foreach ($this->uses as $use) {
                                if ($use->alias === $check) {
                                    array_push($dependencies, (string)($use->name));
                                }
                            }
                        }
                    }
                }
            }

            $class->set('externals', $dependencies);

The method set cannot be called on $class (of type null).

        }
    }
}