Hal\Application\Command\Job\QueueReportFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	66
Duplicated Lines	10.61 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	factory()	0	18	1

<?php

/*
 * (c) Jean-François Lépine <https://twitter.com/Halleck45>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Hal\Application\Command\Job;
use Hal\Application\Extension\ExtensionService;
use Hal\Application\Extension\extensionsService;
use Hal\Application\Extension\Repository;
use Hal\Application\Formater\Chart;
use Hal\Application\Formater\Details;
use Hal\Application\Formater\Summary;
use Hal\Application\Formater\Violations;
use Hal\Application\Score\Scoring;
use Hal\Component\Aggregator\DirectoryAggregatorFlat;
use Hal\Component\Bounds\BoundsInterface;
use Hal\Component\Config\ConfigurationInterface;
use Hal\Component\File\Finder;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Queue factory
 *
 * @author Jean-François Lépine <https://twitter.com/Halleck45>
 */
class QueueReportFactory
{

    /**
     * @var ConfigurationInterface
     */
    private $config;

    /**
     * @var OutputInterface
     */
    private $output;

    /**
     * @var InputInterface
     */
    private $input;

    /**
     * @var ExtensionService
     */
    private $extensionsService;

    /**
     * Constructor
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     * @param ConfigurationInterface $config
     * @param ExtensionService $extensionsService
     */
    public function __construct(InputInterface $input, OutputInterface $output, ConfigurationInterface $config, ExtensionService $extensionsService)

This method seems to be duplicated in your project.

    {
        $this->config = $config;
        $this->input = $input;
        $this->output = $output;
        $this->extensionsService = $extensionsService;
    }

    /**
     * Factory queue
     *
     * @param Finder $finder
     * @param BoundsInterface $bounds
     * @return Queue
     */
    public function factory(Finder $finder, BoundsInterface $bounds) {

The parameter $finder is not used and could be removed.

        $rules = $this->config->getRuleSet();
        $validator = new \Hal\Application\Rule\Validator($rules);

        // jobs queue planning
        $queue = new Queue;
        $queue
            ->push(new ReportRenderer(true, $this->output, new Summary\Cli($validator, $bounds, $this->output, $this->extensionsService)))
            ->push(new ReportRenderer($this->config->getLogging()->getReport('cli'), $this->output, new Details\Cli($validator, $bounds, $this->extensionsService)))
            ->push(new ReportWriter($this->config->getLogging()->getReport('html'), $this->output, new Summary\Html($validator, $bounds, $this->config->getTemplate(), $this->extensionsService)))
            ->push(new ReportWriter($this->config->getLogging()->getReport('json'), $this->output, new Details\Json(true, $this->extensionsService)))
            ->push(new ReportWriter($this->config->getLogging()->getReport('xml'), $this->output, new Summary\Xml($validator, $bounds, $this->extensionsService)))
            ->push(new ReportWriter($this->config->getLogging()->getReport('csv'), $this->output, new Details\Csv($this->extensionsService)))
            ->push(new ReportWriter($this->config->getLogging()->getViolation('xml'), $this->output, new Violations\Xml($validator, $bounds, $this->extensionsService)))
            ->push(new ReportWriter($this->config->getLogging()->getChart('bubbles'), $this->output, new Chart\Bubbles($validator, $bounds, $this->extensionsService)));

The call to Bubbles::__construct() has too many arguments starting with $this->extensionsService.

        return $queue;
    }

}