phpmetrics / PhpMetrics

src/Hal/Component/OOP/Extractor/CallExtractor.php

Spacing +6 added lines, -6 removed lines

@@ -52,12 +52,12 @@ 
 
         $token = $tokens[$n];
         $call = null;
-        switch($token->getType()) {
+        switch ($token->getType()) {
             case T_PAAMAYIM_NEKUDOTAYIM:
                 $prev = $n - 1;
                 $value = $this->searcher->getUnder(array('::'), $prev, $tokens);
 
-                switch(true) {
+                switch (true) {
                     case $value == 'parent' && $this->currentClass:
                         return $this->currentClass->getParent();
 
@@ -66,10 +66,10 @@ 
                         $extendPosition = $this->searcher->getExtendPosition($tokens, $n);
                         return $this->searcher->getFollowingName($extendPosition, $tokens);
 
-                    case ($value == 'static' ||$value === 'self')&& $this->currentClass:
+                    case ($value == 'static' || $value === 'self') && $this->currentClass:
                         return $this->currentClass->getFullname();
 
-                    case ($value == 'static' ||$value === 'self'):
+                    case ($value == 'static' || $value === 'self'):
                         $extendPosition = $this->searcher->getClassNamePosition($tokens);
                         return $this->searcher->getFollowingName($extendPosition, $tokens);
 
@@ -79,12 +79,12 @@ 
 
             case T_NEW:
                 $call = $this->searcher->getFollowingName($n, $tokens);
-                if(preg_match('!^(\w+)!', $call, $matches)) { // fixes PHP 5.4:    (new MyClass)->foo()
+                if (preg_match('!^(\w+)!', $call, $matches)) { // fixes PHP 5.4:    (new MyClass)->foo()
                     $call = $matches[1];
                 }
                 break;
         }
-        if(null === $call) {
+        if (null === $call) {
             throw new \LogicException('Classname of call not found');
         }
         return $call;

src/Hal/Component/OOP/Extractor/ClassExtractor.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     {
         // is PHP7 ?
         $previous = $tokens->get($n - 2);
-        if($previous && T_NEW === $previous->getType()) {
+        if ($previous && T_NEW === $previous->getType()) {
             // anonymous class
             $class = new ReflectedAnonymousClass($this->namespace, 'class@anonymous');
             return $class;

src/Hal/Component/OOP/Extractor/ClassMap.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
      * @return $this
      */
     public function push($filename, Result $result) {
-        $this->classes[$filename] = $result;;
+        $this->classes[$filename] = $result; ;
         return $this;
     }
 

src/Hal/Component/OOP/Extractor/MethodExtractor.php

Spacing +32 added lines, -32 removed lines

@@ -55,7 +55,7 @@ 
         $start = $n;
 
         $declaration = $this->searcher->getUnder(array(')'), $n, $tokens);
-        if(!preg_match('!function\s+(.*)\(\s*(.*)!is', $declaration, $matches)) {
+        if (!preg_match('!function\s+(.*)\(\s*(.*)!is', $declaration, $matches)) {
             throw new \Exception(sprintf("Closure detected instead of method\nDetails:\n%s", $declaration));
         }
         list(, $name, $args) = $matches;
@@ -68,21 +68,21 @@ 
         $this->extractState($method, $p = $start, $tokens); // please keep "p = start"
 
         $arguments = preg_split('!\s*,\s*!m', $args);
-        foreach($arguments as $argDecl) {
+        foreach ($arguments as $argDecl) {
 
-            if(0 == strlen($argDecl)) {
+            if (0 == strlen($argDecl)) {
                 continue;
             }
 
             $elems = preg_split('!([\s=]+)!', $argDecl);
             $isRequired = 2 == sizeof($elems, COUNT_NORMAL);
 
-            if(sizeof($elems, COUNT_NORMAL) == 1) {
+            if (sizeof($elems, COUNT_NORMAL) == 1) {
                 list($name, $type) = array_pad($elems, 2, null);
             } else {
-                if('$' == $elems[0][0]) {
+                if ('$' == $elems[0][0]) {
                     $name = $elems[0];
-                    $type  = null;
+                    $type = null;
                     $isRequired = false;
                 } else {
                     list($type, $name) = array_pad($elems, 2, null);
@@ -96,9 +96,9 @@ 
 
 
         // does method has body ? (example: interface ; abstract classes)
-        $p = $n  + 1;
+        $p = $n + 1;
         $underComma = trim($this->searcher->getUnder(array(';'), $p, $tokens));
-        if(strlen($underComma) > 0) {
+        if (strlen($underComma) > 0) {
             //
             // Body
             $this->extractContent($method, $n, $tokens);
@@ -108,7 +108,7 @@ 
 
             // Tokens
             $end = $this->searcher->getPositionOfClosingBrace($n, $tokens);
-            if($end > 0) {
+            if ($end > 0) {
                 $method->setTokens($tokens->extract($n, $end));
             }
         } else {
@@ -138,7 +138,7 @@ 
      * @return $this
      */
     public function extractVisibility(ReflectedMethod $method, $n, TokenCollection $tokens) {
-        switch(true) {
+        switch (true) {
             case $this->searcher->isPrecededBy(T_PRIVATE, $n, $tokens, 4):
                 $visibility = ReflectedMethod::VISIBILITY_PRIVATE;
                 break;
@@ -163,7 +163,7 @@ 
      * @return $this
      */
     public function extractState(ReflectedMethod $method, $n, TokenCollection $tokens) {
-        if($this->searcher->isPrecededBy(T_STATIC, $n, $tokens, 4)) {
+        if ($this->searcher->isPrecededBy(T_STATIC, $n, $tokens, 4)) {
             $method->setState(ReflectedMethod::STATE_STATIC);
         }
         return $this;
@@ -179,7 +179,7 @@ 
      */
     private function extractContent(ReflectedMethod $method, $n, TokenCollection $tokens) {
         $end = $this->searcher->getPositionOfClosingBrace($n, $tokens);
-        if($end > 0) {
+        if ($end > 0) {
             $collection = $tokens->extract($n, $end);
             $method->setContent($collection->asString());
         }
@@ -202,13 +202,13 @@ 
         $extractor = new CallExtractor($this->searcher, $currentClass);
         $start = $n;
         $len = sizeof($tokens, COUNT_NORMAL);
-        for($i = $start; $i < $len; $i++) {
+        for ($i = $start; $i < $len; $i++) {
             $token = $tokens[$i];
-            switch($token->getType()) {
+            switch ($token->getType()) {
                 case T_PAAMAYIM_NEKUDOTAYIM:
                 case T_NEW:
                     $call = $extractor->extract($i, $tokens, $currentClass);
-                    if($call !== 'class') { // anonymous class
+                    if ($call !== 'class') { // anonymous class
                         $method->pushDependency($call);
                         $method->pushInstanciedClass($call);
                     }
@@ -219,9 +219,9 @@ 
         //
         // Parameters in Method API
         $resolver = new TypeResolver();
-        foreach($method->getArguments() as $argument) {
+        foreach ($method->getArguments() as $argument) {
             $name = $argument->getType();
-            if(strlen($name) > 0 && !$resolver->isNative($name)) {
+            if (strlen($name) > 0 && !$resolver->isNative($name)) {
                 $method->pushDependency($name);
             }
         }
@@ -240,10 +240,10 @@ 
     private function extractCalls(ReflectedMethod $method, $n, TokenCollection $tokens) {
 
         // $this->foo(), $c->foo()
-        if(preg_match_all('!(\$[\w]*)\-\>(\w*?)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
-            foreach($matches as $m) {
+        if (preg_match_all('!(\$[\w]*)\-\>(\w*?)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
+            foreach ($matches as $m) {
                 $function = $m[2];
-                if('$this' == $m[1]) {
+                if ('$this' == $m[1]) {
                     $method->pushInternalCall($function);
                 } else {
                     $method->pushExternalCall($m[1], $function);
@@ -251,8 +251,8 @@ 
             }
         }
         // (new X)->foo()
-        if(preg_match_all('!\(new (\w+?).*?\)\->(\w+)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
-            foreach($matches as $m) {
+        if (preg_match_all('!\(new (\w+?).*?\)\->(\w+)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
+            foreach ($matches as $m) {
                 $method->pushExternalCall($m[1], $m[2]);
             }
         }
@@ -272,9 +272,9 @@ 
         // we cannot use specific token. The ":" delimiter is a T_STRING token
         // in regex we match ":" followed by any character except another ":"
         $following = $this->searcher->getUnder(array('{', ';'), $n, $tokens);
-        if(preg_match('@(?<!:):\s*(\w+)@', $following, $matches)) {
+        if (preg_match('@(?<!:):\s*(\w+)@', $following, $matches)) {
             $type = trim($matches[1]);
-            if(empty($type)) {
+            if (empty($type)) {
                 return $this;
             }
             $return = new ReflectedReturn($type, ReflectedReturn::VALUE_UNKNOW, ReflectedReturn::STRICT_TYPE_HINT);
@@ -283,8 +283,8 @@ 
         }
 
         // array of available values based on code
-        if(preg_match_all('!([\s;]return\s|^return\s+)(.*?);!', $method->getContent(), $matches)) {
-            foreach($matches[2] as $m) {
+        if (preg_match_all('!([\s;]return\s|^return\s+)(.*?);!', $method->getContent(), $matches)) {
+            foreach ($matches[2] as $m) {
                 $value = trim($m, ";\t\n\r\0\x0B");
                 $return = new ReflectedReturn($resolver->resolve($m), $value, ReflectedReturn::ESTIMATED_TYPE_HINT);
                 $method->pushReturn($return);
@@ -302,21 +302,21 @@ 
     private function extractUsage(ReflectedMethod $method) {
         $tokens = $method->getTokens();
         $codes = $values = array();
-        foreach($tokens as $token) {
-            if(in_array($token->getType(), array(T_WHITESPACE, T_BOOL_CAST, T_INT_CAST, T_STRING_CAST, T_DOUBLE_CAST, T_OBJECT_CAST))) {
+        foreach ($tokens as $token) {
+            if (in_array($token->getType(), array(T_WHITESPACE, T_BOOL_CAST, T_INT_CAST, T_STRING_CAST, T_DOUBLE_CAST, T_OBJECT_CAST))) {
                 continue;
             }
             array_push($codes, $token->getType());
             array_push($values, $token->getValue());
         }
-        switch(true) {
-            case preg_match('!^(get)|(is)|(has).*!',$method->getName()) && $codes == array(T_RETURN, T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING):
+        switch (true) {
+            case preg_match('!^(get)|(is)|(has).*!', $method->getName()) && $codes == array(T_RETURN, T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING):
                 $method->setUsage(MethodUsage::USAGE_GETTER);
                 break;
             // basic setter
-            case preg_match('!^set.*!',$method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR,T_STRING,T_STRING, T_VARIABLE, T_STRING) && $values[3] == '=':
+            case preg_match('!^set.*!', $method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING, T_VARIABLE, T_STRING) && $values[3] == '=':
             // fluent setter
-            case preg_match('!^set.*!',$method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR,T_STRING,T_STRING, T_VARIABLE, T_STRING, T_RETURN, T_VARIABLE, T_STRING)
+            case preg_match('!^set.*!', $method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING, T_VARIABLE, T_STRING, T_RETURN, T_VARIABLE, T_STRING)
                 && $values[3] == '=' && $values[7] == '$this':
                 $method->setUsage(MethodUsage::USAGE_SETTER);
                 break;

src/Hal/Component/OOP/Extractor/Result.php

Spacing +9 added lines, -9 removed lines

@@ -31,7 +31,7 @@ 
     public function asArray() {
 
         $nom = 0;
-        foreach($this->getClasses() as $class) {
+        foreach ($this->getClasses() as $class) {
             $nom += sizeof($class->getMethods(), COUNT_NORMAL);
         }
 
@@ -71,8 +71,8 @@ 
      */
     public function getAbstractClasses() {
         $result = array();
-        foreach($this->getClasses() as $class) {
-            if($class->isAbstract() ||$class instanceof ReflectedInterface) {
+        foreach ($this->getClasses() as $class) {
+            if ($class->isAbstract() || $class instanceof ReflectedInterface) {
                 array_push($result, $class);
             }
         }
@@ -86,8 +86,8 @@ 
      */
     public function getAnonymousClasses() {
         $result = array();
-        foreach($this->getClasses() as $class) {
-            if($class instanceof ReflectedClass\ReflectedAnonymousClass) {
+        foreach ($this->getClasses() as $class) {
+            if ($class instanceof ReflectedClass\ReflectedAnonymousClass) {
                 array_push($result, $class);
             }
         }
@@ -101,8 +101,8 @@ 
      */
     public function getInterfaces() {
         $result = array();
-        foreach($this->getClasses() as $class) {
-            if($class instanceof ReflectedInterface) {
+        foreach ($this->getClasses() as $class) {
+            if ($class instanceof ReflectedInterface) {
                 array_push($result, $class);
             }
         }
@@ -116,8 +116,8 @@ 
      */
     public function getConcreteClasses() {
         $result = array();
-        foreach($this->getClasses() as $class) {
-            if(!$class->isAbstract() &&!$class instanceof ReflectedInterface  && !$class instanceof ReflectedClass\ReflectedAnonymousClass) {
+        foreach ($this->getClasses() as $class) {
+            if (!$class->isAbstract() && !$class instanceof ReflectedInterface && !$class instanceof ReflectedClass\ReflectedAnonymousClass) {
                 array_push($result, $class);
             }
         }

src/Hal/Component/OOP/Reflected/ReflectedClass.php

Spacing +5 added lines, -5 removed lines

@@ -136,11 +136,11 @@ 
     public function getDependencies()
     {
         $dependencies = array();
-        foreach($this->getMethods() as $method) {
+        foreach ($this->getMethods() as $method) {
             $dependencies = array_merge($dependencies, $method->getDependencies());
         }
-        foreach($dependencies as &$name) {
-            if(in_array($name, array('self', 'static'))) {
+        foreach ($dependencies as &$name) {
+            if (in_array($name, array('self', 'static'))) {
                 $name = $this->getFullname();
             }
             $name = $this->nameResolver->resolve($name, $this->namespace);
@@ -207,7 +207,7 @@ 
     public function getInterfaces()
     {
         $resolvedInterfaces = array();
-        foreach($this->interfaces as $interface) {
+        foreach ($this->interfaces as $interface) {
             array_push($resolvedInterfaces, $this->nameResolver->resolve($interface, $this->namespace));
         }
         return $resolvedInterfaces;
@@ -230,7 +230,7 @@ 
      */
     public function getAnonymousClasses() {
         $result = array();
-        foreach($this->methods as $method) {
+        foreach ($this->methods as $method) {
             $result = array_merge($result, $method->getAnonymousClasses());
         }
         return $result;

src/Hal/Component/OOP/Reflected/ReflectedMethod.php

Spacing +7 added lines, -7 removed lines

@@ -189,10 +189,10 @@ 
         // on read : compare with aliases. We cannot make it in pushDependency() => aliases aren't yet known
         $result = array();
         $resolver = new TypeResolver();
-        foreach($this->returns as $return) {
+        foreach ($this->returns as $return) {
             $type = $this->nameResolver->resolve($return->getType(), null);
 
-            if("\\" !== $type[0] &&!$resolver->isNative($type)) {
+            if ("\\" !== $type[0] && !$resolver->isNative($type)) {
                 $type = $this->namespace.'\\'.$type;
             }
 
@@ -233,21 +233,21 @@ 
     {
         // on read : compare with aliases. We cannot make it in pushDependency() => aliases aren't yet known
         $dependencies = array();
-        foreach($this->dependencies as $name) {
+        foreach ($this->dependencies as $name) {
             array_push($dependencies, $this->nameResolver->resolve($name, null));
         }
 
         // returned values
         $resolver = new TypeResolver();
-        foreach($this->returns as $return) {
+        foreach ($this->returns as $return) {
             $name = $return->getType();
-            if(!$resolver->isNative($name)) {
+            if (!$resolver->isNative($name)) {
                 array_push($dependencies, $this->nameResolver->resolve($name, null));
             }
         }
 
         // anonymous classes in method (inner class)
-        foreach($this->anonymousClasses as $c) {
+        foreach ($this->anonymousClasses as $c) {
             array_push($dependencies, $c->getParent());
             $dependencies = array_merge($dependencies, $c->getDependencies());
         }
@@ -379,7 +379,7 @@ 
     public function getInstanciedClasses()
     {
         $classes = array();
-        foreach($this->instanciedClasses as $name) {
+        foreach ($this->instanciedClasses as $name) {
             array_push($classes, $this->nameResolver->resolve($name, null));
         }
         return $classes;

src/Hal/Component/OOP/Resolver/NameResolver.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
         }
 
         // anonymous class
-        if('class@anonymous' == $name ) {
+        if ('class@anonymous' == $name) {
             return $name;
         }
 

src/Hal/Component/OOP/Resolver/TypeResolver.php

Spacing +11 added lines, -11 removed lines

@@ -41,47 +41,47 @@
         $string = $cased = trim($string, ";\t\n\r\0\x0B");
         $string = strtolower($string);
 
-        if(strlen($string) == 0) {
+        if (strlen($string) == 0) {
             return self::TYPE_VOID;
         }
 
-        if(preg_match('!^\d+$!', $string)) {
+        if (preg_match('!^\d+$!', $string)) {
             return self::TYPE_INTEGER;
         }
 
-        if(preg_match('!^\d+\.\d+$!', $string)) {
+        if (preg_match('!^\d+\.\d+$!', $string)) {
             return self::TYPE_FLOAT;
         }
 
-        if('null' == $string) {
+        if ('null' == $string) {
             return self::TYPE_NULL;
         }
 
-        if(preg_match('!(^\[|^array\()!', $string)) {
+        if (preg_match('!(^\[|^array\()!', $string)) {
             return self::TYPE_ARRAY;
         }
 
-        if(preg_match('!^new\s+class\s+!', $string, $matches)) {
+        if (preg_match('!^new\s+class\s+!', $string, $matches)) {
             return self::TYPE_ANONYMOUS_CLASS;
         }
 
-        if(preg_match('!^(new\s+)(.*?)(\s*[\(;].*|$)!', $cased, $matches)) {
+        if (preg_match('!^(new\s+)(.*?)(\s*[\(;].*|$)!', $cased, $matches)) {
             return $matches[2];
         }
 
-        if(preg_match('!^\$this$!', $string, $matches)) {
+        if (preg_match('!^\$this$!', $string, $matches)) {
             return self::TYPE_FLUENT_INTERFACE;
         }
 
-        if(preg_match('!^(true|false)!', $string, $matches)) {
+        if (preg_match('!^(true|false)!', $string, $matches)) {
             return self::TYPE_BOOL;
         }
 
-        if(preg_match('!^function!', $string, $matches)) {
+        if (preg_match('!^function!', $string, $matches)) {
             return self::TYPE_CALLABLE;
         }
 
-        if(preg_match('!^["\']!', $string, $matches)) {
+        if (preg_match('!^["\']!', $string, $matches)) {
             return self::TYPE_STRING;
         }