phpmetrics /
PhpMetrics
| Conditions | 10 |
| Paths | 19 |
| Total Lines | 73 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 4 | ||
| Bugs | 3 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 104 | protected function execute(InputInterface $input, OutputInterface $output) |
||
| 105 | { |
||
| 106 | |||
| 107 | $output->writeln('PHPMetrics by Jean-François Lépine <https://twitter.com/Halleck45>'); |
||
| 108 | $output->writeln(''); |
||
| 109 | |||
| 110 | // config |
||
| 111 | $configFactory = new ConfigFactory(); |
||
| 112 | $config = $configFactory->factory($input); |
||
| 113 | |||
| 114 | // files |
||
| 115 | if(null === $config->getPath()->getBasePath()) { |
||
| 116 | throw new \LogicException('Please provide a path to analyze'); |
||
| 117 | } |
||
| 118 | |||
| 119 | // files to analyze |
||
| 120 | $finder = new Finder( |
||
| 121 | $config->getPath()->getExtensions() |
||
| 122 | , $config->getPath()->getExcludedDirs() |
||
| 123 | , $config->getPath()->isFollowSymlinks() ? Finder::FOLLOW_SYMLINKS : null |
||
| 124 | ); |
||
| 125 | |||
| 126 | // prepare plugins |
||
| 127 | $repository = new Repository(); |
||
| 128 | foreach($config->getExtensions()->getExtensions() as $filename) { |
||
|
|
|||
| 129 | if(!file_exists($filename) ||!is_readable($filename)) { |
||
| 130 | $output->writeln(sprintf('<error>Plugin %s skipped: not found</error>', $filename)); |
||
| 131 | continue; |
||
| 132 | } |
||
| 133 | $plugin = require_once($filename); |
||
| 134 | $repository->attach($plugin); |
||
| 135 | } |
||
| 136 | $extensionService = new ExtensionService($repository); |
||
| 137 | |||
| 138 | // prepare structures |
||
| 139 | $bounds = new Bounds(); |
||
| 140 | $collection = new \Hal\Component\Result\ResultCollection(); |
||
| 141 | $aggregatedResults = new \Hal\Component\Result\ResultCollection(); |
||
| 142 | |||
| 143 | // execute analyze |
||
| 144 | $queueFactory = new QueueAnalyzeFactory($input, $output, $config, $extensionService); |
||
| 145 | $queue = $queueFactory->factory($finder, $bounds); |
||
| 146 | gc_disable(); |
||
| 147 | $queue->execute($collection, $aggregatedResults); |
||
| 148 | gc_enable(); |
||
| 149 | |||
| 150 | $output->writeln(''); |
||
| 151 | |||
| 152 | // provide data to extensions |
||
| 153 | if(($n = sizeof($repository->all())) > 0) { |
||
| 154 | $output->writeln(sprintf('%d %s. Executing analyzis', $n, ($n > 1 ? 'plugins are enabled' : 'plugin is enabled') )); |
||
| 155 | $extensionService->receive($config, $collection, $aggregatedResults, $bounds); |
||
| 156 | } |
||
| 157 | |||
| 158 | // generating reports |
||
| 159 | $output->writeln("Generating reports..."); |
||
| 160 | $queueFactory = new QueueReportFactory($input, $output, $config, $extensionService); |
||
| 161 | $queue = $queueFactory->factory($finder, $bounds); |
||
| 162 | $queue->execute($collection, $aggregatedResults); |
||
| 163 | |||
| 164 | $output->writeln('<info>Done</info>'); |
||
| 165 | |||
| 166 | // evaluation of success |
||
| 167 | $rule = $config->getFailureCondition(); |
||
| 168 | if(null !== $rule) { |
||
| 169 | $evaluator = new Evaluator($collection, $aggregatedResults, $bounds); |
||
| 170 | $result = $evaluator->evaluate($rule); |
||
| 171 | // fail if failure-condition is realized |
||
| 172 | return $result->isValid() ? 1 : 0; |
||
| 173 | } |
||
| 174 | |||
| 175 | return 0; |
||
| 176 | } |
||
| 177 | |||
| 179 |
Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects.