Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class FormatingExtension extends \Twig_Extension |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var Validator |
||
| 11 | */ |
||
| 12 | private $validator; |
||
| 13 | |||
| 14 | /** |
||
| 15 | * Validator |
||
| 16 | * |
||
| 17 | * @param Validator $validator |
||
| 18 | */ |
||
| 19 | function __construct(Validator $validator) |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @inheritdoc |
||
| 26 | */ |
||
| 27 | public function getFilters() |
||
| 34 | |||
| 35 | /** |
||
| 36 | * @inheritdoc |
||
| 37 | */ |
||
| 38 | public function getFunctions() |
||
| 46 | |||
| 47 | /** |
||
| 48 | * String as readable text |
||
| 49 | * |
||
| 50 | * @param $v |
||
| 51 | * @return string |
||
| 52 | */ |
||
| 53 | public function textify($v) |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Check value according rule |
||
| 60 | * |
||
| 61 | * @param $key |
||
| 62 | * @param $v |
||
| 63 | * @return string |
||
| 64 | */ |
||
| 65 | public function rule($v, $key) |
||
| 69 | |||
| 70 | /** |
||
| 71 | * @param ExtensionService $extensions |
||
| 72 | * @return string |
||
| 73 | */ |
||
| 74 | public function extensionsMenu(ExtensionService $extensions) |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @param ExtensionService $extensions |
||
| 91 | * @return string |
||
| 92 | */ |
||
| 93 | View Code Duplication | public function extensionsJs(ExtensionService $extensions) |
|
| 105 | |||
| 106 | /** |
||
| 107 | * @param ExtensionService $extensions |
||
| 108 | * @return string |
||
| 109 | */ |
||
| 110 | View Code Duplication | public function extensionsContent(ExtensionService $extensions) |
|
| 122 | |||
| 123 | /** |
||
| 124 | * @inherit |
||
| 125 | */ |
||
| 126 | public function getName() |
||
| 130 | } |
||
| 131 |
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.