phpmetrics / PhpMetrics

src/Hal/Metric/Package/PackageAbstraction.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     {
         /* @var $packages PackageMetric[] */
         foreach ($metrics->all() as $eachPackage) {
-            if (! $eachPackage instanceof PackageMetric) {
+            if (!$eachPackage instanceof PackageMetric) {
                 continue;
             }
             $abstractClassCount = 0;

src/Hal/Metric/Package/PackageDependencies.php

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
 {
     public function calculate(Metrics $metrics)
     {
-        $classes = array_filter($metrics->all(), function (Metric $metric) {
+        $classes = array_filter($metrics->all(), function(Metric $metric) {
             return $metric instanceof ClassMetric || $metric instanceof InterfaceMetric;
         });
 
@@ -27,7 +27,7 @@ 
      */
     private function increaseDependencies(Metric $class, Metrics $metrics)
     {
-        if (! $class->has('package') || ! $class->has('externals')) {
+        if (!$class->has('package') || !$class->has('externals')) {
             return;
         }
         $incomingPackage = $metrics->get($class->get('package')); /* @var $incomingPackage PackageMetric */
@@ -56,6 +56,6 @@ 
         }
         $parts = explode('\\', $className);
         array_pop($parts);
-        return implode('\\', $parts) . '\\';
+        return implode('\\', $parts).'\\';
     }
 }

src/Hal/Metric/Package/PackageInstability.php

Spacing +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
     public function calculate(Metrics $metrics)
     {
         /* @var $packages PackageMetric[] */
-        $packages = array_filter($metrics->all(), function ($metric) {
+        $packages = array_filter($metrics->all(), function($metric) {
             return $metric instanceof PackageMetric;
         });
 
@@ -28,7 +28,7 @@ 
         }
         // Set depending instabilities
         foreach ($packages as $eachPackage) {
-            $dependentInstabilities = array_map(function ($packageName) use ($instabilitiesByPackage) {
+            $dependentInstabilities = array_map(function($packageName) use ($instabilitiesByPackage) {
                 return isset($instabilitiesByPackage[$packageName]) ? $instabilitiesByPackage[$packageName] : null;
             }, $eachPackage->getOutgoingPackageDependencies());
             $dependentInstabilities = array_combine(

src/Hal/Metric/Helper/MetricClassNameGenerator.php

Spacing +1 added lines, -2 removed lines

@@ -17,7 +17,6 @@
     public static function getName(Node $node)
     {
         return ($node instanceof Node\Stmt\Class_ && $node->isAnonymous()) ?
-            'anonymous@' . spl_object_hash($node) :
-            $node->namespacedName->toString();
+            'anonymous@'.spl_object_hash($node) : $node->namespacedName->toString();
     }
 }

src/Hal/Metric/Class_/Component/MaintainabilityIndexVisitor.php

Unused Use Statements -2 removed lines

@@ -1,9 +1,7 @@
 <?php
 namespace Hal\Metric\Class_\Component;
 
-use Hal\Metric\FunctionMetric;
 use Hal\Metric\Metrics;
-use Hoa\Ruler\Model\Bag\Scalar;
 use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use PhpParser\NodeVisitorAbstract;

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     public function leaveNode(Node $node)
     {
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
-            $name = (string)(isset($node->namespacedName) ? $node->namespacedName : 'anonymous@' . spl_object_hash($node));
+            $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.spl_object_hash($node));
             $classOrFunction = $this->metrics->get($name);
 
             if (null === $lloc = $classOrFunction->get('lloc')) {

src/Hal/Report/Html/Reporter.php

Doc Comments +2 added lines, -2 removed lines

@@ -116,8 +116,8 @@
     }
 
     /**
-     * @param $source
-     * @param $destination
+     * @param string $source
+     * @param string $destination
      * @param Consolidated $consolidated
      * @param $history
      * @return $this

Spacing +21 added lines, -21 removed lines

@@ -51,46 +51,46 @@ 
 
         $consolidated = new Consolidated($metrics);
 
-        $files = glob($logDir . '/js/history-*.json');
+        $files = glob($logDir.'/js/history-*.json');
         natsort($files);
-        $history = array_map(static function ($filename) {
+        $history = array_map(static function($filename) {
             return json_decode(file_get_contents($filename));
         }, $files);
 
         foreach (['js', 'css', 'images', 'fonts'] as $subFolder) {
-            $folder = $logDir . '/' . $subFolder;
+            $folder = $logDir.'/'.$subFolder;
             if (!file_exists($folder)) {
                 mkdir($folder, 0755, true);
             }
-            recurse_copy(__DIR__ . '/template/' . $subFolder, $folder);
+            recurse_copy(__DIR__.'/template/'.$subFolder, $folder);
         }
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/packages.php', $logDir . '/packages.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/package_relations.php', $logDir . '/package_relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/packages.php', $logDir.'/packages.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/package_relations.php', $logDir.'/package_relations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
 
-        $today = (object)['avg' => $consolidated->getAvg(), 'sum' => $consolidated->getSum()];
+        $today = (object) ['avg' => $consolidated->getAvg(), 'sum' => $consolidated->getSum()];
         $encodedToday = json_encode($today, JSON_PRETTY_PRINT);
         $next = count($history) + 1;
         file_put_contents(sprintf('%s/js/history-%d.json', $logDir, $next), $encodedToday);
         file_put_contents(sprintf('%s/js/latest.json', $logDir), $encodedToday);
 
         file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(sprintf('HTML report generated in "%s" directory', $logDir));
@@ -156,7 +156,7 @@ 
         $goodOrBad = 'neutral';
         if ($newValue > $oldValue) {
             $r = 'gt';
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
             $goodOrBad = $lowIsBetter ? 'bad' : $goodOrBad;
             $goodOrBad = $highIsBetter ? 'good' : $goodOrBad;
         } elseif ($newValue < $oldValue) {

src/Hal/Application/Analyze.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
         $metrics = new Metrics();
 
         // traverse all
-        $whenToStop = function () {
+        $whenToStop = function() {
             return true;
         };
 

src/Hal/Component/Tree/GraphDeduplicated.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      */
     public function addEdge(Node $from, Node $to)
     {
-        $key = $from->getUniqueId() . '->' . $to->getUniqueId();
+        $key = $from->getUniqueId().'->'.$to->getUniqueId();
 
         if (isset($this->edgesMap[$key])) {
             return $this;

src/Hal/Violation/Package/StableAbstractionsPrinciple.php

Spacing +2 added lines, -2 removed lines

@@ -18,10 +18,10 @@
 
     public function apply(Metric $metric)
     {
-        if (! $metric instanceof PackageMetric) {
+        if (!$metric instanceof PackageMetric) {
             return;
         }
-        if (abs($metric->getDistance()) > sqrt(2)/4) {
+        if (abs($metric->getDistance()) > sqrt(2) / 4) {
             $this->metric = $metric;
             $metric->get('violations')->add($this);
         }