KanDefectVisitor::leaveNode() - Code Metrics - Inspection of "Fix to support anonymous classes in PHP 7.1" - phpmetrics/PhpMetrics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#299)

by Atlas

created 2017-09-13 12:43 UTC

KanDefectVisitor::leaveNode() C

↳ Parent: KanDefectVisitor

Complexity

Conditions	8
Paths	2

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	20
nc	2
nop	1
dl	0
loc	31
rs	5.3846
c	0
b	0
f	0

<?php
namespace Hal\Metric\Class_\Complexity;

use Hal\Component\Reflected\Method;
use Hal\Metric\Helper\MetricClassNameGenerator;
use Hal\Metric\Metrics;
use PhpParser\Node;
use PhpParser\Node\Stmt;
use PhpParser\NodeVisitorAbstract;

/**
 * Calculate Kan's defects
 *
 * defects = 0.15 + 0.23 *  number of do…while() + 0.22 *  number of select() + 0.07 * number of if()
 */
class KanDefectVisitor extends NodeVisitorAbstract
{
    /**
     * @var Metrics
     */
    private $metrics;

    /**
     * ClassEnumVisitor constructor.
     * @param Metrics $metrics
     */
    public function __construct(Metrics $metrics)
    {
        $this->metrics = $metrics;
    }

    /**
     * @inheritdoc
     */
    public function leaveNode(Node $node)
    {
        if ($node instanceof Stmt\Class_
            || $node instanceof Stmt\Interface_
        ) {

            $class = $this->metrics->get(MetricClassNameGenerator::getName($node));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();


            $select = $while = $if = 0;

            iterate_over_node($node, function ($node) use (&$while, &$select, &$if) {
                switch (true) {
                    case $node instanceof Stmt\Do_:
                    case $node instanceof Stmt\Foreach_:
                    case $node instanceof Stmt\While_:
                        $while++;
                        break;
                    case $node instanceof Stmt\If_:
                        $if++;
                        break;
                    case $node instanceof Stmt\Switch_:
                        $select++;
                        break;
                }
            });

            $defect = 0.15 + 0.23 *  $while + 0.22 *  $select + 0.07 * $if;
            $class->set('kanDefect', round($defect, 2));

        }
    }
}


1			<?php
2			namespace Hal\Metric\Class_\Complexity;
3
4			use Hal\Component\Reflected\Method;
5			use Hal\Metric\Helper\MetricClassNameGenerator;
6			use Hal\Metric\Metrics;
7			use PhpParser\Node;
8			use PhpParser\Node\Stmt;
9			use PhpParser\NodeVisitorAbstract;
10
11			/**
12			* Calculate Kan's defects
13			*
14			* defects = 0.15 + 0.23 * number of do…while() + 0.22 * number of select() + 0.07 * number of if()
15			*/
16			class KanDefectVisitor extends NodeVisitorAbstract
17			{
18			/**
19			* @var Metrics
20			*/
21			private $metrics;
22
23			/**
24			* ClassEnumVisitor constructor.
25			* @param Metrics $metrics
26			*/
27			public function __construct(Metrics $metrics)
28			{
29			$this->metrics = $metrics;
30			}
31
32			/**
33			* @inheritdoc
34			*/
35			public function leaveNode(Node $node)
36			{
37			if ($node instanceof Stmt\Class_
38			\|\| $node instanceof Stmt\Interface_
39			) {
40
41			$class = $this->metrics->get(MetricClassNameGenerator::getName($node));
			0 ignored issues – show Bug introduced 2017-09-01 15:11 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$class` is correct as `$this->metrics->get(\Hal...erator::getName($node))` (which targets `Hal\Metric\Metrics::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
42
43
44			$select = $while = $if = 0;
45
46			iterate_over_node($node, function ($node) use (&$while, &$select, &$if) {
47			switch (true) {
48			case $node instanceof Stmt\Do_:
49			case $node instanceof Stmt\Foreach_:
50			case $node instanceof Stmt\While_:
51			$while++;
52			break;
53			case $node instanceof Stmt\If_:
54			$if++;
55			break;
56			case $node instanceof Stmt\Switch_:
57			$select++;
58			break;
59			}
60			});
61
62			$defect = 0.15 + 0.23 * $while + 0.22 * $select + 0.07 * $if;
63			$class->set('kanDefect', round($defect, 2));
			0 ignored issues – show Bug introduced 2017-01-30 05:20 UTC by Report Bug Copy Issue Report The method `set` cannot be called on `$class` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
64			}
65			}
66			}
67

phpmetrics / PhpMetrics

Pull Request — master (#299)

KanDefectVisitor::leaveNode() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like