Completed
Pull Request — master (#299)
by Atlas
03:31
created
src/Hal/Metric/BagTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
     }
50 50
 
51 51
     /**
52
-     * @param $key
52
+     * @param string $key
53 53
      * @return null
54 54
      */
55 55
     public function get($key)
Please login to merge, or discard this patch.
src/Hal/Report/Html/Reporter.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -109,8 +109,8 @@
 block discarded – undo
109 109
     }
110 110
 
111 111
     /**
112
-     * @param $source
113
-     * @param $destination
112
+     * @param string $source
113
+     * @param string $destination
114 114
      * @return $this
115 115
      */
116 116
     public function renderPage($source, $destination, Consolidated $consolidated, $history)
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -44,11 +44,11 @@  discard block
 block discarded – undo
44 44
         $consolidated = new Consolidated($metrics);
45 45
 
46 46
         // history of builds
47
-        $today = (object)[
47
+        $today = (object) [
48 48
             'avg' => $consolidated->getAvg(),
49 49
             'sum' => $consolidated->getSum()
50 50
         ];
51
-        $files = glob($logDir . '/js/history-*.json');
51
+        $files = glob($logDir.'/js/history-*.json');
52 52
         $next = sizeof($files) + 1;
53 53
         $history = [];
54 54
         natsort($files);
@@ -57,33 +57,33 @@  discard block
 block discarded – undo
57 57
         }
58 58
 
59 59
         // copy sources
60
-        if(!file_exists($logDir . '/js')) {
60
+        if (!file_exists($logDir.'/js')) {
61 61
             mkdir($logDir.'/js', 0755, true);
62 62
         }
63
-        if(!file_exists($logDir . '/css')) {
63
+        if (!file_exists($logDir.'/css')) {
64 64
             mkdir($logDir.'/css', 0755, true);
65 65
         }
66
-        if(!file_exists($logDir . '/images')) {
66
+        if (!file_exists($logDir.'/images')) {
67 67
             mkdir($logDir.'/images', 0755, true);
68 68
         }
69
-        recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
70
-        recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
71
-        recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
69
+        recurse_copy(__DIR__.'/template/js', $logDir.'/js');
70
+        recurse_copy(__DIR__.'/template/css', $logDir.'/css');
71
+        recurse_copy(__DIR__.'/template/images', $logDir.'/images');
72 72
 
73 73
         // render dynamic pages
74
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
75
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
76
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
77
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
78
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
79
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
80
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
81
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
82
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
74
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
75
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
76
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
77
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
78
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
79
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
80
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
81
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
82
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
83 83
         if ($this->config->has('git')) {
84
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
84
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
85 85
         }
86
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
86
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
87 87
 
88 88
         // js data
89 89
         file_put_contents(
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 
98 98
         // json data
99 99
         file_put_contents(
100
-            $logDir . '/js/classes.js',
101
-            'var classes = ' . json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
100
+            $logDir.'/js/classes.js',
101
+            'var classes = '.json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
102 102
         );
103 103
 
104 104
         $this->output->writeln(sprintf('HTML report generated in "%s" directory', $logDir));
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
         $diff = $newValue - $oldValue;
168 168
         if ($diff > 0) {
169
-            $diff = '+' . $diff;
169
+            $diff = '+'.$diff;
170 170
         }
171 171
 
172 172
         $goodOrBad = 'neutral';
Please login to merge, or discard this patch.
src/Hal/Violation/Violations.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
     {
45 45
         $string = '';
46 46
         foreach ($this->data as $violation) {
47
-            $string .= $violation->getName() . ',';
47
+            $string .= $violation->getName().',';
48 48
         }
49 49
         return $string;
50 50
     }
Please login to merge, or discard this patch.
src/Hal/Component/Ast/NodeTraverser.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@
 block discarded – undo
25 25
     {
26 26
         parent::__construct($cloneNodes);
27 27
 
28
-        if(null === $stopCondition) {
28
+        if (null === $stopCondition) {
29 29
             $stopCondition = function($node) {
30
-                if($node instanceof Node\Stmt\Class_ || $node instanceof Node\Stmt\Interface_) {
30
+                if ($node instanceof Node\Stmt\Class_ || $node instanceof Node\Stmt\Interface_) {
31 31
                     return false;
32 32
                 }
33 33
 
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -21,6 +21,9 @@
 block discarded – undo
21 21
 {
22 22
     protected $stopCondition;
23 23
 
24
+    /**
25
+     * @param \Closure $stopCondition
26
+     */
24 27
     public function __construct($cloneNodes = false, $stopCondition = null)
25 28
     {
26 29
         parent::__construct($cloneNodes);
Please login to merge, or discard this patch.
src/Hal/Report/Html/template/relations.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@  discard block
 block discarded – undo
1
-<?php require __DIR__ . '/_header.php'; ?>
1
+<?php require __DIR__.'/_header.php'; ?>
2 2
 
3 3
 <?php
4 4
 $relations = [];
5 5
 $classesCp = [];
6 6
 foreach ($classes as $class) {
7 7
 
8
-    $class['name'] = '\\' . $class['name'];
8
+    $class['name'] = '\\'.$class['name'];
9 9
     $classesCp[$class['name']] = $class;
10 10
     $classesCp[$class['name']]['externals'] = [];
11 11
 
12 12
 
13 13
     foreach ($class['externals'] as &$ext) {
14
-        $ext = '\\' . $ext;
14
+        $ext = '\\'.$ext;
15 15
         if (!isset($classes[$ext])) {
16 16
             $classesCp[$ext] = [
17 17
                 'name' => $ext,
@@ -22,10 +22,10 @@  discard block
 block discarded – undo
22 22
     }
23 23
 }
24 24
 foreach ($classesCp as $class) {
25
-    array_push($relations, (object)[
25
+    array_push($relations, (object) [
26 26
         'name' => $class['name'],
27 27
         'size' => 3000,
28
-        'relations' => (array)array_values(array_unique($class['externals'])),
28
+        'relations' => (array) array_values(array_unique($class['externals'])),
29 29
     ]);
30 30
 }
31 31
 ?>
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     </div>
41 41
 </div>
42 42
 
43
-<?php require __DIR__ . '/_footer.php'; ?>
43
+<?php require __DIR__.'/_footer.php'; ?>
44 44
 
45 45
 
46 46
 <script type="text/javascript">
Please login to merge, or discard this patch.
src/Hal/Report/Html/template/complexity.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require __DIR__ . '/_header.php'; ?>
2
+require __DIR__.'/_header.php'; ?>
3 3
 
4 4
     <div class="row">
5 5
         <div class="column">
@@ -79,4 +79,4 @@  discard block
 block discarded – undo
79 79
     </div>
80 80
 
81 81
 
82
-<?php require __DIR__ . '/_footer.php'; ?>
83 82
\ No newline at end of file
83
+<?php require __DIR__.'/_footer.php'; ?>
84 84
\ No newline at end of file
Please login to merge, or discard this patch.
src/Hal/Report/Html/template/git.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require __DIR__ . '/_header.php'; ?>
2
+require __DIR__.'/_header.php'; ?>
3 3
 
4 4
 
5 5
 <?php
@@ -12,12 +12,12 @@  discard block
 block discarded – undo
12 12
     $history = array_slice($history, -24);
13 13
     $json = [];
14 14
     foreach ($history as $date => $values) {
15
-        array_push($json, (object)[
15
+        array_push($json, (object) [
16 16
             'date' => $date,
17 17
             'key' => 'Additions',
18 18
             'value' => abs($values['additions']),
19 19
         ]);
20
-        array_push($json, (object)[
20
+        array_push($json, (object) [
21 21
             'date' => $date,
22 22
             'key' => 'Removes',
23 23
             'value' => abs($values['removes']),
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     </div>
95 95
 </div>
96 96
 
97
-<?php require __DIR__ . '/_footer.php'; ?>
97
+<?php require __DIR__.'/_footer.php'; ?>
98 98
 
99 99
 
100 100
 <script type="text/javascript">
Please login to merge, or discard this patch.
src/Hal/Report/Html/template/all.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 $fullwidth = true;
3
-require __DIR__ . '/_header.php'; ?>
3
+require __DIR__.'/_header.php'; ?>
4 4
 
5 5
 <?php
6 6
 
@@ -37,4 +37,4 @@  discard block
 block discarded – undo
37 37
             </div>
38 38
         </div>
39 39
     </div>
40
-<?php require __DIR__ . '/_footer.php'; ?>
41 40
\ No newline at end of file
41
+<?php require __DIR__.'/_footer.php'; ?>
42 42
\ No newline at end of file
Please login to merge, or discard this patch.
src/Hal/Report/Html/template/panel.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 $fullwidth = true;
3
-require __DIR__ . '/_header.php'; ?>
3
+require __DIR__.'/_header.php'; ?>
4 4
 
5 5
     <div class="row">
6 6
         <div class="column">
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
                     <tbody>
82 82
                     <?php
83 83
                     $classesS = $classes;
84
-                    usort($classesS, function ($a, $b) {
84
+                    usort($classesS, function($a, $b) {
85 85
                         return strcmp($b['pageRank'], $a['pageRank']);
86 86
                     });
87 87
                     $classesS = array_slice($classesS, 0, 10);
@@ -128,4 +128,4 @@  discard block
 block discarded – undo
128 128
     </script>
129 129
 
130 130
 <?php
131
-require __DIR__ . '/_footer.php'; ?>
132 131
\ No newline at end of file
132
+require __DIR__.'/_footer.php'; ?>
133 133
\ No newline at end of file
Please login to merge, or discard this patch.