Hal\Metric\Class_\Complexity\KanDefectVisitor

Complexity

Total Complexity

9

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	leaveNode()	0	31	8

<?php
namespace Hal\Metric\Class_\Complexity;

use Hal\Component\Reflected\Method;
use Hal\Metric\Helper\MetricClassNameGenerator;
use Hal\Metric\Metrics;
use PhpParser\Node;
use PhpParser\Node\Stmt;
use PhpParser\NodeVisitorAbstract;

/**
 * Calculate Kan's defects
 *
 * defects = 0.15 + 0.23 *  number of do…while() + 0.22 *  number of select() + 0.07 * number of if()
 */
class KanDefectVisitor extends NodeVisitorAbstract
{
    /**
     * @var Metrics
     */
    private $metrics;

    /**
     * ClassEnumVisitor constructor.
     * @param Metrics $metrics
     */
    public function __construct(Metrics $metrics)
    {
        $this->metrics = $metrics;
    }

    /**
     * @inheritdoc
     */
    public function leaveNode(Node $node)
    {
        if ($node instanceof Stmt\Class_
            || $node instanceof Stmt\Interface_
        ) {

            $class = $this->metrics->get(MetricClassNameGenerator::getName($node));

Are you sure the assignment to $class is correct as $this->metrics->get(\Hal\Metric\Helper\MetricClassNameGenerator::getName($node)) (which targets Hal\Metric\Metrics::get()) seems to always return null.

            $select = $while = $if = 0;

            iterate_over_node($node, function ($node) use (&$while, &$select, &$if) {
                switch (true) {
                    case $node instanceof Stmt\Do_:
                    case $node instanceof Stmt\Foreach_:
                    case $node instanceof Stmt\While_:
                        $while++;
                        break;
                    case $node instanceof Stmt\If_:
                        $if++;
                        break;
                    case $node instanceof Stmt\Switch_:
                        $select++;
                        break;
                }
            });

            $defect = 0.15 + 0.23 *  $while + 0.22 *  $select + 0.07 * $if;
            $class->set('kanDefect', round($defect, 2));

The method set cannot be called on $class (of type null).

        }
    }
}