@@ -104,7 +104,7 @@ discard block |
||
104 | 104 | * @var array |
105 | 105 | */ |
106 | 106 | private $operatorsStrings = array( |
107 | - ';', '*', '/', '%', '-','+' |
|
107 | + ';', '*', '/', '%', '-', '+' |
|
108 | 108 | , '!', '!=', '%', '%=', '&', '&&', '||', '&=', '(', ')' |
109 | 109 | /*, '{', '}'*/, '[', ']', '*', '*=', '+', '++', '+=', ',' |
110 | 110 | , '-', '--', '-=->', '.', '...', '/', '/=', ':', '::' |
@@ -120,7 +120,7 @@ discard block |
||
120 | 120 | */ |
121 | 121 | private $byPass = array( |
122 | 122 | '{', '}' // in PHP, these case are counted with T_IF, '(', ... |
123 | - , ')' , '(' // we count only the first ( |
|
123 | + , ')', '(' // we count only the first ( |
|
124 | 124 | , ',' |
125 | 125 | ); |
126 | 126 | |
@@ -128,7 +128,7 @@ discard block |
||
128 | 128 | * Constructor |
129 | 129 | */ |
130 | 130 | public function __construct() { |
131 | - if(version_compare(PHP_VERSION, '5.4.0') >= 0) { |
|
131 | + if (version_compare(PHP_VERSION, '5.4.0') >= 0) { |
|
132 | 132 | $this->operators = array_merge($this->operators, array( |
133 | 133 | T_INSTEADOF |
134 | 134 | , T_TRAIT_C |
@@ -141,9 +141,9 @@ discard block |
||
141 | 141 | |
142 | 142 | // performance : key will be equals to it value |
143 | 143 | $this->operands = array_combine($this->operands, $this->operands); |
144 | - $this->operators= array_combine($this->operators, $this->operators); |
|
144 | + $this->operators = array_combine($this->operators, $this->operators); |
|
145 | 145 | $this->operatorsStrings = array_combine($this->operatorsStrings, $this->operatorsStrings); |
146 | - $this->byPass= array_combine($this->byPass, $this->byPass); |
|
146 | + $this->byPass = array_combine($this->byPass, $this->byPass); |
|
147 | 147 | } |
148 | 148 | |
149 | 149 | /** |
@@ -154,8 +154,8 @@ discard block |
||
154 | 154 | */ |
155 | 155 | public function isOperand(Token $token) |
156 | 156 | { |
157 | - if(T_STRING == $token->getType()) { |
|
158 | - return !(isset($this->byPass[$token->getValue()]) ||isset($this->operatorsStrings[$token->getValue()])); |
|
157 | + if (T_STRING == $token->getType()) { |
|
158 | + return !(isset($this->byPass[$token->getValue()]) || isset($this->operatorsStrings[$token->getValue()])); |
|
159 | 159 | } |
160 | 160 | |
161 | 161 | return isset($this->operands[$token->getType()]); |
@@ -169,8 +169,8 @@ discard block |
||
169 | 169 | */ |
170 | 170 | public function isOperator(Token $token) |
171 | 171 | { |
172 | - if(T_STRING == $token->getType()) { |
|
173 | - if(isset($this->byPass[$token->getValue()])) { |
|
172 | + if (T_STRING == $token->getType()) { |
|
173 | + if (isset($this->byPass[$token->getValue()])) { |
|
174 | 174 | return false; |
175 | 175 | } |
176 | 176 | return isset($this->operatorsStrings[$token->getValue()]); |
@@ -56,9 +56,9 @@ discard block |
||
56 | 56 | $tokens = $this->tokenizer->tokenize($filename); |
57 | 57 | |
58 | 58 | $ccn = 1; // default path |
59 | - foreach($tokens as $token) { |
|
59 | + foreach ($tokens as $token) { |
|
60 | 60 | |
61 | - switch($token->getType()) { |
|
61 | + switch ($token->getType()) { |
|
62 | 62 | case T_IF: |
63 | 63 | case T_ELSEIF: |
64 | 64 | case T_FOREACH: |
@@ -77,7 +77,7 @@ discard block |
||
77 | 77 | $ccn++; |
78 | 78 | break; |
79 | 79 | case T_STRING: |
80 | - if('?' == $token->getValue()) { |
|
80 | + if ('?' == $token->getValue()) { |
|
81 | 81 | $ccn = $ccn + 2; |
82 | 82 | } |
83 | 83 | break; |
@@ -63,8 +63,8 @@ |
||
63 | 63 | , T_BOOLEAN_OR => T_BOOLEAN_OR |
64 | 64 | , T_LOGICAL_OR => T_LOGICAL_OR |
65 | 65 | ); |
66 | - foreach($tokens as $token) { |
|
67 | - if(isset($logicalOperators[$token->getType()])) { |
|
66 | + foreach ($tokens as $token) { |
|
67 | + if (isset($logicalOperators[$token->getType()])) { |
|
68 | 68 | $L++; |
69 | 69 | } |
70 | 70 | } |
@@ -49,7 +49,7 @@ discard block |
||
49 | 49 | $len = 0; |
50 | 50 | $sy = $dc = $sc = array(); |
51 | 51 | $calculator = new SystemComplexity(); |
52 | - foreach($rOOP->getClasses() as $class) { |
|
52 | + foreach ($rOOP->getClasses() as $class) { |
|
53 | 53 | $r = $calculator->calculate($class); |
54 | 54 | |
55 | 55 | $len += sizeof($class->getMethods(), COUNT_NORMAL); |
@@ -58,7 +58,7 @@ discard block |
||
58 | 58 | $sc[] = $r->getTotalStructuralComplexity(); |
59 | 59 | } |
60 | 60 | |
61 | - if($len > 0 &&sizeof($dc, COUNT_NORMAL) > 0) { |
|
61 | + if ($len > 0 && sizeof($dc, COUNT_NORMAL) > 0) { |
|
62 | 62 | $result |
63 | 63 | ->setRelativeStructuralComplexity(round(array_sum($sc) / $len, 2)) |
64 | 64 | ->setRelativeDataComplexity(round(array_sum($dc) / $len, 2)) |
@@ -36,7 +36,7 @@ |
||
36 | 36 | |
37 | 37 | |
38 | 38 | $sy = $dc = $sc = array(); // in system |
39 | - foreach($class->getMethods() as $method) { |
|
39 | + foreach ($class->getMethods() as $method) { |
|
40 | 40 | $fanout = sizeof($method->getDependencies(), COUNT_NORMAL); |
41 | 41 | $v = sizeof($method->getArguments(), COUNT_NORMAL) + sizeof($method->getReturns(), COUNT_NORMAL); |
42 | 42 |
@@ -29,8 +29,8 @@ discard block |
||
29 | 29 | $map = $this->extractCoupling($result); |
30 | 30 | |
31 | 31 | // instability |
32 | - foreach($map as &$class) { |
|
33 | - if($class->getAfferentCoupling() + $class->getEfferentCoupling() > 0) { |
|
32 | + foreach ($map as &$class) { |
|
33 | + if ($class->getAfferentCoupling() + $class->getEfferentCoupling() > 0) { |
|
34 | 34 | $class->setInstability($class->getEfferentCoupling() / ($class->getAfferentCoupling() + $class->getEfferentCoupling())); |
35 | 35 | } |
36 | 36 | } |
@@ -49,22 +49,22 @@ discard block |
||
49 | 49 | $results = $result->all(); |
50 | 50 | |
51 | 51 | $classes = array(); |
52 | - foreach($results as $result) { |
|
52 | + foreach ($results as $result) { |
|
53 | 53 | $classes = array_merge($classes, $result->getClasses()); |
54 | 54 | } |
55 | 55 | |
56 | 56 | $map = array(); |
57 | - foreach($classes as $class) { |
|
57 | + foreach ($classes as $class) { |
|
58 | 58 | |
59 | - if(!isset($map[$class->getFullname()])) { |
|
59 | + if (!isset($map[$class->getFullname()])) { |
|
60 | 60 | $map[$class->getFullname()] = new Result($class->getFullname()); |
61 | 61 | } |
62 | 62 | |
63 | 63 | $dependencies = $class->getDependencies(); |
64 | 64 | $map[$class->getFullname()]->setEfferentCoupling(sizeof($dependencies, COUNT_NORMAL)); |
65 | 65 | |
66 | - foreach($dependencies as $dependency) { |
|
67 | - if(!isset($map[$dependency])) { |
|
66 | + foreach ($dependencies as $dependency) { |
|
67 | + if (!isset($map[$dependency])) { |
|
68 | 68 | $map[$dependency] = new Result($dependency); |
69 | 69 | } |
70 | 70 | $map[$dependency]->setAfferentCoupling($map[$dependency]->getAfferentCoupling() + 1); |
@@ -54,21 +54,21 @@ |
||
54 | 54 | $result = new Result($filename); |
55 | 55 | |
56 | 56 | // case of file doesn't contain any class |
57 | - if(null === $rOOP) { |
|
57 | + if (null === $rOOP) { |
|
58 | 58 | return $result; |
59 | 59 | } |
60 | 60 | |
61 | 61 | $instability = $ce = $ca = 0; |
62 | 62 | |
63 | 63 | $classes = $rOOP->getClasses(); |
64 | - foreach($classes as $declaredClass) { |
|
64 | + foreach ($classes as $declaredClass) { |
|
65 | 65 | $declaredClassCoupling = $this->couplingMap->get($declaredClass->getFullname()); |
66 | 66 | |
67 | 67 | $ce += $declaredClassCoupling->getEfferentCoupling(); |
68 | 68 | $ca += $declaredClassCoupling->getAfferentCoupling(); |
69 | 69 | } |
70 | 70 | |
71 | - if($ca + $ce > 0) { |
|
71 | + if ($ca + $ce > 0) { |
|
72 | 72 | $instability = $ce / ($ca + $ce); |
73 | 73 | } |
74 | 74 |
@@ -50,9 +50,9 @@ |
||
50 | 50 | $n = 0; |
51 | 51 | $lcom = new LackOfCohesionOfMethods(); |
52 | 52 | |
53 | - foreach($rOOP->getClasses() as $class) { |
|
53 | + foreach ($rOOP->getClasses() as $class) { |
|
54 | 54 | |
55 | - if($class instanceof ReflectedInterface) { |
|
55 | + if ($class instanceof ReflectedInterface) { |
|
56 | 56 | continue; |
57 | 57 | } |
58 | 58 |
@@ -34,13 +34,13 @@ discard block |
||
34 | 34 | $methodsToInspect = $class->getMethods(); |
35 | 35 | |
36 | 36 | $toSkip = array(); |
37 | - foreach($methodsToInspect as $method) { |
|
37 | + foreach ($methodsToInspect as $method) { |
|
38 | 38 | |
39 | - if(in_array($method->getName(), $toSkip)) { |
|
39 | + if (in_array($method->getName(), $toSkip)) { |
|
40 | 40 | continue; |
41 | 41 | } |
42 | 42 | |
43 | - if($method->isSetter() ||$method->isGetter()) { |
|
43 | + if ($method->isSetter() || $method->isGetter()) { |
|
44 | 44 | continue; |
45 | 45 | } |
46 | 46 | |
@@ -78,8 +78,8 @@ discard block |
||
78 | 78 | |
79 | 79 | // foreach directly linked methods, recurs |
80 | 80 | $methods = $class->getMethods(); |
81 | - foreach($linked as $link) { |
|
82 | - if(!isset( $methods[$link])) { |
|
81 | + foreach ($linked as $link) { |
|
82 | + if (!isset($methods[$link])) { |
|
83 | 83 | continue; |
84 | 84 | } |
85 | 85 | $linked = array_merge($linked, $this->getLinkedMethods($class, $methods[$link], $toSkip)); |
@@ -99,18 +99,18 @@ discard block |
||
99 | 99 | $linked = array(); |
100 | 100 | |
101 | 101 | // A calls B |
102 | - if(preg_match_all('!\\$this\\->(\w*?)\\(!im', $method->getContent(), $matches)) { |
|
102 | + if (preg_match_all('!\\$this\\->(\w*?)\\(!im', $method->getContent(), $matches)) { |
|
103 | 103 | list(, $linked) = $matches; |
104 | 104 | } |
105 | 105 | |
106 | 106 | // B calls A |
107 | - foreach($class->getMethods() as $otherMethod) { |
|
107 | + foreach ($class->getMethods() as $otherMethod) { |
|
108 | 108 | $otherCalls = array(); |
109 | - if(preg_match_all('!\\$this\\->(\w*?)\\(!im', $otherMethod->getContent(), $matches)) { |
|
109 | + if (preg_match_all('!\\$this\\->(\w*?)\\(!im', $otherMethod->getContent(), $matches)) { |
|
110 | 110 | list(, $otherCalls) = $matches; |
111 | 111 | } |
112 | 112 | |
113 | - if(in_array($method->getName(), $otherCalls)) { |
|
113 | + if (in_array($method->getName(), $otherCalls)) { |
|
114 | 114 | array_push($linked, $otherMethod->getName()); |
115 | 115 | } |
116 | 116 | } |
@@ -128,29 +128,29 @@ discard block |
||
128 | 128 | |
129 | 129 | $linked = array(); |
130 | 130 | $members = array(); |
131 | - if(preg_match_all('!\\$this\\->([\w\\(]+)!im', $method->getContent(), $matches)) { |
|
131 | + if (preg_match_all('!\\$this\\->([\w\\(]+)!im', $method->getContent(), $matches)) { |
|
132 | 132 | list(, $members) = $matches; |
133 | 133 | } |
134 | 134 | |
135 | 135 | |
136 | 136 | // search in other methods if they share attribute |
137 | - foreach($class->getMethods() as $otherMethod) { |
|
137 | + foreach ($class->getMethods() as $otherMethod) { |
|
138 | 138 | $otherMembers = array(); |
139 | - if(preg_match_all('!\\$this\\->([\w\\(]+)!im', $otherMethod->getContent(), $matches)) { |
|
139 | + if (preg_match_all('!\\$this\\->([\w\\(]+)!im', $otherMethod->getContent(), $matches)) { |
|
140 | 140 | list(, $otherMembers) = $matches; |
141 | 141 | } |
142 | 142 | |
143 | 143 | $intersect = array_intersect($members, $otherMembers); |
144 | 144 | |
145 | 145 | // remove calls (members and calls are mixed : regex is too complex to be read) |
146 | - foreach($intersect as $k => $name) { |
|
147 | - if(preg_match('!\($!', $name)) { |
|
146 | + foreach ($intersect as $k => $name) { |
|
147 | + if (preg_match('!\($!', $name)) { |
|
148 | 148 | unset($intersect[$k]); |
149 | 149 | } |
150 | 150 | } |
151 | 151 | |
152 | 152 | |
153 | - if(sizeof($intersect, COUNT_NORMAL) > 0) { |
|
153 | + if (sizeof($intersect, COUNT_NORMAL) > 0) { |
|
154 | 154 | |
155 | 155 | array_push($linked, $otherMethod->getName()); |
156 | 156 | } |