Completed
Pull Request — master (#180)
by Sebastian
03:36
created
src/Hal/Application/Formater/Violations/Xml.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     /**
51 51
      * @inheritdoc
52 52
      */
53
-    public function terminate(ResultCollection $collection, ResultCollection $groupedResults){
53
+    public function terminate(ResultCollection $collection, ResultCollection $groupedResults) {
54 54
 
55 55
 
56 56
         // root
@@ -61,18 +61,18 @@  discard block
 block discarded – undo
61 61
         $root->setAttribute('timestamp', date('c'));
62 62
 
63 63
         // violations
64
-        foreach($collection as $item) {
64
+        foreach ($collection as $item) {
65 65
             $file = $xml->createElement('file');
66 66
             $file->setAttribute('name', realpath($item->getFilename()));
67 67
 
68 68
             $array = $item->asArray();
69 69
             $hasViolation = false;
70
-            foreach($array as $key => $value) {
70
+            foreach ($array as $key => $value) {
71 71
                 $result = $this->validator->validate($key, $value);
72
-                if(Validator::GOOD !== $result && Validator::UNKNOWN !== $result) {
72
+                if (Validator::GOOD !== $result && Validator::UNKNOWN !== $result) {
73 73
                     $hasViolation = true;
74 74
                     $violation = $xml->createElement('violation');
75
-                    $violation->setAttribute('beginline' , 1);
75
+                    $violation->setAttribute('beginline', 1);
76 76
                     $violation->setAttribute('endline', $array['loc']);
77 77
                     $violation->setAttribute('rule', $key);
78 78
                     $violation->setAttribute('ruleset', $key);
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
                 }
90 90
             }
91 91
 
92
-            if($hasViolation) {
92
+            if ($hasViolation) {
93 93
                 $root->appendChild($file);
94 94
             }
95 95
         }
Please login to merge, or discard this patch.
src/Hal/Application/Rule/RuleSet.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
      */
37 37
     public function __construct(array $rules = array())
38 38
     {
39
-        if(!$rules) {
39
+        if (!$rules) {
40 40
             $rules = array(
41 41
                 'cyclomaticComplexity' => array(10, 6, 2)
42 42
                 , 'maintainabilityIndex' => array(0, 69, 85)
Please login to merge, or discard this patch.
src/Hal/Application/Rule/Validator.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -62,14 +62,14 @@  discard block
 block discarded – undo
62 62
     public function validate($key, $value) {
63 63
         $rule = $this->ruleSet->getRule($key);
64 64
 
65
-        if(!is_array($rule) || !is_numeric($value)) {
65
+        if (!is_array($rule) || !is_numeric($value)) {
66 66
             return self::UNKNOWN;
67 67
         }
68 68
 
69 69
         // according order
70
-        if($rule[0] < $rule[2]) {
70
+        if ($rule[0] < $rule[2]) {
71 71
             // critical < warn < good
72
-            switch(true) {
72
+            switch (true) {
73 73
                 case $value < $rule[1]:
74 74
                     return self::CRITICAL;
75 75
                 case $value >= $rule[1] && $value < $rule[2]:
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             }
80 80
         }
81 81
         // critical > warn > good
82
-        switch(true) {
82
+        switch (true) {
83 83
             case $value > $rule[1]:
84 84
                 return self::CRITICAL;
85 85
             case $value < $rule[2]:
Please login to merge, or discard this patch.
src/Hal/Application/Score/Calculator.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
         $score = (($note - $bad) / ($good - $bad)) * $this->limit;
33 33
         $score = max(0, $score);
34
-        $score = min ($this->limit, $score);
34
+        $score = min($this->limit, $score);
35 35
         return round($score, 2);
36 36
     }
37 37
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 
46 46
         $score = $this->limit - ($note - $good) / ($bad - $good) * $this->limit;
47 47
         $score = max(0, $score);
48
-        $score = min ($this->limit, $score);
48
+        $score = min($this->limit, $score);
49 49
         return round($score, 2);
50 50
     }
51 51
 }
52 52
\ No newline at end of file
Please login to merge, or discard this patch.
src/Hal/Application/Score/Result.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
  *
17 17
  * @author Jean-François Lépine <https://twitter.com/Halleck45>
18 18
  */
19
-class Result implements ScoreInterface{
19
+class Result implements ScoreInterface {
20 20
 
21 21
     /**
22 22
      * @var array
Please login to merge, or discard this patch.
src/Hal/Application/Score/Scoring.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
  *
24 24
  * @author Jean-François Lépine <https://twitter.com/Halleck45>
25 25
  */
26
-class Scoring implements ScoringInterface{
26
+class Scoring implements ScoringInterface {
27 27
 
28 28
     /**
29 29
      * Maximal score
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         // score
68 68
         $result = new Result;
69
-        foreach($factors as $qualityFactor) {
69
+        foreach ($factors as $qualityFactor) {
70 70
             $score = $qualityFactor->calculate($collection, $groupedResults, $bound);
71 71
             $result->push($qualityFactor->getName(), $score);
72 72
         }
Please login to merge, or discard this patch.
src/Hal/Component/Aggregator/DirectoryAggregatorFlat.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function aggregates(ResultCollection $results) {
42 42
         $array = array();
43
-        foreach($results as $result) {
43
+        foreach ($results as $result) {
44 44
             $basename = dirname($result->getFilename());
45 45
 
46 46
             // from 'folder1/folder2/file.php', we want an array with ('folder1', 'folder1/folder2')
@@ -49,14 +49,14 @@  discard block
 block discarded – undo
49 49
                 return $v;
50 50
             }, array());
51 51
 
52
-            if($this->depth) {
52
+            if ($this->depth) {
53 53
                 array_splice($namespaces, $this->depth);
54 54
             }
55 55
 
56 56
             // merge infos for each namespace in the DirectoryResultCollection
57
-            foreach($namespaces as $namespace) {
57
+            foreach ($namespaces as $namespace) {
58 58
 
59
-                if(!isset($array[$namespace])) {
59
+                if (!isset($array[$namespace])) {
60 60
                     $array[$namespace] = new ResultCollection();
61 61
                 }
62 62
 
Please login to merge, or discard this patch.
src/Hal/Component/Aggregator/DirectoryRecursiveAggregator.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -41,35 +41,35 @@
 block discarded – undo
41 41
      */
42 42
     public function aggregates(ResultCollection $results) {
43 43
         $array = new ResultCollection();
44
-        foreach($results as $result) {
44
+        foreach ($results as $result) {
45 45
             $basename = dirname($result->getFilename());
46 46
 
47 47
             // from 'folder1/folder2/file.php', we want an array with ('folder1', 'folder2')
48 48
             $namespaces = explode(DIRECTORY_SEPARATOR, $basename);
49 49
 
50
-            if($this->depth) {
50
+            if ($this->depth) {
51 51
                 array_splice($namespaces, $this->depth);
52 52
             }
53 53
 
54 54
             // merge infos for each namespace in the DirectoryResultCollection
55 55
             $len = sizeof($namespaces, COUNT_NORMAL);
56 56
 
57
-            for($i = 0; $i < $len; $i++) {
57
+            for ($i = 0; $i < $len; $i++) {
58 58
 
59 59
                 $namespace = $namespaces[$i];
60
-                if(0 === strlen($namespace)) {
60
+                if (0 === strlen($namespace)) {
61 61
                     $namespace = '.';
62 62
                 }
63 63
 
64
-                if(0 === $i) {
64
+                if (0 === $i) {
65 65
                     // root
66
-                    if(!isset($array[$namespace])) {
66
+                    if (!isset($array[$namespace])) {
67 67
                         $array[$namespace] = new ResultCollection();
68 68
                     }
69 69
                     $parent = &$array[$namespace];
70 70
                 } else {
71 71
                     // namespace
72
-                    if(!isset($parent[$namespace])) {
72
+                    if (!isset($parent[$namespace])) {
73 73
                         $parent[$namespace] = new ResultCollection(); // ResultRecursiveCollection -> has getOOP(), etc.
74 74
                     }
75 75
                     $parent = &$parent[$namespace];
Please login to merge, or discard this patch.
src/Hal/Component/Bounds/Bounds.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,12 +28,12 @@
 block discarded – undo
28 28
         $arrayMerged = call_user_func_array('array_merge_recursive', $array);
29 29
 
30 30
         $min = $max = $average = $sum = array();
31
-        foreach($arrayMerged as $key => $values) {
31
+        foreach ($arrayMerged as $key => $values) {
32 32
             $values = (array) $values;
33 33
             $max[$key] = max($values);
34 34
             $min[$key] = min($values);
35 35
             $sum[$key] = array_sum($values);
36
-            $average[$key] = round($sum[$key] / count($values, COUNT_NORMAL),2);
36
+            $average[$key] = round($sum[$key] / count($values, COUNT_NORMAL), 2);
37 37
         }
38 38
 
39 39
         return new BoundsResult($min, $max, $average, $sum);
Please login to merge, or discard this patch.