Hal\Metric\System\UnitTesting\UnitTesting::calculate()

Complexity

Conditions	14
Paths	90

Size

Total Lines	99
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function calculate(Metrics $metrics)
    {

        if (!$this->config->has('junit')) {
            return;
        }

        // parse junit file
        $filename = $this->config->get('junit');

Are you sure the assignment to $filename is correct as $this->config->get('junit') (which targets Hal\Application\Config\Config::get()) seems to always return null.

        if (!file_exists($filename) || !is_readable($filename)) {
            throw new ConfigException('JUnit report cannot be read');
        }

        $unitsTests = [];
        $infoAboutTests = [];
        $projectMetric = new ProjectMetric('unitTesting');

        // injects default value for each metric
        foreach ($metrics->all() as $metric) {
            $metric->set('numberOfUnitTests', 0);
        }

        // parsing of XML file without any dependency to DomDocument or simpleXML
        // we want to be compatible with every platforms
        $xml = file_get_contents($filename);
        if (preg_match_all('!<testsuite name="(.*?)" file="(.*?)"!i', $xml, $matches, PREG_SET_ORDER)) {
            foreach ($matches as $m) {
                list(, $classname, $fileOfUnitTest) = $m;
                $unitsTests[$fileOfUnitTest] = $classname;
            }
        }

        // analyze each unit test
        // This code is slow and can be optimized
        foreach ($unitsTests as $filename => $classname) {
            $metricsOfUnitTest = new Metrics();
            $parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7);
            $traverser = new \PhpParser\NodeTraverser();
            $traverser->addVisitor(new \PhpParser\NodeVisitor\NameResolver());
            $traverser->addVisitor(new ClassEnumVisitor($metricsOfUnitTest));
            $traverser->addVisitor(new ExternalsVisitor($metricsOfUnitTest));

            $code = file_get_contents($filename);
            $stmts = $parser->parse($code);
            $traverser->traverse($stmts);

It seems like $stmts defined by $parser->parse($code) on line 83 can also be of type null; however, PhpParser\NodeTraverser::traverse() does only seem to accept array<integer,object<PhpParser\Node>>, maybe add an additional type check?

            if (!$metricsOfUnitTest->has($classname)) {
                continue;
            }

            // list of externals sources of unit test
            $metric = $metricsOfUnitTest->get($classname);

Are you sure the assignment to $metric is correct as $metricsOfUnitTest->get($classname) (which targets Hal\Metric\Metrics::get()) seems to always return null.

            $externals = (array)$metric->get('externals');

            // global stats for each test
            $infoAboutTests[$classname] = (object)[
                'nbExternals' => sizeof(array_unique($externals)),
                'externals' => array_unique($externals),
                'filename' => $fileOfUnitTest,

The variable $fileOfUnitTest does not seem to be defined for all execution paths leading up to this point.

                'classname' => $classname
            ];

            foreach ($externals as $external) {

                // search for this external in metrics
                if (!$metrics->has($external)) {
                    continue;
                }

                // SUT (tested class) has unit test
                $numberOfUnitTest = $metrics->get($external)->get('numberOfUnitTests');

The method get cannot be called on $metrics->get($external) (of type null).

                $numberOfUnitTest++;
                $metrics->get($external)->set('numberOfUnitTests', $numberOfUnitTest);

The method set cannot be called on $metrics->get($external) (of type null).

            }
        }

        // statistics
        $sum = 0;
        $nb = 0;
        foreach ($metrics->all() as $metric) {
            if (!$metric instanceof ClassMetric) {
                continue;
            }

            $sum++;
            if ($metric->get('numberOfUnitTests') > 0) {
                $nb++;
            }
        }

        $projectMetric->set('tests', $infoAboutTests);
        $projectMetric->set('nbTests', sizeof($unitsTests));
        $projectMetric->set('nbCoveredClasses', $nb);
        $projectMetric->set('percentCoveredClasses', round($nb / $sum * 100, 2));
        $projectMetric->set('nbUncoveredClasses', $sum - $nb);
        $projectMetric->set('percentUncoveredClasses', round(($sum - $nb) / $sum * 100, 2));

        $metrics->attach($projectMetric);
    }
}