Issuer::onError() - Code Metrics - Inspection of "forced version of phar" - phpmetrics/PhpMetrics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bdaaad...4f4372 )

by personal

created 2017-01-30 05:16 UTC

Issuer::onError() C

↳ Parent: Issuer

Complexity

Conditions	7
Paths	10

Size

Total Lines	73
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	34
nc	10
nop	4
dl	0
loc	73
rs	6.6896
c	0
b	0
f	0

How to fix Long Method

<?php

/*
 * (c) Jean-François Lépine <https://twitter.com/Halleck45>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Hal\Component\Issue;

use PhpParser\Node;
use PhpParser\PrettyPrinter\Standard;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Issuer
 * @package Hal\Component\Issue
 */
class Issuer
{

    /**
     * @var array
     */
    private $debug = [];

    /**
     * @var OutputInterface
     */
    private $output;

    /**
     * Issuer constructor.
     * @param OutputInterface $output
     */
    public function __construct(OutputInterface $output)
    {
        $this->output = $output;
    }

    /**
     * @param $errno
     * @param $errstr
     * @param $errfile
     * @param $errline
     * @throws \ErrorException
     */
    public function onError($errno, $errstr, $errfile, $errline)
    {
        if (error_reporting() == 0) {
            return;
        }
        $php = PHP_VERSION;
        $os = php_uname();
        $phpmetrics = getVersion();
        $traces = debug_backtrace(0, 10);
        $trace = '';
        foreach ($traces as $c) {
            if (isset($c['file'])) {
                $trace .= sprintf("+ %s (line %d)\n", $c['file'], $c['line']);
            }
        }

        $debug = '';
        foreach ($this->debug as $key => $value) {
            if ($value instanceof Node || is_array($value)) {
                $value = (new Standard())->prettyPrint($value);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            $debug .= sprintf("%s: %s\n", $key, $value);
        }

        $logfile = './phpmetrics-error.log';

        $message = <<<EOT

<error>We're sorry : an unexpected error occured.</error>
 
<question>Can you help us ?</question> Please open a new issue at https://github.com/phpmetrics/PhpMetrics/issues/new, and copy-paste the content 
of this file: $logfile ?

Thanks for your help :)

EOT;

        $log = <<<EOT
## Title: $errstr

## Message:

Hi,

This issue occured:

$errstr

**Environment**

+ PHP: $php
+ PhpMetrics: $phpmetrics
+ Operating System: $os
+ File: $errfile (line $errline)

<details>
  <summary>Details</summary>
  ```
$trace


$debug
```
</details>

EOT;

        $this->output->write($message);

        $this->log($logfile, $log);
        $this->terminate(1);
    }

    /**
     * @return $this
     */
    public function enable()
    {
        set_error_handler([$this, 'onError']);
        return $this;
    }

    /**
     * @param $status
     */
    protected function terminate($status)
    {
        exit($status);

    }

    /**
     * @param $log
     * @return $this
     */
    protected function log($logfile, $log)
    {
        if (is_writable(getcwd())) {
            file_put_contents($logfile, $log);
        } else {
            $this->output->write($log);
        }
        return $this;
    }

    /**
     * @param $debugKey
     * @param $value
     * @return $this
     */
    public function set($debugKey, $value)
    {
        $this->debug[$debugKey] = $value;
        return $this;
    }

    /**
     * @param $debugKey
     * @return $this
     */
    public function clear($debugKey)
    {
        unset($this->debug[$debugKey]);
        return $this;
    }
}



1			<?php
2
3			/*
4			* (c) Jean-François Lépine <https://twitter.com/Halleck45>
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace Hal\Component\Issue;
11
12			use PhpParser\Node;
13			use PhpParser\PrettyPrinter\Standard;
14			use Symfony\Component\Console\Output\OutputInterface;
15
16			/**
17			* Class Issuer
18			* @package Hal\Component\Issue
19			*/
20			class Issuer
21			{
22
23			/**
24			* @var array
25			*/
26			private $debug = [];
27
28			/**
29			* @var OutputInterface
30			*/
31			private $output;
32
33			/**
34			* Issuer constructor.
35			* @param OutputInterface $output
36			*/
37			public function __construct(OutputInterface $output)
38			{
39			$this->output = $output;
40			}
41
42			/**
43			* @param $errno
44			* @param $errstr
45			* @param $errfile
46			* @param $errline
47			* @throws \ErrorException
48			*/
49			public function onError($errno, $errstr, $errfile, $errline)
50			{
51			if (error_reporting() == 0) {
52			return;
53			}
54			$php = PHP_VERSION;
55			$os = php_uname();
56			$phpmetrics = getVersion();
57			$traces = debug_backtrace(0, 10);
58			$trace = '';
59			foreach ($traces as $c) {
60			if (isset($c['file'])) {
61			$trace .= sprintf("+ %s (line %d)\n", $c['file'], $c['line']);
62			}
63			}
64
65			$debug = '';
66			foreach ($this->debug as $key => $value) {
67			if ($value instanceof Node \|\| is_array($value)) {
68			$value = (new Standard())->prettyPrint($value);
			0 ignored issues – show Documentation introduced 2017-01-30 05:20 UTC by Report Bug Copy Issue Report `$value` is of type `object<PhpParser\Node>\|array`, but the function expects a `array<integer,object<PhpParser\Node>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
69			}
70
71			$debug .= sprintf("%s: %s\n", $key, $value);
72			}
73
74			$logfile = './phpmetrics-error.log';
75
76			$message = <<<EOT
77
78			<error>We're sorry : an unexpected error occured.</error>
79
80			<question>Can you help us ?</question> Please open a new issue at https://github.com/phpmetrics/PhpMetrics/issues/new, and copy-paste the content
81			of this file: $logfile ?
82
83			Thanks for your help :)
84
85			EOT;
86
87			$log = <<<EOT
88			## Title: $errstr
89
90			## Message:
91
92			Hi,
93
94			This issue occured:
95
96			$errstr
97
98			Environment
99
100			+ PHP: $php
101			+ PhpMetrics: $phpmetrics
102			+ Operating System: $os
103			+ File: $errfile (line $errline)
104
105			<details>
106			<summary>Details</summary>
107			```
108			$trace
109
110
111			$debug
112			```
113			</details>
114
115			EOT;
116
117			$this->output->write($message);
118
119			$this->log($logfile, $log);
120			$this->terminate(1);
121			}
122
123			/**
124			* @return $this
125			*/
126			public function enable()
127			{
128			set_error_handler([$this, 'onError']);
129			return $this;
130			}
131
132			/**
133			* @param $status
134			*/
135			protected function terminate($status)
136			{
137			exit($status);
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-30 05:20 UTC by Report Bug Copy Issue Report The method `terminate()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
138			}
139
140			/**
141			* @param $log
142			* @return $this
143			*/
144			protected function log($logfile, $log)
145			{
146			if (is_writable(getcwd())) {
147			file_put_contents($logfile, $log);
148			} else {
149			$this->output->write($log);
150			}
151			return $this;
152			}
153
154			/**
155			* @param $debugKey
156			* @param $value
157			* @return $this
158			*/
159			public function set($debugKey, $value)
160			{
161			$this->debug[$debugKey] = $value;
162			return $this;
163			}
164
165			/**
166			* @param $debugKey
167			* @return $this
168			*/
169			public function clear($debugKey)
170			{
171			unset($this->debug[$debugKey]);
172			return $this;
173			}
174			}
175
176

phpmetrics / PhpMetrics

Push — master ( bdaaad...4f4372 )

Issuer::onError() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like