Hal\Report\Cli\Reporter

Complexity

Total Complexity

14

Size/Duplication

Total Lines	164
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	generate()	0	19	4
B	reportConsolidated()	0	73	4
A	reportGitUsages()	0	21	4
A	reportUnitTesting()	0	11	1

<?php
namespace Hal\Report\Cli;

use Hal\Application\Config\Config;
use Hal\Component\Output\Output;
use Hal\Metric\Consolidated;
use Hal\Metric\Metric;
use Hal\Metric\Metrics;
use Hal\Report\ReporterInterface;

/**
 * This class takes care about the global output into the STDOUT of consolidated metrics.
 */
class Reporter implements ReporterInterface
{
    /** @var Config */
    private $config;

    /** @var Output */
    private $output;

    /**
     * @param Config $config
     * @param Output $output
     */
    public function __construct(Config $config, Output $output)
    {
        $this->config = $config;
        $this->output = $output;
    }

    /**
     * {@inheritDoc}
     */
    public function generate(Metrics $metrics)
    {
        if ($this->config->has('quiet')) {
            return;
        }

        $consolidated = new Consolidated($metrics);
        $out = $this->reportConsolidated($metrics, $consolidated);

        if ($this->config->has('git')) {
            $out .= $this->reportGitUsages($consolidated);
        }

        if ($this->config->has('junit')) {
            $out .= $this->reportUnitTesting($metrics->get('unitTesting'));

It seems like $metrics->get('unitTesting') can be null; however, reportUnitTesting() does not accept null, maybe add an additional type check?

        }

        $this->output->write($out . "\n");
    }

    /**
     * @param Metrics $metrics
     * @param Consolidated $consolidated
     * @return string
     */
    private function reportConsolidated(Metrics $metrics, Consolidated $consolidated)
    {
        $sum = $consolidated->getSum();
        $avg = $consolidated->getAvg();

        $methodsByClass = $locByClass = $locByMethod = 0;
        if ($sum->nbClasses > 0) {
            $methodsByClass = round($sum->nbMethods / $sum->nbClasses, 2);
            $locByClass = round($sum->lloc / $sum->nbClasses);
        }
        if ($sum->nbMethods > 0) {
            $locByMethod = round($sum->lloc / $sum->nbMethods);
        }

        $inheritanceTreeDepthReport = '';
        $treeMetric = $metrics->get('tree');
        if (null !== $treeMetric) {
            $inheritanceTreeDepthReport = <<<EOT
    Depth of Inheritance Tree                   {$treeMetric->get('depthOfInheritanceTree')}

EOT;
        }

        return <<<EOT
LOC
    Lines of code                               {$sum->loc}
    Logical lines of code                       {$sum->lloc}
    Comment lines of code                       {$sum->cloc}
    Average volume                              {$avg->volume}
    Average comment weight                      {$avg->commentWeight}
    Average intelligent content                 {$avg->commentWeight}
    Logical lines of code by class              {$locByClass}
    Logical lines of code by method             {$locByMethod}

Object oriented programming
    Classes                                     {$sum->nbClasses}
    Interface                                   {$sum->nbInterfaces}
    Methods                                     {$sum->nbMethods}
    Methods by class                            {$methodsByClass}
    Lack of cohesion of methods                 {$avg->lcom}

Coupling
    Average afferent coupling                   {$avg->afferentCoupling}
    Average efferent coupling                   {$avg->efferentCoupling}
    Average instability                         {$avg->instability}
{$inheritanceTreeDepthReport}
Package
    Packages                                    {$sum->nbPackages}
    Average classes per package                 {$avg->classesPerPackage}
    Average distance                            {$avg->distance}
    Average incoming class dependencies         {$avg->incomingCDep}
    Average outgoing class dependencies         {$avg->outgoingCDep}
    Average incoming package dependencies       {$avg->incomingPDep}
    Average outgoing package dependencies       {$avg->outgoingPDep}

Complexity
    Average Cyclomatic complexity by class      {$avg->ccn}
    Average Weighted method count by class      {$avg->wmc}
    Average Relative system complexity          {$avg->relativeSystemComplexity}
    Average Difficulty                          {$avg->difficulty}

Bugs
    Average bugs by class                       {$avg->bugs}
    Average defects by class (Kan)              {$avg->kanDefect}

Violations
    Critical                                    {$sum->violations->critical}
    Error                                       {$sum->violations->error}
    Warning                                     {$sum->violations->warning}
    Information                                 {$sum->violations->information}

EOT;
    }

    /**
     * Returns the CLI output block dedicated to Git stats.
     * @param Consolidated $consolidated
     * @return string
     */
    private function reportGitUsages(Consolidated $consolidated)
    {
        $out = '';
        $commits = [];
        foreach ($consolidated->getFiles() as $name => $file) {
            $commits[$name] = $file['gitChanges'];
        }
        arsort($commits);
        $commits = array_slice($commits, 0, 10);

        $out .= "\nTop 10 committed files";
        foreach ($commits as $file => $nb) {
            $out .= sprintf("\n    %d    %s", $nb, $file);
        }
        if ([] === $commits) {
            $out .= "\n    NA";
        }
        $out .= "\n";

        return $out;
    }

    /**
     * Returns the CLI output block dedicated to Unit Testing stats.
     * @param Metric $unitTestingMetric
     * @return string
     */
    private function reportUnitTesting(Metric $unitTestingMetric)
    {
        return <<<EOT

Unit testing
    Number of unit tests                        {$unitTestingMetric->get('nbSuites')}
    Classes called by tests                     {$unitTestingMetric->get('nbCoveredClasses')}
    Classes called by tests (percent)           {$unitTestingMetric->get('percentCoveredClasses')} %

EOT;
    }
}