phpmetrics / PhpMetrics

src/Hal/Metric/BagTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return null
      */
     public function get($key)

src/Hal/Report/Html/Reporter.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
     }
 
     /**
-     * @param $source
-     * @param $destination
+     * @param string $source
+     * @param string $destination
      * @return $this
      */
     public function renderPage($source, $destination, Consolidated $consolidated, $history)

Spacing +22 added lines, -22 removed lines

@@ -44,11 +44,11 @@ 
         $consolidated = new Consolidated($metrics);
 
         // history of builds
-        $today = (object)[
+        $today = (object) [
             'avg' => $consolidated->getAvg(),
             'sum' => $consolidated->getSum()
         ];
-        $files = glob($logDir . '/js/history-*.json');
+        $files = glob($logDir.'/js/history-*.json');
         $next = sizeof($files) + 1;
         $history = [];
         natsort($files);
@@ -57,34 +57,34 @@ 
         }
 
         // copy sources
-        if(!file_exists($logDir . '/js')) {
+        if (!file_exists($logDir.'/js')) {
             mkdir($logDir.'/js', 0755, true);
         }
-        if(!file_exists($logDir . '/css')) {
+        if (!file_exists($logDir.'/css')) {
             mkdir($logDir.'/css', 0755, true);
         }
-        if(!file_exists($logDir . '/images')) {
+        if (!file_exists($logDir.'/images')) {
             mkdir($logDir.'/images', 0755, true);
         }
-        recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
-        recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
-        recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
+        recurse_copy(__DIR__.'/template/js', $logDir.'/js');
+        recurse_copy(__DIR__.'/template/css', $logDir.'/css');
+        recurse_copy(__DIR__.'/template/images', $logDir.'/images');
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
         if ($this->config->has('junit')) {
-            $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
         }
 
         // js data
@@ -99,8 +99,8 @@ 
 
         // json data
         file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(sprintf('HTML report generated in "%s" directory', $logDir));
@@ -168,7 +168,7 @@ 
 
         $diff = $newValue - $oldValue;
         if ($diff > 0) {
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
         }
 
         $goodOrBad = 'neutral';

src/functions.php

Spacing +6 added lines, -6 removed lines

@@ -90,7 +90,7 @@ 
     }
 
     if ($node instanceof \PhpParser\Node\Name\FullyQualified) {
-        return (string)$node;
+        return (string) $node;
     }
     if ($node instanceof \PhpParser\Node\Expr\New_) {
         return getNameOfNode($node->class);
@@ -101,7 +101,7 @@ 
     }
 
     if ($node instanceof \PhpParser\Node\Name) {
-        return (string)implode($node->parts);
+        return (string) implode($node->parts);
     }
 
     if (isset($node->name) && $node->name instanceof \PhpParser\Node\Expr\Variable) {
@@ -129,7 +129,7 @@ 
     }
 
     if (isset($node->name)) {
-        return (string)$node->name;
+        return (string) $node->name;
     }
 
     return null;
@@ -147,10 +147,10 @@ 
     }
     while (false !== ($file = readdir($dir))) {
         if (($file != '.') && ($file != '..')) {
-            if (is_dir($src . '/' . $file)) {
-                recurse_copy($src . '/' . $file, $dst . '/' . $file);
+            if (is_dir($src.'/'.$file)) {
+                recurse_copy($src.'/'.$file, $dst.'/'.$file);
             } else {
-                copy($src . '/' . $file, $dst . '/' . $file);
+                copy($src.'/'.$file, $dst.'/'.$file);
             }
         }
     }

Doc Comments +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
 
 /**
  * @param $node
- * @param $callback
+ * @param Closure $callback
  */
 function iterate_over_node($node, $callback)
 {
@@ -136,8 +136,8 @@ 
 }
 
 /**
- * @param $src
- * @param $dst
+ * @param string $src
+ * @param string $dst
  */
 function recurse_copy($src, $dst)
 {

src/Hal/Violation/Violations.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     {
         $string = '';
         foreach ($this->data as $violation) {
-            $string .= $violation->getName() . ',';
+            $string .= $violation->getName().',';
         }
         return $string;
     }

src/Hal/Component/Ast/NodeTraverser.php

Spacing +2 added lines, -2 removed lines

@@ -25,9 +25,9 @@
     {
         parent::__construct($cloneNodes);
 
-        if(null === $stopCondition) {
+        if (null === $stopCondition) {
             $stopCondition = function($node) {
-                if($node instanceof Node\Stmt\Class_ || $node instanceof Node\Stmt\Interface_) {
+                if ($node instanceof Node\Stmt\Class_ || $node instanceof Node\Stmt\Interface_) {
                     return false;
                 }
 

Doc Comments +3 added lines

@@ -21,6 +21,9 @@
 {
     protected $stopCondition;
 
+    /**
+     * @param \Closure $stopCondition
+     */
     public function __construct($cloneNodes = false, $stopCondition = null)
     {
         parent::__construct($cloneNodes);

src/Hal/Component/File/Finder.php

Spacing +3 added lines, -3 removed lines

@@ -71,14 +71,14 @@
         $files = array();
         foreach ($paths as $path) {
             if (is_dir($path)) {
-                $path = rtrim($path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
+                $path = rtrim($path, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR;
                 $directory = new RecursiveDirectoryIterator($path, $this->flags);
                 $iterator = new RecursiveIteratorIterator($directory);
 
                 $filterRegex = sprintf(
                     '`^%s%s$`',
-                    !empty($this->excludedDirs) ? '((?!' . implode('|', $this->excludedDirs) . ').)+' : '.+',
-                    '\.(' . implode('|', $this->extensions) . ')'
+                    !empty($this->excludedDirs) ? '((?!'.implode('|', $this->excludedDirs).').)+' : '.+',
+                    '\.('.implode('|', $this->extensions).')'
                 );
 
                 $filteredIterator = new RegexIterator(

src/Hal/Report/Html/template/relations.php

Spacing +6 added lines, -6 removed lines

@@ -1,17 +1,17 @@ 
-<?php require __DIR__ . '/_header.php'; ?>
+<?php require __DIR__.'/_header.php'; ?>
 
 <?php
 $relations = [];
 $classesCp = [];
 foreach ($classes as $class) {
 
-    $class['name'] = '\\' . $class['name'];
+    $class['name'] = '\\'.$class['name'];
     $classesCp[$class['name']] = $class;
     $classesCp[$class['name']]['externals'] = [];
 
 
     foreach ($class['externals'] as &$ext) {
-        $ext = '\\' . $ext;
+        $ext = '\\'.$ext;
         if (!isset($classes[$ext])) {
             $classesCp[$ext] = [
                 'name' => $ext,
@@ -22,10 +22,10 @@ 
     }
 }
 foreach ($classesCp as $class) {
-    array_push($relations, (object)[
+    array_push($relations, (object) [
         'name' => $class['name'],
         'size' => 3000,
-        'relations' => (array)array_values(array_unique($class['externals'])),
+        'relations' => (array) array_values(array_unique($class['externals'])),
     ]);
 }
 ?>
@@ -40,7 +40,7 @@ 
     </div>
 </div>
 
-<?php require __DIR__ . '/_footer.php'; ?>
+<?php require __DIR__.'/_footer.php'; ?>
 
 
 <script type="text/javascript">

src/Hal/Report/Html/template/complexity.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-require __DIR__ . '/_header.php'; ?>
+require __DIR__.'/_header.php'; ?>
 
     <div class="row">
         <div class="column">
@@ -79,4 +79,4 @@ 
     </div>
 
 
-<?php require __DIR__ . '/_footer.php'; ?>
\ No newline at end of file
+<?php require __DIR__.'/_footer.php'; ?>
\ No newline at end of file

src/Hal/Report/Html/template/git.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-require __DIR__ . '/_header.php'; ?>
+require __DIR__.'/_header.php'; ?>
 
 
 <?php
@@ -12,12 +12,12 @@ 
     $history = array_slice($history, -24);
     $json = [];
     foreach ($history as $date => $values) {
-        array_push($json, (object)[
+        array_push($json, (object) [
             'date' => $date,
             'key' => 'Additions',
             'value' => abs($values['additions']),
         ]);
-        array_push($json, (object)[
+        array_push($json, (object) [
             'date' => $date,
             'key' => 'Removes',
             'value' => abs($values['removes']),
@@ -94,7 +94,7 @@ 
     </div>
 </div>
 
-<?php require __DIR__ . '/_footer.php'; ?>
+<?php require __DIR__.'/_footer.php'; ?>
 
 
 <script type="text/javascript">