phpmetrics / PhpMetrics

src/Hal/Component/OOP/Extractor/Searcher.php

Spacing +15 added lines, -15 removed lines

@@ -30,9 +30,9 @@ 
     {
         $end = sizeof($tokens, COUNT_NORMAL);
         $value = '';
-        while($startingToken < $end) {
+        while ($startingToken < $end) {
             $token = $tokens[$startingToken];
-            if(in_array($token->getValue(), $delimiters)) {
+            if (in_array($token->getValue(), $delimiters)) {
                 return $value;
             }
             $value .= $token->getValue();
@@ -52,8 +52,8 @@ 
     public function getPrevious(&$startingToken, TokenCollection $tokens)
     {
         $p = $startingToken - 1;
-        for($i = $p ; $i > 0; $i--) {
-            if(T_WHITESPACE !== $tokens[$i]->getType()) {
+        for ($i = $p; $i > 0; $i--) {
+            if (T_WHITESPACE !== $tokens[$i]->getType()) {
                 return $tokens[$i];
             }
         }
@@ -88,19 +88,19 @@ 
         $openBrace = 0;
         $start = null;
         $len = sizeof($tokens);
-        for($i = $startingToken; $i < $len; $i++) {
+        for ($i = $startingToken; $i < $len; $i++) {
             $token = $tokens[$i];
-            if(T_STRING == $token->getType()) {
-                switch($token->getValue()) {
+            if (T_STRING == $token->getType()) {
+                switch ($token->getValue()) {
                     case '{':
                         $openBrace++;
-                        if(is_null($start)) {
+                        if (is_null($start)) {
                             $start = $startingToken = $i + 1;
                         }
                         break;
                     case '}':
                         $openBrace--;
-                        if($openBrace <= 0) {
+                        if ($openBrace <= 0) {
                             return $i;
                         }
                         break;
@@ -119,7 +119,7 @@ 
      */
     public function getExtendPosition(TokenCollection $tokens, $startingToken)
     {
-        for($i = $startingToken; $i > 0; $i--) {
+        for ($i = $startingToken; $i > 0; $i--) {
             $token = $tokens[$i];
             if ($token->getValue() === 'extends') {
                 return $i;
@@ -136,7 +136,7 @@ 
     public function getClassNamePosition(TokenCollection $tokens)
     {
         $len = sizeof($tokens);
-        for($i = 0; $i < $len; $i++) {
+        for ($i = 0; $i < $len; $i++) {
             $token = $tokens[$i];
             if ($token->getValue() === 'class') {
                 return $i;
@@ -155,8 +155,8 @@ 
      */
     public function getPositionOfPrevious($tokenType, $startingToken, TokenCollection $tokens)
     {
-        for($i = $startingToken; $i > 0; $i--) {
-            if($tokenType == $tokens->get($i)->getType()) {
+        for ($i = $startingToken; $i > 0; $i--) {
+            if ($tokenType == $tokens->get($i)->getType()) {
                 return $i;
             }
         }
@@ -174,8 +174,8 @@ 
     public function getPositionOfNext($tokenType, $startingToken, TokenCollection $tokens) 
     {
         $len = sizeof($tokens);
-        for($i = $startingToken; $i < $len; $i++) {
-            if($tokenType == $tokens->get($i)->getType()) {
+        for ($i = $startingToken; $i < $len; $i++) {
+            if ($tokenType == $tokens->get($i)->getType()) {
                 return $i;
             }
         }

src/Hal/Component/Token/Dumper.php

Spacing +3 added lines, -3 removed lines

@@ -26,13 +26,13 @@
     public function dump(TokenCollection $tokens, $start = 0, $len = 0)
     {
         $str = '';
-        if($len == 0) {
+        if ($len == 0) {
             $len = sizeof($tokens);
         }
-        if($start < 0) {
+        if ($start < 0) {
             $start = 0;
         }
-        for($i = $start; $i < $len; $i++) {
+        for ($i = $start; $i < $len; $i++) {
             $str .= sprintf("\n%s : %s", token_name($tokens[$i]->getType()), $tokens[$i]->getValue());
         }
         return $str;

src/Hal/Component/OOP/Extractor/Extractor.php

Spacing +9 added lines, -9 removed lines

@@ -48,7 +48,7 @@ 
 
         $this->tokenizer = $tokenizer;
         $this->searcher = new Searcher();
-        $this->result= new Result;
+        $this->result = new Result;
 
         $this->extractors = (object) array(
             'class' => new ClassExtractor($this->searcher)
@@ -80,9 +80,9 @@ 
         $endAnonymous = 0;
         $mainContextClass = null; // class containing a anonymous class
 
-        for($n = 0; $n < $len; $n++) {
+        for ($n = 0; $n < $len; $n++) {
 
-            if($mainContextClass && $n > $endAnonymous) {
+            if ($mainContextClass && $n > $endAnonymous) {
                 // anonymous class is finished. We back to parent class
                 // methods will be added to the main class now
                 $class = $mainContextClass;
@@ -91,7 +91,7 @@ 
 
             $token = $tokens[$n];
 
-            switch($token->getType()) {
+            switch ($token->getType()) {
 
                 case T_USE:
                     $alias = $this->extractors->alias->extract($n, $tokens);
@@ -131,7 +131,7 @@ 
                 case T_CLASS:
                     $i = $n;
                     // avoid MyClass::class syntax
-                    if($this->searcher->isPrecededBy(T_DOUBLE_COLON, $i, $tokens, 1)) {
+                    if ($this->searcher->isPrecededBy(T_DOUBLE_COLON, $i, $tokens, 1)) {
                         continue;
                     }
 
@@ -142,14 +142,14 @@ 
                     $result->pushClass($c);
 
                     // PHP 7 and inner classes
-                    if($c instanceof ReflectedAnonymousClass) {
+                    if ($c instanceof ReflectedAnonymousClass) {
                         // avoid to consider anonymous class as main class
                         $p = $n;
                         $endAnonymous = $this->searcher->getPositionOfClosingBrace($p, $tokens);
                         $mainContextClass = $class;
 
                         // add anonymous class in method
-                        if($method) {
+                        if ($method) {
                             $method->pushAnonymousClass($c);
                         }
                     }
@@ -157,10 +157,10 @@ 
                     break;
 
                 case T_FUNCTION:
-                    if($class) {
+                    if ($class) {
                         // avoid closure
                         $next = $tokens[$n + 1];
-                        if(T_WHITESPACE != $next->getType()) {
+                        if (T_WHITESPACE != $next->getType()) {
                             continue;
                         }
                         $method = $this->extractors->method->extract($n, $tokens, $class);

src/Hal/Application/Command/Job/QueueAnalyzeFactory.php

Unused Use Statements -4 removed lines

@@ -9,10 +9,6 @@
 
 namespace Hal\Application\Command\Job;
 use Hal\Application\Extension\ExtensionService;
-use Hal\Application\Formater\Chart;
-use Hal\Application\Formater\Details;
-use Hal\Application\Formater\Summary;
-use Hal\Application\Formater\Violations;
 use Hal\Application\Score\Scoring;
 use Hal\Component\Aggregator\DirectoryAggregatorFlat;
 use Hal\Component\Bounds\BoundsInterface;

src/Hal/Application/Command/Job/QueueReportFactory.php

Unused Use Statements -3 removed lines

@@ -10,13 +10,10 @@
 namespace Hal\Application\Command\Job;
 use Hal\Application\Extension\ExtensionService;
 use Hal\Application\Extension\extensionsService;
-use Hal\Application\Extension\Repository;
 use Hal\Application\Formater\Chart;
 use Hal\Application\Formater\Details;
 use Hal\Application\Formater\Summary;
 use Hal\Application\Formater\Violations;
-use Hal\Application\Score\Scoring;
-use Hal\Component\Aggregator\DirectoryAggregatorFlat;
 use Hal\Component\Bounds\BoundsInterface;
 use Hal\Component\Config\ConfigurationInterface;
 use Hal\Component\File\Finder;

src/Hal/Application/Command/RunMetricsCommand.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 
 namespace Hal\Application\Command;
 use Hal\Application\Command\Job\QueueAnalyzeFactory;
-use Hal\Application\Command\Job\QueueFactory;
 use Hal\Application\Command\Job\QueueReportFactory;
 use Hal\Application\Config\ConfigFactory;
 use Hal\Application\Extension\ExtensionService;

Spacing +7 added lines, -7 removed lines

@@ -42,7 +42,7 @@ 
                     'path', InputArgument::OPTIONAL, 'Path to explore'
                 )
                 ->addOption(
-                    'report-html',null, InputOption::VALUE_REQUIRED, 'Path to save report in HTML format. Example: /tmp/report.html'
+                    'report-html', null, InputOption::VALUE_REQUIRED, 'Path to save report in HTML format. Example: /tmp/report.html'
                 )
                 ->addOption(
                     'report-xml', null, InputOption::VALUE_REQUIRED, 'Path to save summary report in XML format. Example: /tmp/report.xml'
@@ -112,7 +112,7 @@ 
         $config = $configFactory->factory($input);
 
         // files
-        if(null === $config->getPath()->getBasePath()) {
+        if (null === $config->getPath()->getBasePath()) {
             throw new \LogicException('Please provide a path to analyze');
         }
 
@@ -125,8 +125,8 @@ 
 
         // prepare plugins
         $repository = new Repository();
-        foreach($config->getExtensions()->getExtensions() as $filename) {
-            if(!file_exists($filename) ||!is_readable($filename)) {
+        foreach ($config->getExtensions()->getExtensions() as $filename) {
+            if (!file_exists($filename) || !is_readable($filename)) {
                 $output->writeln(sprintf('<error>Plugin %s skipped: not found</error>', $filename));
                 continue;
             }
@@ -150,8 +150,8 @@ 
         $output->writeln('');
 
         // provide data to extensions
-        if(($n = sizeof($repository->all())) > 0) {
-            $output->writeln(sprintf('%d %s. Executing analyzis', $n, ($n > 1 ? 'plugins are enabled' : 'plugin is enabled') ));
+        if (($n = sizeof($repository->all())) > 0) {
+            $output->writeln(sprintf('%d %s. Executing analyzis', $n, ($n > 1 ? 'plugins are enabled' : 'plugin is enabled')));
             $extensionService->receive($config, $collection, $aggregatedResults, $bounds);
         }
 
@@ -165,7 +165,7 @@ 
 
         // evaluation of success
         $rule = $config->getFailureCondition();
-        if(null !== $rule) {
+        if (null !== $rule) {
             $evaluator = new Evaluator($collection, $aggregatedResults, $bounds);
             $result = $evaluator->evaluate($rule);
             // fail if failure-condition is realized

src/Hal/Application/Config/Configuration.php

Doc Comments +1 added lines, -1 removed lines

@@ -188,7 +188,7 @@
     }
 
     /**
-     * @param array $extensions
+     * @param ExtensionsConfiguration $extensions
      * @return Configuration
      */
     public function setExtensions($extensions)

src/Hal/Application/Config/ConfigFactory.php

Spacing +13 added lines, -13 removed lines

@@ -37,7 +37,7 @@ 
         $locator = new ConfigLocator();
         $filename = $locator->locate($input->getOption('config'));
 
-        if(null !== $filename) {
+        if (null !== $filename) {
             $loader = new Loader($hydrator);
             $config = $loader->load($filename);
         } else {
@@ -46,21 +46,21 @@ 
 
         
         // then, overwrite configuration by arguments provided in run
-        strlen($input->getArgument('path')) > 0         && $config->getPath()->setBasePath($input->getArgument('path'));
-        strlen($input->getOption('extensions')) > 0     && $config->getPath()->setExtensions($input->getOption('extensions'));
-        strlen($input->getOption('excluded-dirs')) > 0  && $config->getPath()->setExcludedDirs($input->getOption('excluded-dirs'));
-        strlen($input->getOption('symlinks')) > 0       && $config->getPath()->setFollowSymlinks(true);
-        strlen($input->getOption('report-xml')) > 0     && $config->getLogging()->setReport('xml', $input->getOption('report-xml'));
-        strlen($input->getOption('report-cli')) > 0     && $config->getLogging()->setReport('cli', $input->getOption('report-cli'));
-        strlen($input->getOption('report-json')) > 0    && $config->getLogging()->setReport('json', $input->getOption('report-json'));
-        strlen($input->getOption('report-html')) > 0    && $config->getLogging()->setReport('html', $input->getOption('report-html'));
-        strlen($input->getOption('report-csv')) > 0     && $config->getLogging()->setReport('csv', $input->getOption('report-csv'));
+        strlen($input->getArgument('path')) > 0 && $config->getPath()->setBasePath($input->getArgument('path'));
+        strlen($input->getOption('extensions')) > 0 && $config->getPath()->setExtensions($input->getOption('extensions'));
+        strlen($input->getOption('excluded-dirs')) > 0 && $config->getPath()->setExcludedDirs($input->getOption('excluded-dirs'));
+        strlen($input->getOption('symlinks')) > 0 && $config->getPath()->setFollowSymlinks(true);
+        strlen($input->getOption('report-xml')) > 0 && $config->getLogging()->setReport('xml', $input->getOption('report-xml'));
+        strlen($input->getOption('report-cli')) > 0 && $config->getLogging()->setReport('cli', $input->getOption('report-cli'));
+        strlen($input->getOption('report-json')) > 0 && $config->getLogging()->setReport('json', $input->getOption('report-json'));
+        strlen($input->getOption('report-html')) > 0 && $config->getLogging()->setReport('html', $input->getOption('report-html'));
+        strlen($input->getOption('report-csv')) > 0 && $config->getLogging()->setReport('csv', $input->getOption('report-csv'));
         strlen($input->getOption('violations-xml')) > 0 && $config->getLogging()->setViolation('xml', $input->getOption('violations-xml'));
-        strlen($input->getOption('chart-bubbles')) > 0  && $config->getLogging()->setChart('bubbles', $input->getOption('chart-bubbles'));
-        strlen($input->getOption('failure-condition')) > 0  && $config->setFailureCondition($input->getOption('failure-condition'));
+        strlen($input->getOption('chart-bubbles')) > 0 && $config->getLogging()->setChart('bubbles', $input->getOption('chart-bubbles'));
+        strlen($input->getOption('failure-condition')) > 0 && $config->setFailureCondition($input->getOption('failure-condition'));
         strlen($input->getOption('template-title')) > 0 && $config->getTemplate()->setTitle($input->getOption('template-title'));
         strlen($input->getOption('offline')) > 0 && $config->getTemplate()->setOffline($input->getOption('offline'));
-        strlen($input->getOption('plugins')) > 0 && $config->getExtensions()->setExtensions(explode(',',  $input->getOption('plugins')));
+        strlen($input->getOption('plugins')) > 0 && $config->getExtensions()->setExtensions(explode(',', $input->getOption('plugins')));
         strlen($input->getOption('ignore-errors')) > 0 && $config->setIgnoreErrors(true);
 
         return $config;

src/Hal/Application/Extension/ExtensionService.php

Indentation +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
     /**
      * @var Repository
      */
-   private $repository;
+    private $repository;
 
     /**
      * ExtensionService constructor.

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     public function receive(Configuration $config, ResultCollection $collection, ResultCollection $aggregatedResults, Bounds $bounds)
     {
         // search controller
-        foreach($this->repository->all() as $item) {
+        foreach ($this->repository->all() as $item) {
             $item->receive($config, $collection, $aggregatedResults, $bounds);
         }
     }