Hal\Application\Config\File\ConfigFileReaderJson

Complexity

Total Complexity

18

Size/Duplication

Total Lines	91
Duplicated Lines	6.59 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
F	read()	6	58	15
A	resolvePath()	0	8	2

<?php

namespace Hal\Application\Config\File;

use Hal\Application\Config\Config;
use RecursiveArrayIterator;
use RecursiveIteratorIterator;

class ConfigFileReaderJson implements ConfigFileReaderInterface
{
    /**
     * @var string
     */
    private $filename;

    /**
     * @param string $filename
     */
    public function __construct($filename)
    {
        $this->filename = $filename;
    }

    /**
     * @param Config $config
     *
     * @return void
     */
    public function read(Config $config)
    {
        $jsonText = file_get_contents($this->filename);

        if (false === $jsonText) {
            throw new \InvalidArgumentException("Cannot read configuration file '{$this->filename}'");
        }

        $jsonData = json_decode($jsonText, true);

        if (false === $jsonData || null === $jsonData) {
            throw new \InvalidArgumentException("Bad json file '{$this->filename}'");
        }

        if (isset($jsonData['includes'])) {
            $includes = $jsonData['includes'];
            $files = [];
            // with config file, includes are relative to config file
            foreach ($includes as $include) {
                $include = $this->resolvePath($include);
                $files[] = $include;
            }
            $config->set('files', $files);
        }

        if (isset($jsonData['groups'])) {
            $config->set('groups', $jsonData['groups']);
        }

        if (isset($jsonData['extensions'])) {
            $config->set('extensions', implode(',', $jsonData['extensions']));
        }

        if (isset($jsonData['excludes'])) {
            // retro-compatibility
            // "exclude" is a string
            // excludes is an array
            $config->set('exclude', implode(',', $jsonData['excludes']));
        } else if (isset($jsonData['exclude'])) {
            $config->set('exclude', $jsonData['exclude']);
        }

        if (isset($jsonData['plugins'], $jsonData['plugins']['git'], $jsonData['plugins']['git']['binary'])) {

This code seems to be duplicated across your project.

            $config->set('git', $jsonData['plugins']['git']['binary']);
        }

        if (isset($jsonData['plugins'], $jsonData['plugins']['junit'], $jsonData['plugins']['junit']["report"])) {

This code seems to be duplicated across your project.

            $config->set('junit', $jsonData['plugins']['junit']["report"]);
        }

        // reports
        if (isset($jsonData['report']) && is_array($jsonData['report'])) {
            foreach ($jsonData['report'] as $reportType => $path) {
                $path = $this->resolvePath($path);
                $config->set('report-' . $reportType, $path);
            }
        }
    }

    /**
     * @return string
     */
    private function resolvePath($path)
    {
        if (DIRECTORY_SEPARATOR !== $path[0]) {
             $path = dirname($this->filename) . DIRECTORY_SEPARATOR . $path;
        }

        return $path;
    }
}