Completed
Pull Request — master (#448)
by
unknown
08:31
created
phpmetrics/src/Hal/Metric/System/Packages/Composer/Composer.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace Hal\Metric\System\Packages\Composer;
3 3
 
4 4
 use Hal\Application\Config\Config;
5
-use Hal\Application\Config\ConfigException;
6 5
 use Hal\Component\File\Finder;
7 6
 use Hal\Metric\Metrics;
8 7
 use Hal\Metric\ProjectMetric;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         }
52 52
 
53 53
         // exclude extensions
54
-        $packages = array_filter($packages, function ($package) {
54
+        $packages = array_filter($packages, function($package) {
55 55
             return !preg_match('!(^php$|^ext\-)!', $package->name);
56 56
         });
57 57
 
@@ -82,13 +82,13 @@  discard block
 block discarded – undo
82 82
             if ($fileContent === false) {
83 83
                 throw new ShouldNotHappenException('Get composer content return false');
84 84
             }
85
-            $composerJson = (object)\json_decode($fileContent);
85
+            $composerJson = (object) \json_decode($fileContent);
86 86
 
87 87
             if (!isset($composerJson->require)) {
88 88
                 continue;
89 89
             }
90 90
 
91
-            $rawRequirements[] = (array)$composerJson->require;
91
+            $rawRequirements[] = (array) $composerJson->require;
92 92
         }
93 93
 
94 94
         return \call_user_func_array('array_merge', $rawRequirements);
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             if ($fileContent === false) {
117 117
                 throw new ShouldNotHappenException('Get composer lock content return false');
118 118
             }
119
-            $composerLockJson = (object)\json_decode($fileContent);
119
+            $composerLockJson = (object) \json_decode($fileContent);
120 120
 
121 121
             if (!isset($composerLockJson->packages)) {
122 122
                 continue;
Please login to merge, or discard this patch.
phpmetrics/tests/Component/Tree/GraphDeduplicatedTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Test;
4 4
 
5
-use Hal\Component\Tree\Graph;
6 5
 use Hal\Component\Tree\GraphDeduplicated;
7 6
 use Hal\Component\Tree\Node;
8 7
 
Please login to merge, or discard this patch.
phpmetrics/tests/Component/Tree/Operator/SizeOfTreeTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Test;
4 4
 
5 5
 use Hal\Component\Tree\Graph;
6
-use Hal\Component\Tree\GraphFactory;
7 6
 use Hal\Component\Tree\Node;
8 7
 use Hal\Component\Tree\Operator\SizeOfTree;
9 8
 
Please login to merge, or discard this patch.
src/Console/CliInput.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
             if (trim($item) === '') {
40 40
                 continue;
41 41
             }
42
-            $this->exts[] = '*.' . ltrim(trim($item), '*.');
42
+            $this->exts[] = '*.'.ltrim(trim($item), '*.');
43 43
         }
44 44
 
45 45
         if (empty($this->exts)) {
Please login to merge, or discard this patch.
src/Parser/PhpParser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@
 block discarded – undo
36 36
         try {
37 37
             $stmt = $this->parser->parse($file->getContents());
38 38
         } catch (Error $exc) {
39
-            throw new ParserException($file->getRelativePathname() . ': ' . $exc->getMessage());
39
+            throw new ParserException($file->getRelativePathname().': '.$exc->getMessage());
40 40
         }
41 41
 
42 42
         if ($stmt === null) {
43
-            throw new ParserException('Parse function return null when parsing ' . $file->getRelativePathname());
43
+            throw new ParserException('Parse function return null when parsing '.$file->getRelativePathname());
44 44
         }
45 45
 
46 46
         $this->traverser->traverse($stmt);
Please login to merge, or discard this patch.
src/DiFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
      */
22 22
     public static function container(array $rules = []) : ContainerInterface
23 23
     {
24
-        $dirules = Json::decode(FileSystem::read(__DIR__ . '/dirules.json'), Json::FORCE_ARRAY);
24
+        $dirules = Json::decode(FileSystem::read(__DIR__.'/dirules.json'), Json::FORCE_ARRAY);
25 25
         $rlist = new DiRuleList();
26 26
         $rlist = $rlist->addRules($dirules);
27 27
         $rlist = $rlist->addRules($rules);
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Violation/Package/StableDependenciesPrinciple.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
 
23 23
     public function apply(Metric $metric)
24 24
     {
25
-        if (! $metric instanceof PackageMetric) {
25
+        if (!$metric instanceof PackageMetric) {
26 26
             return;
27 27
         }
28 28
         $instability = $metric->getInstability();
29 29
         $violatingInstabilities = array_filter(
30 30
             $metric->getDependentInstabilities(),
31
-            function ($otherInstability) use ($instability) {
31
+            function($otherInstability) use ($instability) {
32 32
                 return $otherInstability >= $instability;
33 33
             }
34 34
         );
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
 
58 58
         $count = count($this->violatingInstabilities);
59 59
         $thisInstability = round($value, 3);
60
-        $packages = implode("\n* ", array_map(function ($name, $instability) {
61
-            $name = $name === '\\' ? 'global' : substr((string)$name, 0, -1);
60
+        $packages = implode("\n* ", array_map(function($name, $instability) {
61
+            $name = $name === '\\' ? 'global' : substr((string) $name, 0, -1);
62 62
             $instability = round($instability, 3);
63 63
             return "$name ($instability)";
64 64
         }, array_keys($this->violatingInstabilities), $this->violatingInstabilities));
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Violation/Package/StableAbstractionsPrinciple.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,14 +19,14 @@
 block discarded – undo
19 19
 
20 20
     public function apply(Metric $metric)
21 21
     {
22
-        if (! $metric instanceof PackageMetric) {
22
+        if (!$metric instanceof PackageMetric) {
23 23
             return;
24 24
         }
25 25
         $distance = $metric->getDistance();
26 26
         if ($distance === null) {
27 27
             throw new ShouldNotHappenException('Distance is null');
28 28
         }
29
-        if (abs($distance) > sqrt(2)/4) {
29
+        if (abs($distance) > sqrt(2) / 4) {
30 30
             $this->metric = $metric;
31 31
             $metric->get('violations')->add($this);
32 32
         }
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/System/Changes/GitChanges.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
         $file = current($this->files);
67 67
         $realpath = realpath(dirname($file));
68 68
         if ($realpath === false) {
69
-            throw new ShouldNotHappenException('Cannot get realpath of ' . dirname($file));
69
+            throw new ShouldNotHappenException('Cannot get realpath of '.dirname($file));
70 70
         }
71 71
         $command = sprintf(
72 72
             "cd %s && %s log --format='* %%at\t%%cn' --numstat -n 500",
Please login to merge, or discard this patch.